Skip to content

Commit cc85c59

Browse files
fvictoriofvictorio
committed
Remove --isolated flag
1 parent 790ee4b commit cc85c59

23 files changed

+61
-53
lines changed

‎v-next/hardhat/src/internal/builtin-plugins/solidity/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ const buildTask = task("build", "Builds your project")
1919
description: "The default build profile to use",
2020
defaultValue: "default",
2121
})
22-
.addFlag({
23-
name: "isolated",
24-
description: "Use isolated mode, which prioritizes reproducibility",
25-
})
2622
.addVariadicArgument({
2723
name: "files",
2824
description: "An optional list of files to compile",

‎v-next/hardhat/src/internal/builtin-plugins/solidity/tasks/build.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ interface CompileActionArguments {
1010
files: string[];
1111
quiet: boolean;
1212
defaultBuildProfile: string | undefined;
13-
isolated: boolean;
1413
}
1514

1615
const buildAction: NewTaskActionFunction<CompileActionArguments> = async (
17-
{ force, files, quiet, defaultBuildProfile, isolated },
16+
{ force, files, quiet, defaultBuildProfile },
1817
{ solidity, globalOptions },
1918
) => {
2019
const rootPaths =
@@ -34,7 +33,6 @@ const buildAction: NewTaskActionFunction<CompileActionArguments> = async (
3433
force,
3534
buildProfile,
3635
quiet,
37-
isolated,
3836
});
3937

4038
throwIfSolidityBuildFailed(results);

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/add-a-dependant.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ describe("Partial compilation", () => {
105105
const project = new TestProjectWrapper(_project, hre);
106106

107107
// Compile first time
108-
await project.compile({ isolated: true });
108+
await project.compile({ defaultBuildProfile: "production" });
109109
const firstSnapshot = await project.getSnapshot();
110110

111111
assertFileCounts(firstSnapshot, 1, 1, 1);
@@ -117,7 +117,7 @@ describe("Partial compilation", () => {
117117
);
118118

119119
// Compile second time
120-
await project.compile({ isolated: true });
120+
await project.compile({ defaultBuildProfile: "production" });
121121
const secondSnapshot = await project.getSnapshot();
122122

123123
assertFileCounts(secondSnapshot, 2, 2, 2);

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/add-a-dependency.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ describe("Partial compilation", () => {
8181
const project = new TestProjectWrapper(_project, hre);
8282

8383
// Compile first time
84-
await project.compile({ isolated: true });
84+
await project.compile({ defaultBuildProfile: "production" });
8585
const firstSnapshot = await project.getSnapshot();
8686

8787
assertFileCounts(firstSnapshot, 1, 1, 1);
@@ -97,7 +97,7 @@ describe("Partial compilation", () => {
9797
);
9898

9999
// Compile second time
100-
await project.compile({ isolated: true });
100+
await project.compile({ defaultBuildProfile: "production" });
101101
const secondSnapshot = await project.getSnapshot();
102102

103103
assertFileCounts(secondSnapshot, 2, 2, 2);

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/add-a-file-then-modify-both.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ describe("Partial compilation", () => {
158158
const project = new TestProjectWrapper(_project, hre);
159159

160160
// Compile first time
161-
await project.compile({ isolated: true });
161+
await project.compile({ defaultBuildProfile: "production" });
162162
const firstSnapshot = await project.getSnapshot();
163163

164164
assertFileCounts(firstSnapshot, 1, 1, 1);
@@ -186,7 +186,7 @@ describe("Partial compilation", () => {
186186
);
187187

188188
// Compile second time
189-
await project.compile({ isolated: true });
189+
await project.compile({ defaultBuildProfile: "production" });
190190
const secondSnapshot = await project.getSnapshot();
191191

192192
assertFileCounts(secondSnapshot, 2, 2, 2);
@@ -251,7 +251,7 @@ describe("Partial compilation", () => {
251251
);
252252

253253
// Recompile
254-
await project.compile({ isolated: true });
254+
await project.compile({ defaultBuildProfile: "production" });
255255
const thirdSnapshot = await project.getSnapshot();
256256

257257
assertFileCounts(thirdSnapshot, 2, 2, 2);

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/compile-subset-two-indept-files.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ describe("Partial compilation", () => {
176176
process.chdir(_project.path);
177177

178178
// Compile first time
179-
await project.compile({ isolated: true });
179+
await project.compile({ defaultBuildProfile: "production" });
180180
const firstSnapshot = await project.getSnapshot();
181181

182182
assertFileCounts(firstSnapshot, 2, 2, 2);
@@ -217,7 +217,10 @@ describe("Partial compilation", () => {
217217
);
218218

219219
// Compile only Bar.sol
220-
await project.compile({ files: ["contracts/Bar.sol"], isolated: true });
220+
await project.compile({
221+
files: ["contracts/Bar.sol"],
222+
defaultBuildProfile: "production",
223+
});
221224
process.chdir(oldCwd);
222225

223226
const secondSnapshot = await project.getSnapshot();

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/from-scratch-three-files-A-B,C.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe("Partial compilation", () => {
8282
const project = new TestProjectWrapper(_project, hre);
8383

8484
// Compile first time
85-
await project.compile({ isolated: true });
85+
await project.compile({ defaultBuildProfile: "production" });
8686
const firstSnapshot = await project.getSnapshot();
8787

8888
// There should be 3 build infos
@@ -141,7 +141,7 @@ describe("Partial compilation", () => {
141141
assert.ok(firstSnapshot.typeFiles["Bar.sol"] !== undefined);
142142

143143
// Recompile
144-
await project.compile({ isolated: true });
144+
await project.compile({ defaultBuildProfile: "production" });
145145
const secondSnapshot = await project.getSnapshot();
146146

147147
// Nothing in the snapshot should have changed

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/from-scratch-three-files-A-B--C.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe("Partial compilation", () => {
8282
const project = new TestProjectWrapper(_project, hre);
8383

8484
// Compile first time
85-
await project.compile({ isolated: true });
85+
await project.compile({ defaultBuildProfile: "production" });
8686
const firstSnapshot = await project.getSnapshot();
8787

8888
// There should be 3 build infos
@@ -145,7 +145,7 @@ describe("Partial compilation", () => {
145145
assert.ok(firstSnapshot.typeFiles["FooFactory.sol"] !== undefined);
146146

147147
// Recompile
148-
await project.compile({ isolated: true });
148+
await project.compile({ defaultBuildProfile: "production" });
149149
const secondSnapshot = await project.getSnapshot();
150150

151151
// Nothing in the snapshot should have changed

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/from-scratch-three-files-A-B-C.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe("Partial compilation", () => {
8282
const project = new TestProjectWrapper(_project, hre);
8383

8484
// Compile first time
85-
await project.compile({ isolated: true });
85+
await project.compile({ defaultBuildProfile: "production" });
8686
const firstSnapshot = await project.getSnapshot();
8787

8888
// There should be 3 build infos
@@ -141,7 +141,7 @@ describe("Partial compilation", () => {
141141
assert.ok(firstSnapshot.typeFiles["IFoo.sol"] !== undefined);
142142

143143
// Recompile
144-
await project.compile({ isolated: true });
144+
await project.compile({ defaultBuildProfile: "production" });
145145
const secondSnapshot = await project.getSnapshot();
146146

147147
// Nothing in the snapshot should have changed

‎v-next/hardhat/test/internal/builtin-plugins/solidity/build-system/partial-compilation/from-scratch-two-connected-files.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe("Partial compilation", () => {
7474
const project = new TestProjectWrapper(_project, hre);
7575

7676
// Compile first time
77-
await project.compile({ isolated: true });
77+
await project.compile({ defaultBuildProfile: "production" });
7878
const firstSnapshot = await project.getSnapshot();
7979

8080
// There should be 2 build infos
@@ -120,7 +120,7 @@ describe("Partial compilation", () => {
120120
assert.ok(firstSnapshot.typeFiles["IFoo.sol"] !== undefined);
121121

122122
// Recompile
123-
await project.compile({ isolated: true });
123+
await project.compile({ defaultBuildProfile: "production" });
124124
const secondSnapshot = await project.getSnapshot();
125125

126126
// Nothing in the snapshot should have changed

0 commit comments

Comments
 (0)