Skip to content

Commit 3b026b8

Browse files
MarekPietakapi-no
authored andcommitted
samples: common: mcumgr_bt_ota_dfu: Align checks in CMakeLists.txt
Align the values used for configuration validation in `CMakeLists.txt` file with new Kconfig defaults to fix the validation. Jira: NCSDK-35623 Signed-off-by: Marek Pieta <[email protected]>
1 parent d911cb3 commit 3b026b8

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

samples/common/mcumgr_bt_ota_dfu/CMakeLists.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU_VALIDATION)
88
if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU_SPEEDUP AND CONFIG_HAS_BT_CTLR)
99
if((NOT (CONFIG_BT_BUF_ACL_TX_SIZE EQUAL 251)) OR
10-
(NOT (CONFIG_BT_BUF_ACL_RX_SIZE EQUAL 502)) OR
10+
(NOT (CONFIG_BT_BUF_ACL_RX_SIZE EQUAL 251)) OR
1111
(NOT (CONFIG_BT_CTLR_DATA_LENGTH_MAX EQUAL 251))
1212
)
1313
message(WARNING "MCUmgr Bluetooth OTA DFU: suboptimal configuration "
@@ -20,8 +20,8 @@ if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU_VALIDATION)
2020

2121
if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU_SPEEDUP AND CONFIG_BT_HCI_HOST)
2222
if((NOT (CONFIG_BT_BUF_ACL_TX_SIZE EQUAL 251)) OR
23-
(NOT (CONFIG_BT_BUF_ACL_RX_SIZE EQUAL 502)) OR
24-
(NOT (CONFIG_BT_L2CAP_TX_MTU EQUAL 498))
23+
(NOT (CONFIG_BT_BUF_ACL_RX_SIZE EQUAL 251)) OR
24+
(NOT (CONFIG_BT_L2CAP_TX_MTU EQUAL 247))
2525
)
2626
message(WARNING "MCUmgr Bluetooth OTA DFU: suboptimal configuration "
2727
"of Bluetooth Host buffers. Consider using optimal values "
@@ -33,7 +33,10 @@ if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU_VALIDATION)
3333

3434
if(CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU)
3535
if(CONFIG_MCUMGR_TRANSPORT_BT_REASSEMBLY)
36-
if(NOT (CONFIG_MCUMGR_TRANSPORT_NETBUF_SIZE EQUAL 2475))
36+
# Allow for using default value specified by `nrf/samples/common/mcumgr_bt_ota_dfu/Kconfig`
37+
# or `nrf/Kconfig.nrf`.
38+
if((NOT (CONFIG_MCUMGR_TRANSPORT_NETBUF_SIZE EQUAL 1230)) AND
39+
(NOT (CONFIG_MCUMGR_TRANSPORT_NETBUF_SIZE EQUAL 2475)))
3740
message(WARNING "MCUmgr Bluetooth OTA DFU: suboptimal configuration "
3841
"of the MCUmgr buffer with the Reassembly feature support. Consider using"
3942
"the optimal value defined in the ${CMAKE_CURRENT_LIST_DIR}/Kconfig "

0 commit comments

Comments
 (0)