Skip to content

Commit bc8a095

Browse files
Adam-MaciugaArekBalysNordic
authored andcommitted
bugfix: applications: matter bridge: fixed units
temerature and humidity units were off fixed them to display correct value on ecosystems Signed-off-by: Adam Maciuga <[email protected]>
1 parent 11f6c2a commit bc8a095

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

applications/matter_bridge/src/simulated_providers/simulated_humidity_sensor_data_provider.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,8 @@ void SimulatedHumiditySensorDataProvider::TimerTimeoutCallback(k_timer *timer)
6262
reinterpret_cast<SimulatedHumiditySensorDataProvider *>(p);
6363

6464
/* Get some random data to emulate sensor measurements. */
65-
provider->mHumidity =
66-
chip::Crypto::GetRandU16() % (kMaxRandomTemperature - kMinRandomTemperature) +
67-
kMinRandomTemperature;
65+
provider->mHumidity = chip::Crypto::GetRandU16() % (kMaxRandomHumidity - kMinRandomHumidity) +
66+
kMinRandomHumidity;
6867

6968
LOG_INF("SimulatedHumiditySensorDataProvider: Updated humidity value to %d",
7069
provider->mHumidity);

applications/matter_bridge/src/simulated_providers/simulated_humidity_sensor_data_provider.h

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010

1111
class SimulatedHumiditySensorDataProvider : public Nrf::BridgedDeviceDataProvider {
1212
public:
13-
SimulatedHumiditySensorDataProvider(UpdateAttributeCallback updateCallback, InvokeCommandCallback commandCallback) : Nrf::BridgedDeviceDataProvider(updateCallback, commandCallback) {}
13+
SimulatedHumiditySensorDataProvider(UpdateAttributeCallback updateCallback,
14+
InvokeCommandCallback commandCallback)
15+
: Nrf::BridgedDeviceDataProvider(updateCallback, commandCallback)
16+
{
17+
}
1418
~SimulatedHumiditySensorDataProvider() { k_timer_stop(&mTimer); }
1519
void Init() override;
1620
void NotifyUpdateState(chip::ClusterId clusterId, chip::AttributeId attributeId, void *data,
@@ -21,8 +25,8 @@ class SimulatedHumiditySensorDataProvider : public Nrf::BridgedDeviceDataProvide
2125
static void TimerTimeoutCallback(k_timer *timer);
2226

2327
static constexpr uint16_t kMeasurementsIntervalMs = 10000;
24-
static constexpr uint16_t kMinRandomTemperature = 30;
25-
static constexpr uint16_t kMaxRandomTemperature = 50;
28+
static constexpr uint16_t kMinRandomHumidity = 3000;
29+
static constexpr uint16_t kMaxRandomHumidity = 5000;
2630

2731
k_timer mTimer;
2832
uint16_t mHumidity = 0;

applications/matter_bridge/src/simulated_providers/simulated_temperature_sensor_data_provider.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class SimulatedTemperatureSensorDataProvider : public Nrf::BridgedDeviceDataProv
2626

2727
private:
2828
static constexpr uint16_t kMeasurementsIntervalMs = 10000;
29-
static constexpr int16_t kMinRandomTemperature = -10;
30-
static constexpr int16_t kMaxRandomTemperature = 10;
29+
static constexpr int16_t kMinRandomTemperature = -1000;
30+
static constexpr int16_t kMaxRandomTemperature = 1000;
3131

3232
static void TimerTimeoutCallback(k_timer *timer);
3333

0 commit comments

Comments
 (0)