Skip to content

Commit df66d26

Browse files
Merge pull request #1236 from NordicSemiconductor/push-vmzvkpvyrotr
De-bootstrapify some components
2 parents dda43c8 + b9c18c3 commit df66d26

File tree

19 files changed

+1478
-1587
lines changed

19 files changed

+1478
-1587
lines changed

Changelog.minor.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ release the new version.
5050
- #1216: Sort sources in settings view.
5151
- #1223: Create log for messages from the renderer process in
5252
`nrfconnect/logs/renderer.log`.
53-
- #1235: Move some styling to use Tailwind.
53+
- #1235, #1236: Move some styling to use Tailwind.
5454

5555
### Fixed
5656

src/launcher/features/about/About.tsx

Lines changed: 7 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,46 +6,28 @@
66

77
import React from 'react';
88
import Button from 'react-bootstrap/Button';
9-
import Card from 'react-bootstrap/Card';
10-
import Col from 'react-bootstrap/Col';
11-
import Row from 'react-bootstrap/Row';
129
import { app } from '@electron/remote';
1310

14-
import NrfCard from '../../util/NrfCard';
1511
import WithScrollbarContainer from '../../util/WithScrollbarContainer';
12+
import Card from '../layout/Card';
1613

1714
const appVersion = app.getVersion();
1815

1916
export default () => (
2017
<WithScrollbarContainer>
21-
<NrfCard>
22-
<Row>
23-
<Col>
24-
<Card.Title>Version</Card.Title>
25-
</Col>
26-
</Row>
18+
<Card title="Version">
2719
<p>nRF Connect for Desktop v{appVersion}</p>
28-
</NrfCard>
29-
<NrfCard>
30-
<Row>
31-
<Col>
32-
<Card.Title>Documentation</Card.Title>
33-
</Col>
34-
</Row>
20+
</Card>
21+
<Card title="Documentation">
3522
<Button
3623
href="https://docs.nordicsemi.com/bundle/nrf-connect-desktop/page/index.html"
3724
target="_blank"
3825
variant="outline-primary"
3926
>
4027
Open documentation
4128
</Button>
42-
</NrfCard>
43-
<NrfCard>
44-
<Row>
45-
<Col>
46-
<Card.Title>License</Card.Title>
47-
</Col>
48-
</Row>
29+
</Card>
30+
<Card title="License">
4931
<p>Copyright (c) 2015-2024 Nordic Semiconductor ASA</p>
5032
<p>All rights reserved.</p>
5133
<p>SPDX-License-Identifier: Nordic-4-Clause</p>
@@ -107,6 +89,6 @@ export default () => (
10789
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
10890
THE POSSIBILITY OF SUCH DAMAGE.
10991
</p>
110-
</NrfCard>
92+
</Card>
11193
</WithScrollbarContainer>
11294
);

src/launcher/features/apps/App/App.tsx

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66

77
import React, { useEffect, useRef } from 'react';
88
import ButtonToolbar from 'react-bootstrap/ButtonToolbar';
9-
import Col from 'react-bootstrap/Col';
109
import DropdownButton from 'react-bootstrap/DropdownButton';
1110
import ListGroup from 'react-bootstrap/ListGroup';
12-
import Row from 'react-bootstrap/Row';
1311

1412
import { OFFICIAL } from '../../../../common/sources';
1513
import { isInstalled, isUpdatable, isWithdrawn } from '../../../../ipc/apps';
1614
import formatPublishTimestamp from '../../../util/formatTimestamp';
15+
import Col from '../../layout/Col';
16+
import Row from '../../layout/Row';
1717
import { DisplayedApp } from '../appsSlice';
1818
import AppIcon from './AppIcon';
1919
import AppProgress from './AppProgress';
@@ -69,14 +69,20 @@ const App = ({ app }: { app: DisplayedApp }) => {
6969

7070
return (
7171
<ListGroup.Item ref={itemRef}>
72-
<Row noGutters className="py-1">
73-
<Col xs="auto" className="d-flex align-items-start my-2 mr-3">
72+
<Row noGutters className="tw-flex-nowrap tw-py-1">
73+
<Col
74+
fixedSize
75+
noPadding
76+
className="tw-my-2 tw-mr-4 tw-flex tw-items-start"
77+
>
7478
<AppIcon app={app} />
7579
</Col>
76-
<Col>
77-
<div className="h8">{app.displayName || app.name}</div>
78-
<div className="small text-muted">{app.description}</div>
79-
<div className="small text-muted-more">
80+
<Col noPadding className="tw-w-full tw-flex-initial">
81+
<div>{app.displayName || app.name}</div>
82+
<div className="tw-text-sm tw-text-gray-600">
83+
{app.description}
84+
</div>
85+
<div className="tw-text-sm tw-text-gray-200">
8086
{app.source}
8187
{isInstalled(app) && <>, v{app.currentVersion}</>}
8288
{isInstalled(app) && app.source !== OFFICIAL && (
@@ -99,8 +105,8 @@ const App = ({ app }: { app: DisplayedApp }) => {
99105
</div>
100106
</Col>
101107
<Col
102-
xs="auto"
103-
className="d-flex align-items-center my-3 ml-auto pl-3"
108+
fixedSize
109+
className="tw-my-4 tw-ml-auto tw-flex tw-items-center tw-pr-0"
104110
>
105111
<ButtonToolbar className="wide-btns">
106112
<UpdateApp app={app} />

0 commit comments

Comments
 (0)