refactor: move FindLocalConfig

Author: damienbutt

.goreleaser.yml

@@ -82,14 +82,3 @@ scoops:
     homepage: https://github.com/Norgate-AV/spc
     description: "CLI wrapper for the Crestron SIMPL+ Compiler"
     license: MIT
-
-winget:
-  - publisher: damienbutt
-    release_notes_url: "https://github.com/Norgate-AV/spc/releases/tag/{{.Tag}}"
-    license_url: https://github.com/Norgate-AV/spc/blob/main/LICENSE
-    short_description: "CLI wrapper for the Crestron SIMPL+ Compiler"
-    license: MIT
-    repository:
-      owner: "damienbutt"
-      name: winget-pkgs
-      token: "{{ .Env.RELEASE_TOKEN }}"

internal/config/finder.go

@@ -0,0 +1,28 @@
+package config
+
+import (
+	"os"
+	"path/filepath"
+)
+
+// FindLocalConfig finds local config file by walking up directories
+func FindLocalConfig(dir string) string {
+	for {
+		for _, ext := range []string{"yml", "yaml", "json", "toml"} {
+			path := filepath.Join(dir, ".spc."+ext)
+
+			if _, err := os.Stat(path); err == nil {
+				return path
+			}
+		}
+
+		parent := filepath.Dir(dir)
+		if parent == dir {
+			break
+		}
+
+		dir = parent
+	}
+
+	return ""
+}

internal/config/finder_test.go

@@ -0,0 +1,34 @@
+package config
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFindLocalConfig(t *testing.T) {
+	// Create a temporary directory structure
+	tempDir := t.TempDir()
+	subDir := filepath.Join(tempDir, "subdir")
+	err := os.Mkdir(subDir, 0o755)
+	assert.NoError(t, err)
+
+	// Create config files
+	configYML := filepath.Join(subDir, ".spc.yml")
+	err = os.WriteFile(configYML, []byte("target: \"3\""), 0o644)
+	assert.NoError(t, err)
+
+	// Test finding in subdir
+	result := FindLocalConfig(subDir)
+	assert.Equal(t, configYML, result)
+
+	// Test finding in parent
+	result = FindLocalConfig(filepath.Join(subDir, "deep"))
+	assert.Equal(t, configYML, result)
+
+	// Test not found
+	result = FindLocalConfig(tempDir)
+	assert.Equal(t, "", result)
+}

internal/config/loader.go

@@ -6,8 +6,6 @@ import (
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
-
-	"github.com/Norgate-AV/spc/internal/utils"
 )
 
 // Loader handles configuration loading from various sources
@@ -65,7 +63,7 @@ func (l *Loader) loadLocalConfig(args []string) {
 		}
 
 		dir := filepath.Dir(absFirstFile)
-		localPath := utils.FindLocalConfig(dir)
+		localPath := FindLocalConfig(dir)
 		if localPath != "" {
 			viper.SetConfigFile(localPath)
 			_ = viper.ReadInConfig()

internal/utils/target.go

@@ -1,8 +1,6 @@
 package utils
 
 import (
-	"os"
-	"path/filepath"
 	"strconv"
 )
 
@@ -18,25 +16,3 @@ func ParseTarget(t string) []string {
 
 	return series
 }
-
-// FindLocalConfig finds local config file by walking up directories
-func FindLocalConfig(dir string) string {
-	for {
-		for _, ext := range []string{"yml", "yaml", "json", "toml"} {
-			path := filepath.Join(dir, ".spc."+ext)
-
-			if _, err := os.Stat(path); err == nil {
-				return path
-			}
-		}
-
-		parent := filepath.Dir(dir)
-		if parent == dir {
-			break
-		}
-
-		dir = parent
-	}
-
-	return ""
-}

internal/utils/target_test.go

@@ -1,8 +1,6 @@
 package utils
 
 import (
-	"os"
-	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -29,28 +27,3 @@ func TestParseTarget(t *testing.T) {
 		assert.Equal(t, test.expected, result, "ParseTarget(%q)", test.input)
 	}
 }
-
-func TestFindLocalConfig(t *testing.T) {
-	// Create a temporary directory structure
-	tempDir := t.TempDir()
-	subDir := filepath.Join(tempDir, "subdir")
-	err := os.Mkdir(subDir, 0o755)
-	assert.NoError(t, err)
-
-	// Create config files
-	configYML := filepath.Join(subDir, ".spc.yml")
-	err = os.WriteFile(configYML, []byte("target: \"3\""), 0o644)
-	assert.NoError(t, err)
-
-	// Test finding in subdir
-	result := FindLocalConfig(subDir)
-	assert.Equal(t, configYML, result)
-
-	// Test finding in parent
-	result = FindLocalConfig(filepath.Join(subDir, "deep"))
-	assert.Equal(t, configYML, result)
-
-	// Test not found
-	result = FindLocalConfig(tempDir)
-	assert.Equal(t, "", result)
-}