Skip to content

Commit 0b1cb75

Browse files
committed
Fix tests
1 parent bbfbcec commit 0b1cb75

15 files changed

+22
-37
lines changed

book/app-actions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ What's the final goal of the `window.appActions.signup` app action? Simply, call
6363
-cy.findByPlaceholderText(strings.email).type(user.email);
6464
-cy.findByPlaceholderText(strings.password).type(user.password);
6565
-cy.get("form")
66-
- .within(() => cy.findByText(strings.signUp))
67-
- .click();
66+
- .within(() => cy.findByText(strings.signUp).click())
6867
+cy.window()
6968
+ .its("appActions")
7069
+ .invoke("signup", user);

book/app-constants.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ context("Signup flow", () => {
4646
+ cy.findByPlaceholderText(strings.password).type("mysupersecretpassword");
4747
cy.get("form")
4848
- .within(() => cy.findByText("Sign up"))
49-
+ .within(() => cy.findByText(strings.signUp))
50-
.click();
49+
- .click();
50+
+ .within(() => cy.findByText(strings.signUp).click())
5151
cy.findByText("No articles are here... yet.", { timeout: 10000 }).should("be.visible");
5252
});
5353
});
@@ -66,8 +66,7 @@ context("Signup flow", () => {
6666
cy.findByPlaceholderText(strings.email).type(`user+${random}@realworld.io`);
6767
cy.findByPlaceholderText(strings.password).type("mysupersecretpassword");
6868
cy.get("form")
69-
.within(() => cy.findByText(strings.signUp))
70-
.click();
69+
.within(() => cy.findByText(strings.signUp).click())
7170
cy.findByText("No articles are here... yet.", { timeout: 10000 }).should(
7271
"be.visible"
7372
);

book/controlling-the-clock.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ context("Signup flow", () => {
1212

1313
// form submit...
1414
cy.get("form")
15-
.within(() => cy.findByText(strings.signUp))
16-
.click();
15+
.within(() => cy.findByText(strings.signUp).click());
1716

1817
// moves forward the browser clock by 2 seconds
1918
cy.tick(2000);

book/payload-assertions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ it("The happy path should work", () => {
123123

124124
// form submit...
125125
cy.get("form")
126-
.within(() => cy.findByText(strings.signUp))
127-
.click();
126+
.within(() => cy.findByText(strings.signUp).click());
128127
// ... and AJAX call waiting
129128
- cy.wait("@signup-request");
130129
+ cy.wait("@signup-request")

book/waiting-for-ajax-request.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ it("The happy path should work", () => {
6969
cy.visit(paths.register);
7070
// form filling code
7171
cy.get("form")
72-
.within(() => cy.findByText(strings.signUp))
73-
.click();
72+
.within(() => cy.findByText(strings.signUp).click());
7473
+ cy.wait("@signup-request");
7574
cy.findByText(noArticles, { timeout: 10000 }).should("be.visible");
7675
});
@@ -98,8 +97,7 @@ it("The happy path should work", () => {
9897
cy.findByPlaceholderText(strings.email).type(`user+${random}@realworld.io`);
9998
cy.findByPlaceholderText(strings.password).type("mysupersecretpassword");
10099
cy.get("form")
101-
.within(() => cy.findByText(strings.signUp))
102-
.click();
100+
.within(() => cy.findByText(strings.signUp).click());
103101
+ cy.wait("@signup-request");
104102
- cy.findByText(noArticles, { timeout: 10000 }).should("be.visible");
105103
+ cy.findByText(noArticles).should("be.visible");

cypress/integration/examples/signup-integration/signup-1.integration.spec.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@ context("Signup flow", () => {
3131
// form filling
3232
cy.findByPlaceholderText(strings.username)
3333
.type(user.username)
34-
.findByPlaceholderText(strings.email)
34+
cy.findByPlaceholderText(strings.email)
3535
.type(user.email)
36-
.findByPlaceholderText(strings.password)
36+
cy.findByPlaceholderText(strings.password)
3737
.type(user.password);
3838

3939
// form submit...
4040
cy.get("form")
41-
.within(() => cy.findByText(strings.signUp))
42-
.click();
41+
.within(() => cy.findByText(strings.signUp).click())
4342

4443
// ... and AJAX call waiting
4544
cy.wait("@signup-request")

cypress/integration/examples/signup-integration/signup-2.integration.spec.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,14 @@ context("Signup flow", () => {
2323
// form filling
2424
cy.findByPlaceholderText(strings.username)
2525
.type(user.username)
26-
.findByPlaceholderText(strings.email)
26+
cy.findByPlaceholderText(strings.email)
2727
.type(user.email)
28-
.findByPlaceholderText(strings.password)
28+
cy.findByPlaceholderText(strings.password)
2929
.type(user.password);
3030

3131
// form submit...
3232
cy.get("form")
33-
.within(() => cy.findByText(strings.signUp))
34-
.click();
33+
.within(() => cy.findByText(strings.signUp).click());
3534

3635
// ... and AJAX call waiting
3736
cy.wait("@signup-request")

cypress/integration/examples/signup/signup-4-cypress-testing-library.e2e.spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ context("Signup flow", () => {
88
cy.findByPlaceholderText("Email").type(`user+${random}@realworld.io`);
99
cy.findByPlaceholderText("Password").type("mysupersecretpassword");
1010
cy.get("form")
11-
.within(() => cy.findByText("Sign up"))
12-
.click();
11+
.within(() => cy.findByText("Sign up").click())
1312
cy.findByText("No articles are here... yet.", { timeout: 10000 }).should("be.visible");
1413
});
1514
});

cypress/integration/examples/signup/signup-5-app-constants.e2e.spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ context("Signup flow", () => {
1212
cy.findByPlaceholderText(strings.email).type(`user+${random}@realworld.io`);
1313
cy.findByPlaceholderText(strings.password).type("mysupersecretpassword");
1414
cy.get("form")
15-
.within(() => cy.findByText(strings.signUp))
16-
.click();
15+
.within(() => cy.findByText(strings.signUp).click());
1716
cy.findByText(noArticles, { timeout: 10000 }).should("be.visible");
1817
});
1918
});

cypress/integration/examples/signup/signup-6-ajax-request-waiting.e2e.spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ context("Signup flow", () => {
2020

2121
// form submit...
2222
cy.get("form")
23-
.within(() => cy.findByText(strings.signUp))
24-
.click();
23+
.within(() => cy.findByText(strings.signUp).click());
2524
// ... and AJAX call waiting
2625
cy.wait("@signup-request");
2726

0 commit comments

Comments
 (0)