Add Ansible sanity tests to the github action

Author: Fdall

.github/workflows/ci.yml

@@ -10,7 +10,23 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: '3.11'
-      - run: pip install -r ci/requirements.txt
-      - run: pip install -r utils/python/requirements/base-requirements.txt
-      - run: pip install -r utils/python/requirements/roles-requirements.txt
-      - run: python -m unittest discover -s tests/unit/plugins/modules
+      - run: |
+          pip install -r ci/requirements.txt -r utils/python/requirements/base-requirements.txt -r utils/python/requirements/roles-requirements.txt
+          python -m unittest discover -s tests/unit/plugins/modules
+
+      - uses: dtolnay/rust-toolchain@1.91.0
+      - name: Run typos check
+        run: |
+          cargo install -f typos-cli --version=1.39.2
+          typos
+
+      - uses: actions/checkout@v4
+        with:
+          path: ansible_collections/rudder/rudder
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - run: pip install ansible-core
+      - name: Run sanity tests
+        working-directory: ansible_collections/rudder/rudder
+        run: ansible-test sanity

plugins/inventory/nodes.py

@@ -435,7 +435,7 @@ def main():
     module = AnsibleModule(
         argument_spec=dict(
             rudder_url=dict(type='str', required=False),
-            rudder_token=dict(type='str', required=False),
+            rudder_token=dict(type='str', required=False, no_log=True),
             node_id=dict(type='str', required=False),
             properties=dict(
                 type='list',
@@ -449,6 +449,7 @@ def main():
             agent_key=dict(
                 type='dict',
                 required=False,
+                no_log=True,
                 options=dict(
                     value=dict(required=False, type='str'),
                     status=dict(

plugins/inventory/rudder.ini

@@ -74,12 +74,10 @@
 """
 
 import json
-import traceback
 from urllib.error import HTTPError
+from ansible.module_utils.urls import open_url
 
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.urls import basic_auth_header, fetch_url, open_url
-from ansible.module_utils.common.text.converters import to_native
 
 __metaclass__ = type
 
@@ -229,7 +227,7 @@ def main():
                 'required': False,
                 'default': 'https://localhost/rudder',
             },
-            'rudder_token': {'type': 'str', 'required': False},
+            'rudder_token': {'type': 'str', 'required': False, "no_log": True},
             'name': {'type': 'str', 'required': True},
             'value': {'type': 'raw', 'required': True},
             'validate_certs': {'type': 'bool', 'default': True},
@@ -245,7 +243,8 @@ def main():
         try:
             value = module.from_json(module.params['value'])
         except Exception:
-            value = value
+            # value = value
+            pass
 
     rudder_server_iface = RudderSettingsInterface(module)
 

plugins/modules/node_settings.py

@@ -41,7 +41,11 @@ class TestStringMethods(unittest.TestCase):
                         'value': '1',
                     },
                 ],
-                'where=[{"objectType":"node","attribute":"OS","comparator":"eq","value":"Linux"},{"objectType":"node","attribute":"osFullName","comparator":"regex","value":".*Linux.*"},{"objectType":"memoryPhysicalElement","attribute":"quantity","comparator":"gteq","value":"1"}]',
+                'where=[' +
+                '{"objectType":"node","attribute":"OS","comparator":"eq","value":"Linux"},' +
+                '{"objectType":"node","attribute":"osFullName","comparator":"regex","value":".*Linux.*"},' +
+                '{"objectType":"memoryPhysicalElement","attribute":"quantity","comparator":"gteq","value":"1"}' +
+                ']'
             ],
         ]
     )