fix: stuf

Signed-off-by: Awar Abdulkarim <48431495+NotAwar@users.noreply.github.com>

Author: NotAwar

.github/actions/submit_sdk/action.yml

@@ -26,6 +26,7 @@ runs:
     - name: Check inputs
       shell: bash
       run: |
+        sudo -i
         if [ -z "${{ inputs.catalog-url }}" ] ; then
           echo "Invalid catalog-url: ${{ inputs.catalog-url }}"
           exit 1
@@ -49,6 +50,7 @@ runs:
     - name: Submit SDK
       shell: bash
       run: |
+        sudo -i
         curl -sX 'GET' \
           '${{ inputs.catalog-url }}/api/v0/0/sdk?length=500' \
           -H 'Accept: application/json' > sdk_versions.json

.github/workflows/build.yml

@@ -17,15 +17,13 @@ permissions: write-all
 jobs:  
   main:
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     strategy:
       fail-fast: false
       matrix:
         target: [f7, f18]
     steps:
       - name: 'Wipe workspace'
-        run: find ./ -mount -maxdepth 1 -exec rm -rf {} \;
+        run: sudo find ./ -mount -maxdepth 1 -exec rm -rf {} \;
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -36,6 +34,8 @@ jobs:
       - name: 'Get commit details'
         id: names
         run: |
+          set -e
+          sudo -i
           BUILD_TYPE='DEBUG=1 COMPACT=0'
           if [[ ${{ github.event_name }} == 'pull_request' ]]; then
             TYPE="pull"
@@ -54,6 +54,7 @@ jobs:
       - name: 'Check API versions for consistency between targets'
         run: |
           set -e
+          sudo -i
           N_API_HEADER_SIGNATURES=`ls -1 targets/f*/api_symbols.csv | xargs -I {} sh -c "head -n2 {} | md5sum" | sort -u | wc -l`
           if [ $N_API_HEADER_SIGNATURES != 1 ] ; then
             echo API versions aren\'t matching for available targets. Please update!
@@ -65,16 +66,21 @@ jobs:
       - name: 'Build the firmware and apps'
         id: build-fw
         run: |
+          set -e
+          sudo -i
           ./fbt TARGET_HW=$TARGET_HW $FBT_BUILD_TYPE copro_dist updater_package fap_dist
           echo "firmware_api=$(./fbt TARGET_HW=$TARGET_HW get_apiversion)" >> $GITHUB_OUTPUT
 
       - name: 'Check for uncommitted changes'
         run: |
+          set -e
+          sudo -i
           git diff --exit-code
 
       - name: 'Copy build output'
         run: |
           set -e
+          sudo -i
           rm -rf artifacts map_analyser_files || true
           mkdir artifacts map_analyser_files
           cp dist/${TARGET}-*/* artifacts/ || true
@@ -88,12 +94,16 @@ jobs:
       - name: 'Copy universal artifacts'
         if: ${{ !github.event.pull_request.head.repo.fork && matrix.target == env.DEFAULT_TARGET }}
         run: |
+          set -e
+          sudo -i
           tar czpf "artifacts/flipper-z-any-scripts-${SUFFIX}.tgz" scripts
           cp build/core2_firmware.tgz "artifacts/flipper-z-any-core2_firmware-${SUFFIX}.tgz"
 
       - name: 'Upload artifacts to update server'
         if: ${{ !github.event.pull_request.head.repo.fork }}
         run: |
+          set -e
+          sudo -i
           FILES=$(for ARTIFACT in $(find artifacts -maxdepth 1 -not -type d); do echo "-F files=@${ARTIFACT}"; done)
           curl --fail -L -H "Token: ${{ secrets.INDEXER_TOKEN }}" \
               -F "branch=${BRANCH_NAME}" \
@@ -104,6 +114,8 @@ jobs:
       - name: 'Copy & analyse map analyser files'
         if: ${{ !github.event.pull_request.head.repo.fork && matrix.target == env.DEFAULT_TARGET }}
         run: |
+          set -e
+          sudo -i
           cp build/${DEFAULT_TARGET}-firmware-*/firmware.elf.map map_analyser_files/firmware.elf.map
           cp build/${DEFAULT_TARGET}-firmware-*/firmware.elf map_analyser_files/firmware.elf
           source scripts/toolchain/fbtenv.sh

.github/workflows/build_compact.yml

@@ -31,6 +31,7 @@ jobs:
 
       - name: 'Get commit details'
         run: |
+          sudo -i
           if [[ ${{ github.event_name }} == 'pull_request' ]]; then
             TYPE="pull"
           elif [[ "${{ github.ref }}" == "refs/tags/"* ]]; then
@@ -44,6 +45,7 @@ jobs:
         id: build-fw
         run: |
           set -e
+          sudo -i
           TARGET="$(echo '${{ matrix.target }}' | sed 's/f//')"; \
           ./fbt TARGET_HW=$TARGET DEBUG=0 COMPACT=1 fap_dist updater_package
           echo "sdk-file=$(ls dist/${{ matrix.target }}-*/flipper-z-${{ matrix.target }}-sdk-*.zip)" >> $GITHUB_OUTPUT
@@ -58,13 +60,17 @@ jobs:
 
       - name: Build test app with SDK
         run: |
+          set -e
+          sudo -i
           mkdir testapp
           cd testapp
           ufbt create APPID=testapp
           ufbt
 
       - name: Build example & external apps with uFBT
         run: |
+          set -e
+          sudo -i
           for appdir in 'applications/examples'; do
             for app in $(find "$appdir" -maxdepth 1 -mindepth 1 -type d); do
               pushd $app
@@ -86,7 +92,5 @@ jobs:
 #    needs: [compact]
 #    if: always() && !contains(needs.*.result, 'failure')
 #    runs-on: ubuntu-latest
-    #  container:
-    #   options: --user root
     # steps:
     #   - run: echo "All good ✨" ;

.github/workflows/docs.yml

@@ -15,15 +15,15 @@ jobs:
   check-secret:
     if: ${{ github.event.pull_request.head.repo.fork == false }}
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     outputs:
       s3-valid-config: ${{ steps.check.outputs.s3-valid-config }}
 
     steps:
       - name: 'Check if S3 key exists'
         id: check
         run: |
+          set -e
+          sudo -i
           if [[ -z "${{ secrets.FW_DOCS_AWS_ACCESS_KEY }}" || -z "${{ secrets.FW_DOCS_AWS_SECRET_KEY }}" || -z "${{ secrets.FW_DOCS_AWS_BUCKET }}" ]]; then
             echo "s3-valid-config=false" >> $GITHUB_OUTPUT;
           else
@@ -33,12 +33,10 @@ jobs:
   doxygen:
     if: ${{ github.event.pull_request.head.repo.fork == false }}
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     needs: check-secret
     steps:
       - name: 'Wipe workspace'
-        run: find ./ -mount -maxdepth 1 -exec rm -rf {} \;
+        run: sudo find ./ -mount -maxdepth 1 -exec rm -rf {} \;
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -50,6 +48,8 @@ jobs:
       - name: 'Get commit details'
         id: names
         run: |
+          set -e
+          sudo -i
           if [[ ${{ github.event_name }} == 'pull_request' ]]; then
             TYPE="pull"
           elif [[ "${{ github.ref }}" == "refs/tags/"* ]]; then
@@ -65,7 +65,7 @@ jobs:
           version: "1.12.0"
 
       - name: 'Generate documentation'
-        run: ./fbt doxygen
+        run: sudo ./fbt doxygen
 
       - name: 'Upload documentation'
         if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/dev' && needs.check-secret.outputs.s3-valid-config == 'true' }}

.github/workflows/lint_and_submodule_check.yml

@@ -11,11 +11,9 @@ permissions: write-all
 jobs:
   lint_sources_check_submodules:
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     steps:
       - name: 'Wipe workspace'
-        run: find ./ -mount -maxdepth 1 -exec rm -rf {} \;
+        run: sudo find ./ -mount -maxdepth 1 -exec rm -rf {} \;
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -25,6 +23,8 @@ jobs:
 
       - name: 'Check protobuf branch'
         run: |
+          set -e
+          sudo -i
           git submodule update --init;
           SUB_PATH="assets/protobuf";
           SUB_BRANCH="dev";
@@ -48,6 +48,8 @@ jobs:
         id: check_todos
         working-directory: ./
         run: |
+          set -e
+          sudo -i
           # Use our new TODO tracker script
           python scripts/tools/todo_tracker.py --root . --output pr_todo_report --format json
           
@@ -67,7 +69,8 @@ jobs:
         id: syntax_check_py
         if: always()
         run: |
-          set +e;
+          set -e
+          sudo -i
           ./fbt -s lint_py 2>&1 | tee lint-py.log;
           if [ "${PIPESTATUS[0]}" -ne 0 ]; then
             # Save multiline output
@@ -84,7 +87,8 @@ jobs:
         id: syntax_check_cpp
         if: always()
         run: |
-          set +e;
+          set -e
+          sudo -i
           ./fbt -s lint 2>&1 | tee lint-cpp.log;
           if [ "${PIPESTATUS[0]}" -ne 0 ]; then
             # Save multiline output
@@ -100,7 +104,8 @@ jobs:
       - name: 'Check image assets'
         if: always()
         run: |
-          set +e;
+          set -e
+          sudo -i
           ./fbt -s lint_img 2>&1 | tee lint-assets.log;
           if [ "${PIPESTATUS[0]}" -ne 0 ]; then
             # Save multiline output
@@ -116,6 +121,8 @@ jobs:
       - name: Report code formatting errors
         if: ( steps.syntax_check_py.outputs.errors || steps.syntax_check_cpp.outputs.errors ) && github.event.pull_request
         run: |
+          set -e
+          sudo -i
           echo "Code formatting errors found";
           echo "Please run './fbt format' or './fbt format_py' to fix them";
           exit 1;

.github/workflows/merge_report.yml

@@ -12,11 +12,9 @@ permissions: write-all
 jobs:
   merge_report:
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     steps:
       - name: 'Wipe workspace'
-        run: find ./ -mount -maxdepth 1 -exec rm -rf {} \;
+        run: sudo find ./ -mount -maxdepth 1 -exec rm -rf {} \;
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -26,6 +24,8 @@ jobs:
 
       - name: 'Get commit details'
         run: |
+          set -e
+          sudo -i
           if [[ ${{ github.event_name }} == 'pull_request' ]]; then
             TYPE="pull"
           elif [[ "${{ github.ref }}" == "refs/tags/"* ]]; then
@@ -37,6 +37,8 @@ jobs:
 
       - name: 'Check ticket and report'
         run: |
+          set -e
+          sudo -i
           source scripts/toolchain/fbtenv.sh
           python3 -m pip install slack_sdk
           python3 scripts/merge_report_qa.py \

.github/workflows/pvs_studio.yml

@@ -17,11 +17,9 @@ jobs:
   analyse_c_cpp:
     if: ${{ !github.event.pull_request.head.repo.fork }}
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     steps:
       - name: 'Wipe workspace'
-        run: find ./ -mount -maxdepth 1 -exec rm -rf {} \;
+        run: sudo find ./ -mount -maxdepth 1 -exec rm -rf {} \;
 
       - name: 'Checkout code'
         uses: actions/checkout@v4
@@ -32,6 +30,8 @@ jobs:
       - name: 'Get commit details'
         id: names
         run: |
+          set -e
+          sudo -i
           if [[ ${{ github.event_name }} == 'pull_request' ]]; then
             TYPE="pull"
           elif [[ "${{ github.ref }}" == "refs/tags/"* ]]; then
@@ -43,11 +43,15 @@ jobs:
 
       - name: 'Supply PVS credentials'
         run: |
+          set -e
+          sudo -i
           pvs-studio-analyzer credentials ${{ secrets.PVS_STUDIO_CREDENTIALS }}
 
       - name: 'Convert PVS-Studio output to html and detect warnings'
         id: pvs-warn
         run: |
+          set -e
+          sudo -i
           WARNINGS=0
           ./fbt COMPACT=1 PVSNOBROWSER=1 firmware_pvs || WARNINGS=1
           echo "warnings=${WARNINGS}" >> $GITHUB_OUTPUT
@@ -89,6 +93,10 @@ jobs:
       - name: 'Raise exception'
         if: ${{ steps.pvs-warn.outputs.warnings != 0 }}
         run: |
+        
+          set -e
+          sudo -i
+          
           echo "Please fix all PVS warnings before merge"
           echo "Report: ${{ steps.pvs-warn.outputs.report-url }}"
           echo "[PVS report](${{ steps.pvs-warn.outputs.report-url }})" >> $GITHUB_STEP_SUMMARY

.github/workflows/reindex.yml

@@ -9,20 +9,23 @@ jobs:
   reindex:
     name: 'Post-release hooks'
     runs-on: ubuntu-latest
-    container:
-      options: --user root
     steps:
       - name: 'Checkout code'
         uses: actions/checkout@v4
 
       - name: 'Trigger reindex'
         run: |
+        
+          set -e
+          sudo -i
           curl --fail -L -H "Token: ${{ secrets.INDEXER_TOKEN }}" \
               "${{ secrets.INDEXER_URL }}"/firmware/reindex;
 
       - name: 'Send release notification'
         if: ${{ github.event.action == 'released' }}
         run: |
+          set -e
+          sudo -i
           echo '${{ secrets.FIREBASE_TOKEN }}' > firebase-token.json;
           python3 -m pip install firebase-admin==6.4.0;
           python3 scripts/send_firebase_notification.py \
@@ -32,4 +35,6 @@ jobs:
       - name: 'Remove firebase token'
         if: always()
         run: |
+          set -e
+          sudo -i
           rm -rf firebase-token.json;