Add notice to museum file, stop items being in special category if already somewhere else (#1461)

Author: CalMWolfs

.github/scripts/updateMuseum.py

@@ -124,11 +124,12 @@ def findAppropriateId(setName):
     for item in items:
         itemId = item['id']
 
-        if 'museum' in item:
-            special.add(itemId)
-
         if 'museum_data' in item:
             processMuseumData(itemId, item['museum_data'])
+            continue
+
+        if 'museum' in item:
+            special.add(itemId)
 
     for armorSet in armorSets:
         findAppropriateId(armorSet)
@@ -140,6 +141,7 @@ def findAppropriateId(setName):
     maxValues['total'] = maxValues['weapons'] + maxValues['armor'] + maxValues['rarities']
 
     outputJson = {
+        "notice": "This file is automatically generated and should not be modified manually. Please edit the `updatedMuseum.py` file instead.",
         "weapons": sorted(list(weapons), key=lambda item: (itemToXp.get(item, 0), item)),
         "armor": sorted(list(armor), key=lambda item: (itemToXp.get(item, 0), item)),
         "rarities": sorted(list(rarities), key=lambda item: (itemToXp.get(item, 0), item)),