Make NEUItems reload atomic

kevinthegreat1 · lineargraph · commit c125ef8a1dbc · 2024-05-02T19:07:47.000+02:00
diff --git a/src/main/java/io/github/moulberry/repo/NEUItems.java b/src/main/java/io/github/moulberry/repo/NEUItems.java
@@ -18,7 +18,7 @@ public class NEUItems implements IReloadable {
 
     @Override
     public void reload(NEURepository repository) throws NEURepositoryException {
-        items = new HashMap<>();
+        Map<String, NEUItem> items = new HashMap<>();
         try (Stream<NEURepoFile> itemSources = repository.tree("items")
                 .filter(NEURepoFile::isFile)
                 .filter(it -> it.getFsPath().getFileName().toString().toLowerCase(Locale.ROOT).endsWith(".json"))) {
@@ -27,6 +27,7 @@ public void reload(NEURepository repository) throws NEURepositoryException {
                 items.put(item.getSkyblockItemId(), item);
             }
         }
+        this.items = items;
     }
 
     @Nullable

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public class NEUItems implements IReloadable {`
`18`	`18`
`19`	`19`	`@Override`
`20`	`20`	`public void reload(NEURepository repository) throws NEURepositoryException {`
`21`		`- items = new HashMap<>();`
	`21`	`+ Map<String, NEUItem> items = new HashMap<>();`
`22`	`22`	`try (Stream<NEURepoFile> itemSources = repository.tree("items")`
`23`	`23`	`.filter(NEURepoFile::isFile)`
`24`	`24`	`.filter(it -> it.getFsPath().getFileName().toString().toLowerCase(Locale.ROOT).endsWith(".json"))) {`
`@@ -27,6 +27,7 @@ public void reload(NEURepository repository) throws NEURepositoryException {`
`27`	`27`	`items.put(item.getSkyblockItemId(), item);`
`28`	`28`	`}`
`29`	`29`	`}`
	`30`	`+ this.items = items;`
`30`	`31`	`}`
`31`	`32`
`32`	`33`	`@Nullable`