Skip to content

Commit ea6c85c

Browse files
committed
add lint rules
1 parent 600c883 commit ea6c85c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+156
-139
lines changed

docs/.markdownlint.json

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
{
2+
"first-line-h1": false,
3+
"no-bare-urls": false,
4+
"no-inline-html": false,
5+
"code-block-style": {
6+
"style": "fenced"
7+
},
8+
"code-fence-style": {
9+
"style": "backtick"
10+
},
11+
"emphasis-style": {
12+
"style": "asterisk"
13+
},
14+
"extended-ascii": {
15+
"ascii-only": true
16+
},
17+
"fenced-code-language": {
18+
"language_only": true
19+
},
20+
"heading-style": {
21+
"style": "atx"
22+
},
23+
"hr-style": {
24+
"style": "---"
25+
},
26+
"line-length": {
27+
"strict": false,
28+
"code_blocks": false,
29+
"line_length": 410
30+
},
31+
"link-image-style": {
32+
"collapsed": false,
33+
"shortcut": false,
34+
"url_inline": false
35+
},
36+
"no-duplicate-heading": {
37+
"siblings_only": true
38+
},
39+
"ol-prefix": {
40+
"style": "one_or_ordered"
41+
},
42+
"proper-names": {
43+
"code_blocks": false,
44+
"names": [
45+
"Cake.Markdownlint",
46+
"CommonMark",
47+
"JavaScript",
48+
"Markdown",
49+
"markdown-it",
50+
"markdownlint",
51+
"Node.js"
52+
]
53+
},
54+
"reference-links-images": {
55+
"shortcut_syntax": true
56+
},
57+
"strong-style": {
58+
"style": "asterisk"
59+
},
60+
"ul-style": {
61+
"style": "dash"
62+
}
63+
}

docs/index.md

Lines changed: 33 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11

2-
Client:<br>
2+
#### Client
3+
34
![GitHub commit activity](https://img.shields.io/github/commit-activity/t/notifiarr/notifiarr?label=Commits&style=for-the-badge&color=526cfe)
45
![GitHub commit activity (branch)](https://img.shields.io/github/commit-activity/t/notifiarr/notifiarr/main?label=Stable%20(:latest)&style=for-the-badge&color=526cfe)
56
![GitHub commit activity (branch)](https://img.shields.io/github/commit-activity/t/notifiarr/notifiarr/unstable?label=Unstable%20(:unstable)&style=for-the-badge&color=526cfe)
@@ -11,18 +12,24 @@ Client:<br>
1112
![GitHub issues](https://img.shields.io/github/issues-pr-closed/Notifiarr/notifiarr?&logo=github&style=for-the-badge&color=526cfe)
1213
[![GitHub license](https://img.shields.io/github/license/Notifiarr/notifiarr?&logo=github&style=for-the-badge&color=526cfe)](https://github.com/Notifiarr/notifiarr/blob/main/LICENSE)
1314

14-
Site:<br>
15+
#### Site
16+
1517
![GitHub issues](https://img.shields.io/github/issues/Notifiarr/website?&logo=github&style=for-the-badge&color=526cfe)
1618
![GitHub issues](https://img.shields.io/github/issues-closed/Notifiarr/website?&logo=github&style=for-the-badge&color=526cfe)
1719

18-
Support:<br>
20+
#### Support
21+
1922
[![Discord](https://img.shields.io/discord/764440599066574859?label=Discord&style=for-the-badge&color=7F00FF)](https://notifiarr.com/discord)
2023

2124
![Logo](assets/logo.png)
2225

2326
# Notifiarr
2427

25-
You just found one of the coolest tools on the Internet for a homelab enthusiast. We do notifications. We do them right. We've been doing then for years and we'll keep doing them for years to come. Notifiarr provides native custom integrations with dozens, maybe hundreds of applications and websites. That means these applications or websites can send data to Notifiarr, and we'll format a message according to your configuration then send it to your chat server.
28+
You just found one of the coolest tools on the Internet for a homelab enthusiast.
29+
We do notifications. We do them right. We've been doing then for years and we'll keep doing them for years to come.
30+
Notifiarr provides native custom integrations with dozens, maybe hundreds of applications and websites.
31+
That means these applications or websites can send data to Notifiarr, and we'll format a message according to
32+
your configuration then send it to your chat server.
2633

2734
What sets us apart from direct integrations are the options we provide to format your messages. We also maintain and provide, for your conveince, a local agent you may run on any server or network you wish to monitor. The agent is fully configurable to collect network and system data so you can get health reports from your servers.
2835

@@ -37,28 +44,33 @@ we have a big community, if you need assistance you can ask there by opening a s
3744

3845
## From the author
3946

40-
I built Notifiarr in late 2019 for [myself](https://github.com/austinwbest), and it was used by only myself until August of 2020 when I opened it up for others to use. My goal has always been to have a single location for common notification needs, so I am not jumping around 20 apps to do things. [Captain](https://github.com/davidnewhall) joined the crew in December 2020, and the two of us run the servers and write the code for the client and website.
47+
I built Notifiarr in late 2019 for [myself](https://github.com/austinwbest), and it was used by only myself until
48+
August of 2020 when I opened it up for others to use. My goal has always been to have a single location for common
49+
notification needs, so I am not jumping around 20 apps to do things. [Captain](https://github.com/davidnewhall)
50+
joined the crew in December 2020, and the two of us run the servers and write the code for the client and website.
4151

4252
## Integrations
4353

4454
!!! note
45-
4655
[How to setup integrations](pages/integrations/basicUsage.md#how-to-setup-integrations)
4756

4857
## Additional Features
4958

50-
* Fully configurable on what triggers to get notifications for. Each integration and many triggers in them can go to their own channels.
51-
* Layout configuration for some notifications
52-
* Content configuration for most notifications (color, content, etc)
53-
* Media Requests Bot - Discord Bot for all 4 \*Arr apps with:
54-
* Media Requests
55-
* User Permissions
56-
* Approvals
57-
* Sonarr Profiles
58-
* Default Options
59-
* Series Following
60-
* Discover features
61-
* Multi-Instance Support
62-
* Minimal Access - No \*Arr apikeys or anything of the sort is used or saved on the site. All requests to the client are verified with your Notifiarr apikey and thrown out if they don't match up
63-
* TRaSH Custom Format Sync [*\*Patron Feature\**](pages/faq/faq.md#q-what-are-the-user-level-differences) - Automated continuous add/sync for the custom formats TRaSH has made to use with Radarr
64-
* Radarr Collections - A fully automated way to monitor all your Radarr collections with auto add new items to your library as they are put into the collection on TMDb for any monitored collections, etc.
59+
- Fully configurable on what triggers to get notifications for. Each integration and many triggers in them can go to their own channels.
60+
- Layout configuration for some notifications
61+
- Content configuration for most notifications (color, content, etc)
62+
- Media Requests Bot - Discord Bot for all 4 \*Arr apps with:
63+
- Media Requests
64+
- User Permissions
65+
- Approvals
66+
- Sonarr Profiles
67+
- Default Options
68+
- Series Following
69+
- Discover features
70+
- Multi-Instance Support
71+
- Minimal Access - No \*Arr apikeys or anything of the sort is used or saved on the site.
72+
All requests to the client are verified with your Notifiarr apikey and thrown out if they don't match up
73+
- TRaSH Custom Format Sync [*\*Patron Feature\**](pages/faq/faq.md#q-what-are-the-user-level-differences) -
74+
Automated continuous add/sync for the custom formats TRaSH has made to use with Radarr
75+
- Radarr Collections - A fully automated way to monitor all your Radarr collections with auto add new
76+
items to your library as they are put into the collection on TMDb for any monitored collections, etc.

docs/pages/client/configuration.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ When a new docker image is deployed with an empty /config folder mounted, the ap
2121
- You can use env variables, the conf file, or the UI
2222
- Must provide the "All" API key from your [Profile page on notifiarr.com](https://notifiarr.com/user.php?page=profile)
2323
- **The Notifiarr application uses the API key for bi-directional authorization between the Site and the Client.**
24-
24+
2525
!!! danger "Unraid Users"
2626
You must configure the Notifiarr API Key in the Unraid Template/ Container Settings. If you wish to use Plex then you'll also need to set the Plex Token and Plex URL in the template as well. The other integrations can be defined in notifiarr.conf
2727

@@ -131,7 +131,7 @@ Recommend not messing with these unless instructed to do so.
131131
| max_body | `DN_MAX_BODY` | Unlimited, `0` / Maximum debug-log body size (integer) for payloads to and from notifiarr.com |
132132
| | `TMPDIR` | `%TMP%` on Windows. Varies depending on system; must be writable if using Backup Corruption Check |
133133

134-
_Note: You may disable the GUI (menu item) on Windows by setting the env variable `USEGUI` to `false`._
134+
*Note: You may disable the GUI (menu item) on Windows by setting the env variable `USEGUI` to `false`.*
135135

136136
#### MySQL Snapshots
137137

docs/pages/client/gui.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ notifiarr.exe --reset
6161
docker exec Notifiarr /notifiarr --reset
6262
docker kill --signal=HUP Notifiarr
6363
```
64-
64+
6565
```bash
6666
# Example output with new password:
6767
[INFO] 2023/09/08 09:32:11 New 'admin' user password: four38=Draw
@@ -135,7 +135,12 @@ The General section is more catered to the ingress and egress options/functional
135135
!!! warning
136136
This API must be an All key!
137137

138-
1. `Extra Keys` - This application uses the Notifiarr.com API key (set above) for incoming authentication. It's not safe to give that key to any other website, person, or third party service. This is because that key is also used for authentication to the Notifiarr.com API. If you want third parties to authenticate to this application's API, you should create custom keys for each integration. As of March 8, 2022, there are no existing integrations, so this is for future use. You can use this section to add extra API keys. Whatever you want. Separate them with newlines or spaces.
138+
1. `Extra Keys` - This application uses the Notifiarr.com API key (set above) for incoming authentication.
139+
It's not safe to give that key to any other website, person, or third party service.
140+
This is because that key is also used for authentication to the Notifiarr.com API.
141+
If you want third parties to authenticate to this application's API, you should create custom keys for each integration.
142+
As of March 8, 2022, there are no existing integrations, so this is for future use. You can use this section to add
143+
extra API keys. Whatever you want. Separate them with newlines or spaces.
139144
1. `Bind Address` - This is the IP and port the app will listen on. 0.0.0.0 means all IPs, and you should use that in almost all cases! Change the port if the default 5454 does not work for you.
140145
1. `URL Base` - This application serves HTTP on / by default. You can change that by typing in something else here.
141146
1. `Upstreams` - If Notifiarr client is behind a reverse proxy (swag, nginx, etc), then you should add that proxy IP here. You can also specify full networks. This controls which IP is written to the web server log file (requestor or x-forwarded-for header). It also allows the x-webauth-user header for proxy authentication. Separate with spaces or new lines.

docs/pages/client/install.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ WantedBy=default.target
267267
1. Type `systemctl --user enable notifiarr`
268268
1. Type `systemctl --user start notifiarr`
269269
1. Type `systemctl --user status notifiarr` to check if there are any errors.
270-
1. On your browser go to http://[ultraseedbox url]:5454
270+
1. On your browser go to `http://your-ultraseedbox-url:5454`
271271
1. Log into your Notifarr client and change the base url to /notifiarr and save changes
272272
1. Go back to your ssh console
273273
1. Type `cd /home/$USER/.apps/nginx/proxy.d`
@@ -296,4 +296,4 @@ deny all; # remove this line if you really want to expose the API.
296296
```
297297

298298
1. Type `systemctl --user restart nginx`
299-
1. Now you should be able to browse to https://[ultraseedbox url]/notifiarr
299+
1. Now you should be able to browse to `https://your-ultraseedbox-url/notifiarr`

docs/pages/client/reverseProxy.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ server {
108108
set $upstream_app notifiarr;
109109
set $upstream_port 5454;
110110
set $upstream_proto http;
111-
111+
112112
location / {
113113
# enable the next two lines for http auth
114114
#auth_basic "Restricted";
@@ -117,7 +117,7 @@ server {
117117
# enable the next two lines for organizr auth
118118
#include /config/nginx/orgauth.conf;
119119
#auth_request /organizr-auth/0;
120-
120+
121121
# enable the next two lines for ldap auth
122122
#auth_request /auth;
123123
#error_page 401 =200 /ldaplogin;
@@ -129,7 +129,7 @@ server {
129129
proxy_set_header X-WebAuth-User $auth_user;
130130
proxy_pass $upstream_proto://$upstream_app:$upstream_port;
131131
}
132-
132+
133133
# API path must not be protected by auth, authelia, ldap, etc.
134134
location ~ (/notifiarr)?/api {
135135
deny all; # remove this line if you really want to expose the API.

docs/pages/client/setup.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ There are non-integration related settings and triggers are configured on the No
2121
1. Open the conf file, set your Notifiarr API Key and restart the client.
2222

2323
```conf
24-
## This API key must be copied
24+
## This API key must be copied
2525
from your notifiarr.com account.
2626
api_key = "api-key-from-notifiarr.com"
2727
```
@@ -47,7 +47,7 @@ When a new docker image is deployed and an empty /config folder is mounted the a
4747
- Must provide the "All" API key from your [Profile page on notifiarr.com](https://notifiarr.com/user.php?page=profile)
4848
- **The Notifiarr application uses the API key for bi-directional authorization between the Site and the Client.**
4949
50-
!!! warning
50+
!!! warning
5151
**Unraid Users**
5252
You must configure the Notifiarr API Key in the Unraid Template/ Container Settings. If you wish to use Plex then you'll also need to set the Plex Token and Plex URL in the template as well. The other integrations can be defined in notifiarr.conf
5353

docs/pages/discordbot/permissions.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
# Discord Permissions
22

3-
Getting permissions correct for your setup can be a struggle depending on how you have your Discord server setup. If you want to run a simple test to see if you have permission issues, set the Notifiarr role to have `Admin` permission and see whether it solves your issue. If everything works, this means you simply need to adjust permissions for the the Notifiarr role and you don't need to give it full admin permissions
3+
Getting permissions correct for your setup can be a struggle depending on how you have your Discord server setup.
4+
If you want to run a simple test to see if you have permission issues, set the Notifiarr role to have `Admin`
5+
permission and see whether it solves your issue. If everything works, this means you simply need to adjust permissions
6+
for the the Notifiarr role and you don't need to give it full admin permissions.
47

58
---
69

7-
To update the integration's permissions, click on your server name at the top and pick `Server Settings > Roles`. Click on the `Notifiarr` role and then pick `Permissions`.
10+
To update the integration's permissions, click on your server name at the top and pick `Server Settings > Roles`.
11+
Click on the `Notifiarr` role and then pick `Permissions`.
812

913
## **Required Permissions**
1014

docs/pages/faq/faq.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,10 @@ If session info is missing from notifications or the sessions notification is no
8989
- Make sure you have selected the **Activity** checkbox in the Plex section of the [Client Settings](../../pages/website/clientConfig.md)
9090
- Try to increase the **Activity Delay** in the Plex section of the [Client Settings](https://notifiarr.wiki/en/Website/ClientConfiguration) as this will give Plex more time to get the session available in the endpoint
9191
- Note 1: The sessions notifications will only send when there is at least one item being played or paused
92-
- Note 2: It doesn't matter what Tautulli shows or the Plex Dashboard shows, they both use the same sessions endpoint. If you where to look at them at the same time as the notification is sent (when it doesn't work) they would also not show the session yet. How long it takes Plex & your (possibly low powered or over worked) server to make the session available in the endpoint is out of our control which is why we added the delay option
92+
- Note 2: It doesn't matter what Tautulli shows or the Plex Dashboard shows, they both use the same sessions endpoint.
93+
If you where to look at them at the same time as the notification is sent (when it doesn't work) they would also not
94+
show the session yet. How long it takes Plex & your (possibly low powered or over worked) server to make the session
95+
available in the endpoint is out of our control which is why we added the delay option
9396

9497
## Q. What are the user level differences
9598

docs/pages/integrations/authentik.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# Authentik
22

33
!!! info
4-
5-
This integration is for setting up discord notifications for Authentik
4+
This integration is for setting up discord notifications for Authentik
65

76
---
87

@@ -21,9 +20,8 @@
2120
## Instructions
2221

2322
!!! info "Authentik Notifications"
24-
2523
Detailed wiki for [Authentik Notifications](https://docs.goauthentik.io/docs/sys-mgmt/events/notifications)
26-
24+
2725
![instructions.png](../../assets/screenshots/integrations/authentik/instructions.png)
2826

2927
1. Instructions on how too set webhook notifications in Authentik
@@ -40,7 +38,6 @@ Click the cog icon too open the configuration settings
4038
![configuration.png](../../assets/screenshots/integrations/authentik/configuration.png)
4139

4240
1. enabling each `trigger field`, and using the `customize toggle` too drop down the `notification fields` for each trigger
43-
4441
2. choosing the color of the notification
4542

4643
---

0 commit comments

Comments
 (0)