fix edge cases

Author: pierre-b

liquid/strftime.go

@@ -15,35 +15,35 @@ func strftime(t *time.Time, format string) string {
 	// Map of strftime codes to Go format codes
 	// Go uses the reference time: Mon Jan 2 15:04:05 MST 2006
 	replacements := map[string]string{
-		"%a": "Mon",              // Abbreviated weekday name
-		"%A": "Monday",           // Full weekday name
-		"%b": "Jan",              // Abbreviated month name
-		"%B": "January",          // Full month name
+		"%a": "Mon",                     // Abbreviated weekday name
+		"%A": "Monday",                  // Full weekday name
+		"%b": "Jan",                     // Abbreviated month name
+		"%B": "January",                 // Full month name
 		"%c": "Mon Jan 2 15:04:05 2006", // Preferred date and time
-		"%d": "02",               // Day of the month (01-31)
-		"%e": "_2",               // Day of the month, space-padded ( 1-31)
-		"%H": "15",               // Hour (00-23)
-		"%I": "03",               // Hour (01-12)
-		"%j": "002",              // Day of the year (001-366)
-		"%m": "01",               // Month (01-12)
-		"%M": "04",               // Minute (00-59)
-		"%p": "PM",               // AM or PM
-		"%P": "pm",               // am or pm (lowercase)
-		"%S": "05",               // Second (00-60)
-		"%U": "",                 // Week number of year (Sunday first)
-		"%w": "",                 // Day of the week (0-6, Sunday is 0)
-		"%W": "",                 // Week number of year (Monday first)
-		"%x": "01/02/06",         // Preferred date representation
-		"%X": "15:04:05",         // Preferred time representation
-		"%y": "06",               // Year without century (00-99)
-		"%Y": "2006",             // Year with century
-		"%z": "-0700",            // Numeric timezone offset (+0000)
-		"%Z": "MST",              // Time zone name
-		"%%": "%",                // Literal percent sign
+		"%d": "02",                      // Day of the month (01-31)
+		"%e": "_2",                      // Day of the month, space-padded ( 1-31)
+		"%H": "15",                      // Hour (00-23)
+		"%I": "03",                      // Hour (01-12)
+		"%j": "002",                     // Day of the year (001-366)
+		"%m": "01",                      // Month (01-12)
+		"%M": "04",                      // Minute (00-59)
+		"%p": "PM",                      // AM or PM
+		"%P": "pm",                      // am or pm (lowercase)
+		"%S": "05",                      // Second (00-60)
+		"%U": "",                        // Week number of year (Sunday first)
+		"%w": "",                        // Day of the week (0-6, Sunday is 0)
+		"%W": "",                        // Week number of year (Monday first)
+		"%x": "01/02/06",                // Preferred date representation
+		"%X": "15:04:05",                // Preferred time representation
+		"%y": "06",                      // Year without century (00-99)
+		"%Y": "2006",                    // Year with century
+		"%z": "-0700",                   // Numeric timezone offset (+0000)
+		"%Z": "MST",                     // Time zone name
+		"%%": "%",                       // Literal percent sign
 	}
 
 	result := format
-	
+
 	// Replace all strftime codes with Go format codes
 	for code, goFormat := range replacements {
 		if goFormat == "" {
@@ -72,4 +72,3 @@ func strftime(t *time.Time, format string) string {
 
 	return t.Format(result)
 }
-

liquid/tags/case.go

@@ -69,7 +69,7 @@ func NewCaseTag(tagName, markup string, parseContext liquid.ParseContextInterfac
 func (c *CaseTag) parseMarkup(markup string, parseContext liquid.ParseContextInterface) error {
 	// Trim whitespace to match Ruby behavior
 	markup = strings.TrimSpace(markup)
-	
+
 	matches := caseSyntax.FindStringSubmatch(markup)
 	if len(matches) == 0 {
 		return liquid.NewSyntaxError("invalid case tag syntax")

liquid/tags/case_test.go

@@ -509,7 +509,7 @@ func TestCaseTagRenderToOutputBufferElseBlock(t *testing.T) {
 func TestCaseTagWithComma(t *testing.T) {
 	env := liquid.NewEnvironment()
 	RegisterStandardTags(env)
-	
+
 	template := `{%- case 1 -%}
 {%- when 2, 1 -%}
 one
@@ -533,7 +533,7 @@ two
 func TestCaseTagWithOr(t *testing.T) {
 	env := liquid.NewEnvironment()
 	RegisterStandardTags(env)
-	
+
 	template := `{%- case 1 -%}
 {%- when 2 or 1 -%}
 one
@@ -557,7 +557,7 @@ two
 func TestCaseTagNodelistIntegration(t *testing.T) {
 	env := liquid.NewEnvironment()
 	RegisterStandardTags(env)
-	
+
 	template := `{% case var %}{% when true %}WHEN{% else %}ELSE{% endcase %}`
 	tmpl, err := liquid.ParseTemplate(template, &liquid.TemplateOptions{Environment: env})
 	if err != nil {
@@ -581,8 +581,8 @@ func TestCaseTagNodelistIntegration(t *testing.T) {
 func TestCaseTagIntegrationMultipleConditions(t *testing.T) {
 	env := liquid.NewEnvironment()
 	RegisterStandardTags(env)
-	
-	tests := []struct{
+
+	tests := []struct {
 		name     string
 		template string
 		assigns  map[string]interface{}

liquid/tags/render.go

@@ -117,7 +117,7 @@ func (r *RenderTag) RenderToOutputBuffer(context liquid.TagContext, output *stri
 				contextVariableName = name.Name()
 			}
 		}
-		
+
 		// Parse the body as a template
 		parsedTemplate, err := liquid.ParseTemplate(body, &liquid.TemplateOptions{
 			Environment: r.ParseContext().Environment(),

liquid/tags/snippet.go

@@ -1,6 +1,8 @@
 package tags
 
 import (
+	"strings"
+
 	"github.com/Notifuse/liquidgo/liquid"
 )
 
@@ -17,6 +19,7 @@ func NewSnippetTag(tagName, markup string, parseContext liquid.ParseContextInter
 	// Parse markup - should be just a variable name
 	// Ruby: p.consume(:id)
 	// For now, use simple parsing - expect just an identifier
+	markup = strings.TrimSpace(markup)
 	if markup == "" {
 		return nil, liquid.NewSyntaxError("snippet tag requires a variable name")
 	}
@@ -51,17 +54,11 @@ func (s *SnippetTag) RenderToOutputBuffer(context liquid.TagContext, output *str
 	// Get template name
 	templateName := ctx.TemplateName()
 
-	// Create snippet drop
+	// Create snippet drop (body is the rendered content, not the BlockBody)
 	snippetDrop := liquid.NewSnippetDrop(bodyOutput, s.to, templateName)
 
 	// Assign to variable in last scope (matching Ruby's context.scopes.last[@to])
-	// Use direct scope access like the test does
-	scopes := ctx.Scopes()
-	if len(scopes) == 0 {
-		scopes = []map[string]interface{}{make(map[string]interface{})}
-	}
-	// Set in the last scope
-	scopes[len(scopes)-1][s.to] = snippetDrop
+	ctx.SetLast(s.to, snippetDrop)
 
 	// Increment assign score in resource limits
 	rl := context.ResourceLimits()