fix: collection block ids

Author: transitive-bullshit

packages/notion-client/src/notion-api.ts

@@ -121,7 +121,7 @@ export class NotionAPI {
           getBlockCollectionId(block)
 
         if (collectionId) {
-          return block.view_ids.map((collectionViewId) => ({
+          return block.view_ids?.map((collectionViewId) => ({
             collectionId,
             collectionViewId
           }))

packages/react-notion-x/src/third-party/collection-view-board.tsx

@@ -140,7 +140,7 @@ function Board({ collectionView, collectionData, collection, padding }) {
 
             return (
               <div className='notion-board-group' key={index}>
-                {group.blockIds.map((blockId: string) => {
+                {group.blockIds?.map((blockId: string) => {
                   const block = recordMap.block[blockId]?.value as PageBlock
                   if (!block) return null
 

packages/react-notion-x/src/third-party/collection-view-gallery.tsx

@@ -8,6 +8,8 @@ import { useNotionContext } from '../context'
 import { CollectionCard } from './collection-card'
 import { CollectionGroup } from './collection-group'
 
+const defaultBlockIds = []
+
 export const CollectionViewGallery: React.FC<CollectionViewProps> = ({
   collection,
   collectionView,
@@ -32,8 +34,9 @@ export const CollectionViewGallery: React.FC<CollectionViewProps> = ({
   }
 
   const blockIds =
-    collectionData['collection_group_results']?.blockIds ??
-    collectionData.blockIds
+    (collectionData['collection_group_results']?.blockIds ??
+      collectionData.blockIds) ||
+    defaultBlockIds
 
   return (
     <Gallery
@@ -61,7 +64,7 @@ function Gallery({ blockIds, collectionView, collection }) {
             `notion-gallery-grid-size-${gallery_cover_size}`
           )}
         >
-          {blockIds.map((blockId) => {
+          {blockIds?.map((blockId) => {
             const block = recordMap.block[blockId]?.value as PageBlock
             if (!block) return null
 

packages/react-notion-x/src/third-party/collection-view-list.tsx

@@ -7,6 +7,8 @@ import { useNotionContext } from '../context'
 import { CollectionGroup } from './collection-group'
 import { getCollectionGroups } from './collection-utils'
 
+const defaultBlockIds = []
+
 export const CollectionViewList: React.FC<CollectionViewProps> = ({
   collection,
   collectionView,
@@ -27,8 +29,9 @@ export const CollectionViewList: React.FC<CollectionViewProps> = ({
   }
 
   const blockIds =
-    collectionData['collection_group_results']?.blockIds ??
-    collectionData.blockIds
+    (collectionData['collection_group_results']?.blockIds ??
+      collectionData.blockIds) ||
+    defaultBlockIds
 
   return (
     <List
@@ -46,7 +49,7 @@ function List({ blockIds, collection, collectionView }) {
     <div className='notion-list-collection'>
       <div className='notion-list-view'>
         <div className='notion-list-body'>
-          {blockIds.map((blockId) => {
+          {blockIds?.map((blockId) => {
             const block = recordMap.block[blockId]?.value as PageBlock
             if (!block) return null
 

packages/react-notion-x/src/third-party/collection-view-table.tsx

@@ -8,6 +8,8 @@ import { getCollectionGroups } from './collection-utils'
 import { Property } from './property'
 import { useNotionContext } from '../context'
 
+const defaultBlockIds = []
+
 export const CollectionViewTable: React.FC<CollectionViewProps> = ({
   collection,
   collectionView,
@@ -44,8 +46,9 @@ export const CollectionViewTable: React.FC<CollectionViewProps> = ({
   }
 
   const blockIds =
-    collectionData['collection_group_results']?.blockIds ??
-    collectionData.blockIds
+    (collectionData['collection_group_results']?.blockIds ??
+      collectionData.blockIds) ||
+    defaultBlockIds
 
   return (
     <Table
@@ -58,7 +61,7 @@ export const CollectionViewTable: React.FC<CollectionViewProps> = ({
   )
 }
 
-function Table({ blockIds, collection, collectionView, width, padding }) {
+function Table({ blockIds = [], collection, collectionView, width, padding }) {
   const { recordMap, linkTableTitleProperties } = useNotionContext()
 
   const tableStyle = React.useMemo(
@@ -80,7 +83,7 @@ function Table({ blockIds, collection, collectionView, width, padding }) {
   let properties = []
 
   if (collectionView.format?.table_properties) {
-    properties = collectionView.format?.table_properties.filter(
+    properties = collectionView.format.table_properties.filter(
       (p) => p.visible && collection.schema[p.property]
     )
   } else {
@@ -131,7 +134,7 @@ function Table({ blockIds, collection, collectionView, width, padding }) {
             <div className='notion-table-header-placeholder'></div>
 
             <div className='notion-table-body'>
-              {blockIds.map((blockId) => (
+              {blockIds?.map((blockId) => (
                 <div className='notion-table-row' key={blockId}>
                   {properties.map((p) => {
                     const schema = collection.schema?.[p.property]