[clang] [NFC] Deduplicate the logic between StringMapEntry.first() and StringMapEntry.getKey() (llvm#113735)

bricknerb · NoumanAmir657 · commit e9dff1add37a · 2024-11-04T09:38:23.000+05:00
diff --git a/llvm/include/llvm/ADT/StringMapEntry.h b/llvm/include/llvm/ADT/StringMapEntry.h
@@ -116,9 +116,7 @@ class StringMapEntry final : public StringMapEntryStorage<ValueTy> {
     return reinterpret_cast<const char *>(this + 1);
   }
 
-  StringRef first() const {
-    return StringRef(getKeyData(), this->getKeyLength());
-  }
+  StringRef first() const { return getKey(); }
 
   /// Create a StringMapEntry for the specified key construct the value using
   /// \p InitiVals.

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,7 @@ class StringMapEntry final : public StringMapEntryStorage<ValueTy> {`
`116`	`116`	`return reinterpret_cast<const char *>(this + 1);`
`117`	`117`	`}`
`118`	`118`
`119`		`- StringRef first() const {`
`120`		`- return StringRef(getKeyData(), this->getKeyLength());`
`121`		`- }`
	`119`	`+ StringRef first() const { return getKey(); }`
`122`	`120`
`123`	`121`	`/// Create a StringMapEntry for the specified key construct the value using`
`124`	`122`	`/// \p InitiVals.`