Navigation not enabled error.

[chratcliff]

Hi. Loving Nova and finding it fairly easy to make things, but using the code is a bit sloppy on my end. I am trying to pull up a menu that appears when a player gains a level. Since the choices are random, I do not need the menu to stick around. I instantiate some menu prefab rows and place them on a block with auto layout. This works pretty well.

But sometimes after choosing an upgrade, applying it and removing the menu I get the error

InvalidOperationException: Navigation not initialized. Focus must be called at least once with the same InternalVar_1 prior to any calls to Move.
Nova.Navigation.InternalMethod_2823 (Nova.Navigation+InternalType_738 InternalParameter_2457) (at Assets/Nova/Scripts/Public/DataTypes/Navigation.cs:732)
Nova.Navigation.InternalMethod_2688 () (at Assets/Nova/Scripts/Public/DataTypes/Navigation.cs:446)
Nova.InternalNamespace_0.InternalNamespace_11.InternalType_429.InternalMethod_3607 () (at Assets/Nova/Scripts/Internal/InternalScript_114.cs:60)

Here is how I'm calling the menu to be created:

`public void GenerateUpgradeMenu()
{

    createdRows = new List<UIBlock2D>();    
    //Root.AddGestureHandler<Nova.Gesture.OnRelease, ItemVisuals>(DoThing);
    Root.AddGestureHandler<Gesture.OnClick, UpgradeButtonSettings>(HandleClickEvent);
    
    upgradeController = upgradeControllerBlock.GetComponent<UpgradeController>();
    upgradeListTemp = upgradeController.GetUpgradesList();
    upgradeList = new List<ItemUpgrade>();
    Debug.Log("Got upgrade list.");
    System.Random rnd = new System.Random();
    int randNum = rnd.Next(0, 100000000);
    Random.InitState(randNum);
    if (upgradeListTemp.Count > 0)
    {
        Time.timeScale = 0.0f;
        
        weaponUpgradeRowDestination.Visible = true;
        //weaponUpgradeRowDestination.transform.parent.eulerAngles = new Vector3(0, 0, 0);
        weaponUpgradeRowDestination.CalculateLayout();
        //listView.AddDataUnbinder<ItemUpgrade, UpgradeButtonSettings>(RemoveItem);
        listView.SetDataSource(upgradeList);
        buttonList = listView.gameObject.GetComponentsInChildren<ItemView>().ToList();
        
        //Navigation.Focus(buttonList[0].UIBlock);
        inputManager.startNavigationFrom = buttonList[0].UIBlock;
        
        Navigation.Focus(buttonList[0].UIBlock);
        Navigation.isEnabled = true;
        inputManager.NavigationEnabled = true;



    }`

And this is how it's removed:

`public void HandleClickEvent(Gesture.OnClick evt, UpgradeButtonSettings target)
{
target.upgradeStats.ApplyUpgrade();
List objbuttonList = listView.gameObject.GetComponentsInChildren().ToList();
foreach (ItemView button in objbuttonList)
{
if (button != null)
{
button.gameObject.SetActive(false);
DestroyImmediate(button.gameObject);
}
}
upgradeList.Clear();
listView.Refresh();
weaponUpgradeRowDestination.Visible = false;
if (playerStatistics.playerXP > playerStatistics.xpToLevelUp)
{
playerStatistics.LevelUp();
}
else {
Root.RemoveGestureHandler<Gesture.OnClick, UpgradeButtonSettings>(HandleClickEvent);
inputManager.NavigationEnabled = false;
Navigation.isEnabled = false;
Time.timeScale = 1f;

    }`

The only solution I found was to destroy the buttons. But after the menu closes, navigation is stuck and thinks it's still on. I believe this is my fault due to how I'm handling things. I had no luck searching for this error so am looking to see if I could get some guidance on properly telling navigation it's no longer needed, and cleanly remove the buttons.

I did manage to make the error go away with Navigation.isEnabled checks by modifying the Navigation class, but I'd rather do this the RIGHT way. You can see various other things I've tried like refreshing the list. I have Bind for the data... but haven't bothered with unbind. Anything I can do to say "thank you please stop now" until Navigation is needed again?

EDIT: I just remembered this started when I made my own custom input for gamepads. This returns true:

bool canNavigate = navigationEnabled && KeyboardPresent;
bool navigating = Navigation.TryGetFocusedUIBlock(NavigationID, out UIBlock focused);

Is there a way to tell the navigation system that no ui blocks are focused at the moment without breaking something? I believe this would be the best way to tell my gamepad navigation to return and prevent this bug.

[adgray1]

Thanks for the kind words!

That error message should say InvalidOperationException: Navigation not initialized. Focus must be called at least once with the same controlID prior to any calls to Move., so controlID being obfuscated in that message is a bug on our end that we'll need to fix. Thank you for bringing that to our attention!

As for why you're hitting that exception in the first place, one thing in particular stands out to me. In your GenerateUpgradeMenu() method, you're calling Navigation.Focus(buttonList[0].UIBlock) and you're setting inputManager.startNavigatingFrom to the same UIBlock. Because you're not passing in an explicit controlID to Navigation.Focus(), it's using the default controlID value of 0, but the InputManager script uses a different controlID for navigating, NavigationID. The navigation system supports having simultaneous navigators (e.g. for local multiplayer), so the same ID needs to be passed into all Navigation methods for a specific controller. E.g.

// You'll need to make NavigationID public to use this exact code
Navigation.Focus(buttonList[0].UIBlock, controlID: InputManager.NavigationID);

With that change, you shouldn't need to set inputManager.startNavigatingFrom when you enable navigation. So changing the navigating state in your code would looking something like:

// Enable navigation
inputManager.NavigationEnabled = true;
// You'll need to make NavigationID public to use this exact code
Navigation.Focus(buttonList[0].UIBlock, InputManager.NavigationID);

...

// Disable navigation
inputManager.NavigationEnabled = false;

Mind trying those changes and reporting back if you're still seeing issues?

As for how to tell the navigation system "nothing is focused" for a particular controlID, you can pass in null as the focused UIBlock to Navigation.Focus(). That will properly set the state on the navigation system. However, the InputManager sample, in its current form, will try to set focus while NavigationEnabled == true - so if you tried Navigation.Focus(null, NavigationID), and it didn't work, then likely it's because the InputManager reassigned focus after you.

[chratcliff]

Thanks for such fast help. I did get the error after the proposed changes. It really feels like I'm not telling the navigation system (internall) that it's done. The errors seem to be coming up on their own outside of my input script. I have DEFINITELY stopped my own calls to navigation with these changes, but this still happens:

InvalidOperationException: Navigation not initialized. Focus must be called at least once with the same InternalVar_1 prior to any calls to Move.
Nova.Navigation.InternalMethod_2823 (Nova.Navigation+InternalType_738 InternalParameter_2457) (at Assets/Nova/Scripts/Public/DataTypes/Navigation.cs:732)
Nova.Navigation.InternalMethod_2688 () (at Assets/Nova/Scripts/Public/DataTypes/Navigation.cs:446)
Nova.InternalNamespace_0.InternalNamespace_11.InternalType_429.InternalMethod_3607 () (at Assets/Nova/Scripts/Internal/InternalScript_114.cs:60)

[chratcliff]

OK, so yes. I just went through and made sure UpdateMouse and UpdateNavigation in my custom input manager (based on yours) is not running at all and returning if navigationEnabled = false. So in my script, it's fine. Is there a possiblity this is because of how I remove things ? I'm not sure. I can only say that is' pretty intermittent when it happens. I managed 11 level ups in a row before the problem cropped up in this last run. It actually still lets them menu come up and functions correctly, it's just logging thousands of errors as it will do this every frame.

[adgray1]

It does sound like something is stuck in a bad state, which may mean there's a bug on our end.

Does the issue still appear if you revise your "disable navigation" code to also set the focused UIBlock to null, e.g.:

// Disable navigation
inputManager.NavigationEnabled = false;
// You'll need to make NavigationID public to use this exact code
Navigation.Focus(null, InputManager.NavigationID);

Would you mind sharing your custom Input Manager script as well as your revised enable/disable navigation code? A video of your UI running when you hit this issue would also be helpful!

Edit:
Upon further consideration, what could be happening here is somewhere in your code there's a call to Navigation.Move before you disable navigation but on the same frame. The Move call will get queued and processed at the start of the following frame, as noted in our docs, but when that Move call is actually dequeued to be processed, there's no longer anything in focus, resulting in that exception you're hitting. The theory would also explain why you're only seeing the issue periodically - it's dependent on the timing of user input, so some sequence of events may happen in an inconsistent order. I'm transferring this discussed over to Feedback/Bugs, since so far this does appear to be an issue on our end.

[chratcliff]

Kind of wild that github won't let me attach a C# script lol.

Here is where I enable the navigation, set up the buttons etc. As I said before, I feel I am not properly removing them. I had no success with my unbind code and I'm really not sure how I Should be clearing this list properly once a player has chosen an upgrade and we need to destroy the generated buttons. I'm destroying and making efforts to make sure the data is cleared. This caused Nova to stop barking at me at least :)

`public void GenerateUpgradeMenu()
{

    createdRows = new List<UIBlock2D>();    
    //Root.AddGestureHandler<Nova.Gesture.OnRelease, ItemVisuals>(DoThing);
    Root.AddGestureHandler<Gesture.OnClick, UpgradeButtonSettings>(HandleClickEvent);
    
    upgradeController = upgradeControllerBlock.GetComponent<UpgradeController>();
    upgradeListTemp = upgradeController.GetUpgradesList();
    upgradeList = new List<ItemUpgrade>();
    Debug.Log("Got upgrade list.");
    System.Random rnd = new System.Random();
    int randNum = rnd.Next(0, 100000000);
    Random.InitState(randNum);
    if (upgradeListTemp.Count > 0)
    {
        Time.timeScale = 0.0f;
        if (upgradeListTemp.Count > 4)
        {
            for (int i = 0; i < upgradeListTemp.Count; i++)
            {
                ItemUpgrade temp = upgradeListTemp[i];
                int randomIndex = Random.Range(i, upgradeListTemp.Count);
                upgradeListTemp[i] = upgradeListTemp[randomIndex];
                upgradeListTemp[randomIndex] = temp;
            }
        }
        for (int i = 0; i < upgradeListTemp.Count && i <= 3; i++)
        {
            //weaponUpgradeRowDestination.CalculateLayout();
            //weaponUpgradeRowDestination.transform.eulerAngles = new Vector3(0, 0, 0);
            upgradeList.Add(upgradeListTemp[i]);
        }
        weaponUpgradeRowDestination.Visible = true;
        //weaponUpgradeRowDestination.transform.parent.eulerAngles = new Vector3(0, 0, 0);
        weaponUpgradeRowDestination.CalculateLayout();
        //listView.AddDataUnbinder<ItemUpgrade, UpgradeButtonSettings>(RemoveItem);
        listView.SetDataSource(upgradeList);
        buttonList = listView.gameObject.GetComponentsInChildren<ItemView>().ToList();

        //Navigation.Focus(buttonList[0].UIBlock);
        //inputManager.startNavigationFrom = buttonList[0].UIBlock;

        Navigation.Focus(buttonList[0].UIBlock, controlID: CustomInputManager.NavigationID);
        inputManager.NavigationEnabled = true;
        //Navigation.isEnabled = true; // this line was from me making this bug go away on a previous attempt.
    }
    else
    {
        if (Time.timeScale == 0f)
        {
            Time.timeScale = 1;
        }
    } 
    //Time.timeScale = 0;
}
private void BindItem(Data.OnBind<ItemUpgrade> evt, UpgradeButtonSettings target, int index) => target.Bind(evt.UserData);
private void UnbindItem(Data.OnUnbind<ItemUpgrade> evt, UpgradeButtonSettings target, int index) => target.Bind(evt.UserData);

public void RemoveItem()
{
    return;
}
public void HandleClickEvent(Gesture.OnClick evt, UpgradeButtonSettings target)
{
    Debug.Log("Applying Target upgrade: " + target + " " + playerStatistics.playerLevel);
    target.upgradeStats.ApplyUpgrade();
    
    List<ItemView> objbuttonList = listView.gameObject.GetComponentsInChildren<ItemView>().ToList();
    foreach (ItemView button in objbuttonList)
    {
        if (button != null)
        {
            button.gameObject.SetActive(false);
            DestroyImmediate(button.gameObject);
        }
    }
    upgradeList.Clear();
    
    listView.Refresh();
    weaponUpgradeRowDestination.Visible = false;
    if (playerStatistics.playerXP > playerStatistics.xpToLevelUp)
    {
        playerStatistics.LevelUp();
    }
    else {
        Root.RemoveGestureHandler<Gesture.OnClick, UpgradeButtonSettings>(HandleClickEvent);
        inputManager.NavigationEnabled = false;
        Navigation.isEnabled = false;
        Time.timeScale = 1f;
        Navigation.Focus(null, CustomInputManager.NavigationID);
        inputManager.NavigationEnabled = false;
    }
}`

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Here's the custom input manager. MIne is identical to yours except I've added the block I have pasted for gamepad navigation. There are minor discrepancies between navigationEnabled and NavigationEnabled from this morning. Yesterday it was "cleaner".

`using Nova;
using UnityEngine;
using UnityEngine.InputSystem;
using Unity;
using System.Collections;
using System.Collections.Generic;
using System.IO;
using Unity.VisualScripting;
using UnityEditor;
using UnityEngine;
using UnityEngine.InputSystem;
using UnityEngine.UIElements;
using System.Linq;

///

/// Simple input manager example for the UI Controls sample.
///

public class CustomInputManager : MonoBehaviour
{
///

/// Fired after mouse clicks. Can be used to determine when focus is lost.
///

public static System.Action<UIBlock> OnPostClick;
public float lastPress;
[SerializeField]
[Tooltip("The camera to use for mouse and touch input.")]
private Camera cam = null;

[Header("Mouse")]
[SerializeField]
[Tooltip("Handle mouse input events.")]
private bool mouseEnabled = true;
[SerializeField]
[Tooltip("Inverts the mouse wheel scroll direction.")]
private bool invertScrolling = true;

[Header("Touch")]
[SerializeField]
[Tooltip("Handle touch input events.")]
private bool touchEnabled = true;

[Header("Navigation")]
[SerializeField]
[Tooltip("Handle navigation input events.")]
public bool navigationEnabled = false;
[SerializeField]
[Tooltip("The starting point for navigation focus.")]
public UIBlock startNavigationFrom = null;
[Tooltip("The UIBlock to move around as navigation focus changes. Will be created if null.")]
public UIBlock NavigationIndicator = null;
[SerializeField]
[Tooltip("Move navigation focus at this rate (in seconds) while its corresponding key is pressed.")]
private float updateNavigationEveryXSeconds = 0.25f;

[Header("Navigation Keys")]
public KeyCode UpKey = KeyCode.UpArrow;
public KeyCode DownKey = KeyCode.DownArrow;
public KeyCode LeftKey = KeyCode.LeftArrow;
public KeyCode RightKey = KeyCode.RightArrow;
public KeyCode SelectKey = KeyCode.Return;
public KeyCode DeselectKey = KeyCode.Escape;
private InputAction doMoveNav;
private InputAction fire;
private PlayerInputSettings playerInputActions;
private InputAction.CallbackContext moveContext;
private MainPlayerInput playerInput;

/// <summary>
/// The camera to use for mouse and touch input.
/// </summary>
public Camera Cam
{
    get => cam;
    set
    {
        if (value == null)
        {
            Debug.LogError("Provided Camera is null. Please assign a valid Camera.", this);
            return;
        }

        cam = value;
    }
}

/// <summary>
/// Handle mouse input events.
/// </summary>
public bool MouseEnabled
{
    get => mouseEnabled;
    set => mouseEnabled = value;
}

/// <summary>
/// Handle touch input events.
/// </summary>
public bool TouchEnabled
{
    get => touchEnabled;
    set => touchEnabled = value;
}

/// <summary>
/// Handle navigation input events.
/// </summary>
public bool NavigationEnabled
{
    get => navigationEnabled;
    set => navigationEnabled = value;
}

private void OnEnable()
{
    playerInput = MainPlayerInput.instance;
    if (cam == null)
    {
        cam = Camera.current;
    }

    if (cam == null)
    {
        cam = Camera.main;
    }
    //playerInput = MainPlayerInput.instance;

#if !ENABLE_LEGACY_INPUT_MANAGER
EnhancedTouchSupport.Enable();
#endif

}
public void Start()
{
    playerInput = MainPlayerInput.instance;
    doMoveNav = playerInput.playerInputActions.PlayerActionMap.Move;
    doMoveNav.Enable();
    doMoveNav.started += HandleGamePadNavigation;
    Navigation.OnNavigationFocusChanged += HandleNavigationFocusChanged;
    lastPress = 0f;
    Debug.Log("Navigation enabled.");
}

private void OnDisable()
{
    Navigation.OnNavigationFocusChanged -= HandleNavigationFocusChanged;
    Debug.Log("Navigation disabled.");
}

private void Update()
{

        UpdateMouse();
        UpdateNavigation();
   
}

#region Mouse
private const uint MousePointerControlID = 1;
private const uint ScrollWheelControlID = 2;

#if ENABLE_LEGACY_INPUT_MANAGER
private bool MousePresent => Input.mousePresent;
private Vector2 MousePosition => Input.mousePosition;
private Vector2 MouseScrollDelta => Input.mouseScrollDelta;
private bool LeftMouseButtonValue => Input.GetMouseButton(0);
private bool LeftMouseButtonUp => Input.GetMouseButtonUp(0);
#else
private bool MousePresent => Mouse.current != null;
private Vector2 MousePosition => Mouse.current.position.ReadValue();
private Vector2 MouseScrollDelta => Mouse.current.scroll.ReadValue().normalized;
private bool LeftMouseButtonValue => Mouse.current.leftButton.isPressed;
private bool LeftMouseButtonUp => Mouse.current.leftButton.wasReleasedThisFrame;
#endif

private void UpdateMouse()
{
    if (cam == null || !mouseEnabled || !MousePresent || !NavigationEnabled)
    {
        return;
    }

    // Get the current world-space ray of the mouse
    Ray mouseRay = cam.ScreenPointToRay(MousePosition);

    // Get the current scroll wheel delta
    Vector2 mouseScrollDelta = MouseScrollDelta;

    if (mouseScrollDelta != Vector2.zero)
    {
        // Invert scrolling for a mouse-type experience,
        // otherwise will scroll track-pad style.
        if (invertScrolling)
        {
            mouseScrollDelta.y *= -1f;
        }

        // Create a new Interaction.Update from the mouse ray and scroll wheel control id
        Interaction.Update scrollInteraction = new Interaction.Update(mouseRay, ScrollWheelControlID);

        // Feed the scroll update and scroll delta into Nova's Interaction APIs
        Interaction.Scroll(scrollInteraction, mouseScrollDelta);
    }

    // Create a new Interaction.Update from the mouse ray and pointer control id
    Interaction.Update pointInteraction = new Interaction.Update(mouseRay, MousePointerControlID);

    // Feed the pointer update and pressed state to Nova's Interaction APIs
    Interaction.Point(pointInteraction, LeftMouseButtonValue);

    if (LeftMouseButtonUp)
    {
        // If the mouse button was released this frame, fire the OnPostClick
        // event with the hit UIBlock (or null if there wasn't one)
        Interaction.TryGetActiveReceiver(MousePointerControlID, out UIBlockHit hit);
        OnPostClick?.Invoke(hit.UIBlock);
    }
}
#endregion



#region Navigation

#if ENABLE_LEGACY_INPUT_MANAGER
private bool KeyboardPresent => true;
private bool NavigateUp => Input.GetKey(UpKey);
private bool NavigateDown => Input.GetKey(DownKey);

private bool NavigateLeft => Input.GetKey(LeftKey);
private bool NavigateRight => Input.GetKey(RightKey);
private bool Select => Input.GetKeyUp(SelectKey);
private bool Deselect => Input.GetKeyUp(DeselectKey);

#else
private bool KeyboardPresent => Keyboard.current != null;
private bool NavigateUp => Keyboard.current[GetKey(UpKey)].isPressed;
private bool NavigateDown => Keyboard.current[GetKey(DownKey)].isPressed;
private bool NavigateLeft => Keyboard.current[GetKey(LeftKey)].isPressed;
private bool NavigateRight => Keyboard.current[GetKey(RightKey)].isPressed;
private bool Select => Keyboard.current[GetKey(SelectKey)].wasReleasedThisFrame;
private bool Deselect => Keyboard.current[GetKey(DeselectKey)].wasReleasedThisFrame;
#endif
public const uint NavigationID = 3;
private float prevNavTime = 0;

private void UpdateNavigation()
{
    

    bool canNavigate = KeyboardPresent && NavigationEnabled;
    bool navigating = Navigation.TryGetFocusedUIBlock(NavigationID, out UIBlock focused);

    if (canNavigate && !navigating)
    {
        // Initialize navigation
        EnsureNavigationIndicator();
        if (startNavigationFrom != null)
        {
            Navigation.Focus(startNavigationFrom, NavigationID);
        }
    }

    if (NavigationIndicator != null)
    {
        // Ensure visibility matches navigable status
        NavigationIndicator.gameObject.SetActive(canNavigate && navigating);
    }

    if (!canNavigate || !navigating)
    {
        // Not navigable
        return;
    }

    Vector3 navDirection = Vector3.zero;

    float timeSinceNav = Time.unscaledTime - prevNavTime;

    if (NavigateDown)
    {
        navDirection += Vector3.down;
    }

    if (NavigateUp)
    {
        navDirection += Vector3.up;
    }

    if (NavigateRight)
    {
        navDirection += Vector3.right;
    }

    if (NavigateLeft)
    {
        navDirection += Vector3.left;
    }

    if (navDirection == Vector3.zero)
    {
        // if no navigation key is pressed,
        // "reset" prevNavTime.
        prevNavTime = Time.unscaledTime - updateNavigationEveryXSeconds;
    }

    if (navDirection != Vector3.zero)
    {
        if (timeSinceNav > updateNavigationEveryXSeconds)
        {
            prevNavTime = Time.unscaledTime;
            if (NavigationEnabled)
            {
                Navigation.Move(navDirection, NavigationID);
            }
        }
    }
    else if (Deselect)
    {
        Navigation.Deselect(NavigationID);
    }
    else if (Select)
    {
        Navigation.Select(NavigationID);
    }

    if (focused == null)
    {
        // Nothing to update
        return;
    }

    // Match the world scale of the focused element
    Vector3 parentScale = NavigationIndicator.transform.parent == null ? Vector3.one : NavigationIndicator.transform.parent.lossyScale;
    Vector3 focusedScale = focused.transform.lossyScale;
    NavigationIndicator.transform.localScale = new Vector3(focusedScale.x / parentScale.x, focusedScale.y / parentScale.y, focusedScale.z / parentScale.z);

    // Update size and position to match whatever's focused
    NavigationIndicator.Size = focused.CalculatedSize.Value + NavigationIndicator.CalculatedPadding.Size;
    NavigationIndicator.TrySetWorldPosition(focused.transform.position);
    NavigationIndicator.transform.rotation = focused.transform.rotation;
    lastPress = Time.time;
}
public void HandleGamePadNavigation(InputAction.CallbackContext context)
{
    Debug.Log("Handle gamepad navigation");
    if (!Navigation.isEnabled) return;
    //UpdateMouse();
    //UpdateNavigation();
    Debug.Log("Got context from gamepad");
    bool canNavigate = NavigationEnabled && KeyboardPresent;
    bool navigating = Navigation.TryGetFocusedUIBlock(NavigationID, out UIBlock focused);
    Debug.Log("Focused UI Block" + focused);
    Vector2 inputVector = context.ReadValue<Vector2>();
    Debug.Log("Can navigate? " + canNavigate + navigating + inputVector);
    
    if (canNavigate && !navigating)
    {
        // Initialize navigation
        EnsureNavigationIndicator();
        if (startNavigationFrom != null)
        {
            Navigation.Focus(startNavigationFrom, NavigationID);
        }
    }

    if (NavigationIndicator != null)
    {
        // Ensure visibility matches navigable status
        Debug.Log("Got navigation indicato");
        NavigationIndicator.gameObject.SetActive(canNavigate && navigating);
    }

    if (!canNavigate || !navigating)
    {
        // Not navigable
        Debug.Log("Cannot navigate due to " + canNavigate + navigating);
        return;
    }

    Vector3 navDirection = inputVector;

    float timeSinceNav = Time.unscaledTime - prevNavTime;
    Debug.Log(inputVector.y);
    if (NavigateDown || inputVector.y < -0.15)
    {
        navDirection += Vector3.down;
    }

    if (NavigateUp || inputVector.y > 0.15)
    {
        navDirection += Vector3.up;
    }

    if (NavigateRight)
    {
        navDirection += Vector3.right;
    }

    if (NavigateLeft)
    {
        navDirection += Vector3.left;
    }

    if (navDirection == Vector3.zero)
    {
        // if no navigation key is pressed,
        // "reset" prevNavTime.
        prevNavTime = Time.unscaledTime - updateNavigationEveryXSeconds;
    }

    if (navDirection != Vector3.zero)
    {
        if (timeSinceNav > updateNavigationEveryXSeconds)
        {
            prevNavTime = Time.unscaledTime;
            Navigation.Move(navDirection, NavigationID);
        }
    }
    else if (Deselect)
    {
        Navigation.Deselect(NavigationID);
    }
    else if (Select)
    {
        Navigation.Select(NavigationID);
    }

    if (focused == null)
    {
        // Nothing to update
        return;
    }

    // Match the world scale of the focused element
    Vector3 parentScale = NavigationIndicator.transform.parent == null ? Vector3.one : NavigationIndicator.transform.parent.lossyScale;
    Vector3 focusedScale = focused.transform.lossyScale;
    NavigationIndicator.transform.localScale = new Vector3(focusedScale.x / parentScale.x, focusedScale.y / parentScale.y, focusedScale.z / parentScale.z);

    // Update size and position to match whatever's focused
    NavigationIndicator.Size = focused.CalculatedSize.Value + NavigationIndicator.CalculatedPadding.Size;
    NavigationIndicator.TrySetWorldPosition(focused.transform.position);
    NavigationIndicator.transform.rotation = focused.transform.rotation;
    lastPress = Time.time;
}
private void HandleNavigationFocusChanged(uint controlID, UIBlock focused)
{
    // When navigation focus changes, treat that
    // as though something new was clicked, since
    // we're no longer "hovering" on the previously
    // focused element.
    OnPostClick?.Invoke(focused);
}

private void EnsureNavigationIndicator()
{
    if (NavigationIndicator != null)
    {
        return;
    }

    // Create a new game object to be our focus indicator
    UIBlock2D indicator = new GameObject("Navigation Indicator").AddComponent<UIBlock2D>();

    // Hide the body and enable the border
    indicator.BodyEnabled = false;
    indicator.Border = new Border()
    {
        Enabled = true,
        Width = 5,
        Direction = BorderDirection.Out,
        Color = Color.yellow,
    };

    // Round the cornes a bit
    indicator.CornerRadius = 2;

    // Add some padding
    indicator.Padding.XY = 5;

    // Make sure the indicator will render over the other content
    SortGroup sortGroup = indicator.gameObject.AddComponent<SortGroup>();
    sortGroup.RenderQueue = 4001;
    sortGroup.RenderOverOpaqueGeometry = true;

    // assign the focus indicator
    NavigationIndicator = indicator;
}

//Trimmed the bottom for the long block of keys etc for this post.
}

I've had 25 level ups this morning without the bug so far. I feel that it's not necessarily gone, I've just had a run of good luck.

I had an issue that forced me to reimport Nova the other day (unity licensing services went down). I had originally added to your Navigation script and another deeper script a isEnabled bool to stop this from happening. IT did work.

Something odd about this bug is that whenever the upgrade menu comes up while it's spamming me with the errors, one would think it would stop upon a new upgrade menu, a new selection etc. but no, it will go on forever once it starts.

This is your addon, and you know what's right. I feel like possibly it'd be good to have some kind of function to call to say go back to a clean state since the error does appear to be related to doing something on the next frame when the menu is now gone.

`

[chratcliff]

I apologize for the formatting in that. I have no idea what symbols from the code are breaking it. Not used to github's WYSIWYG editor.

EDIT: can confirm it's still happening. Just had an instance of it while playtesting another new feature.

[chratcliff]

I just discovered that leveling up DOES stop the error. So a fresh menu, without the bug appearing on that roll will fix the error temporarily. Just stinks it keeps trying every frame and gets stuck in that state as it's a lot of errors until the next level up!

[adgray1]

Apologies for the delay!

We believe we have a fix which we'll publish in the next Nova update, but, if you'd prefer to patch it locally than wait, you can replace the if statement on line 710 in Navigation.cs with the following:

if (InternalVar_5 == null)
{
    return InternalType_738.InternalField_2218;
}

[chratcliff]

Hi guys. Put in the fix this morning and so far not an issue despite 30+ level ups. I will report back if something changes. I'd needed to put a check in another spot one time but will let you know if I encounter it. Wanted to say thank you for your support. Makes me feel right to buy a product and get help like this, feels like faith is rewarded. Keep up the good work. Loving Nova.

[dkonik]

v.1.2.3 has just been published with the fix for this!