Touch bug in android il2cpp build

[Drunk3n-P1nky]

The full stack:

07-10 18:37:45.722: E/Unity(31011): ExecutionEngineException: An unresolved indirect call lookup failed
07-10 18:37:45.722: E/Unity(31011): at Nova.Internal.Collections.StructHandle1[T].Remove (Nova.Internal.Collections.UID1[T] instanceID) [0x0001a] in E:\Unity Projects\LegendsOfWizard\Assets\Nova\Scripts\Internal\Collections\StructStorage.cs:61
07-10 18:37:45.722: E/Unity(31011): at Nova.Internal.InputState1+InputRouter[THit].Update[T] (Nova.Internal.Interaction source, T input, Nova.Internal.Collections.ReadOnlyList1[T] sortedHits, Nova.Internal.InteractionType interaction, System.Boolean noisy) [0x0007d] in E:\Unity Projects\LegendsOfWizard\Assets\Nova\Scripts\Internal\InputRouter.cs:263
07-10 18:37:45.722: E/Unity(31011): at Nova.Interaction.UpdateInternal[TInput] (Nova.Interaction+Update& interaction, System.Collections.Generic.List`1[T] hits, TInput input, Nova.Internal.InteractionType interactionType, System.Boolean noisy) [0x0001b] in E:\Unity Projects\LegendsOfWizard\Assets\Nova\Scripts\Public\DataTypes\Interaction.cs:728
07-10 18:37:45.722: E/Unity(31011): at Nova.Interaction.Point (Nova.Interaction+Update update, System.Boolean pointerDown, System.Boolean all

Every time there's touch to process I get such exception. I believe it has nothing to do with type of Input System, but connected somehow with removing UID from "typedInstances" and instanceIDs dictionaries

[adgray1]

While we haven't seen this issue before and don't know exactly what's going on yet, we suspect the IL2CPP build is stripping the generic type somewhere.

So a couple of follow up questions:

1. Which version of Unity are you using and on what platform (Windows, macOS, Linux)?
2. In your Build Settings window, do you see the option IL2CPP Code Generation, and, if you do, what's it set to?

[Drunk3n-P1nky]

Hello!

1. My Unity version is 2022.3.2f1 Windows;
2. Faster (smaller) builds - Il2CppCodeGeneration.OptimizeSize

Anyway OptimizeSize is not production IL2CPP Code Generation type for me. Thank you for leading me into at least some kind of direction. I'll try Il2CppCodeGeneration.OptimizeSpeed and let you know if I experience the same outcome

[Drunk3n-P1nky]

Well, setting IL2CPP Code Generation to faster runtime mode definitely has solved the problem. Good to know! Thank you for your time

[adgray1]

Thank you testing this out and for following up - that's great to hear.

While we're happy you are unblocked with the workaround, we of course still want to investigate further ourselves and understand how to get Faster (smaller) builds working as expected. We'll be sure to update this thread once we have a fix!

Thank you for bringing this issue to our attention!

[baobaogamedev]

Do you have any ETA for Faster (smaller) builds support because the build size is important for mobile game?

[adgray1]

Apologies for the delay on this. While we had tried many variations of the typical solutions to handle the managed code stripping, none of them were successful. It took some deeper investigating (a.k.a more trial and error 😄) to make some sense of what's going on.

Ultimately we believe the underlying cause of the issue is a bug in this new feature Unity first introduced in 2022.1b. If it's not a "bug", per se, it was at least a breaking change, because the same Faster (smaller) builds option doesn't throw the exception if built from 2021.3.29 and disabling the feature in 2022.3.6 via Preferences -> Diagnostics -> Editor -> VMIl2CppAditionalArgs --disable-generic-sharing also seems to "fix" things. Additionally, being a bug could explain why the typical solutions didn't work as expected here.

Long story short, while we're still working on a "proper" fix, we at least have a workaround for folks interested in applying a patch locally:

1. Add the following code to Init() (starts on line 345) in Interaction.cs (full path: Nova\Scripts\Public\DataTypes\Interaction.cs)

((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<bool>>()).Remove(default(UID<InputID>));
((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<UniqueValue<Vector3>>>()).Remove(default(UID<InputID>));

So the updated method will look like this:

internal static void Init()
{
    if (!Compat.NovaApplication.IsPlaying)
    {
        return;
    }

    Router.Init();

+   ((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<bool>>()).Remove(default(UID<InputID>));
+   ((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<UniqueValue<Vector3>>>()).Remove(default(UID<InputID>));
}

2. Change the IStructWrapper interface (line 44) in StructStorage.cs (full path: Nova\Scripts\Internal\Collections\StructStorage.cs) from private to internal. So the change will look like this:

-    private interface IStructWrapper
+    internal interface IStructWrapper
     {
         void Remove(UID<T> instanceID);
     }

Make sure to do both steps, but please let us know if you still continue to see issues after doing so!

**Unfortunately the patch will only work in the paid version of Nova, but we'll be sure to include the fix in the next release for Free Trial users as well!

[adgray1]

The fix for this has just been published in Nova v2.1.1!

[baobaogamedev]

I just updated Nova(paid version) to be v2.1.1 and make an android build but the errors still exist.

[baobaogamedev]

Did already you add these lines in that version?

((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<bool>>()).Remove(default(UID<InputID>));
((StructHandle<InputID>.IStructWrapper)new StructHandle<InputID>.Storage<Input<UniqueValue<Vector3>>>()).Remove(default(UID<InputID>));

[adgray1]

Long story short is we made a mistake in the change that was published, and the bug is still there in 2.1.1.

Adding the lines as described above will resolve the issue in the paid version, but we need to publish a new update to patch the free trial.

Thank you for bringing this to our attention!

[adgray1]

We just published Nova v2.1.2 with the corrected fix :)