New bug in Nova 1.1.4

[j7j7]

I get the following error now when importing the new Nova build.
I'm using Unity 2020.3.3f1

Assets\Nova\Sample\UIControls\Scripts\Editor\UIControlVisualsPropertyDrawer.cs(6,19): error CS0234: The type or namespace name 'Animations' does not exist in the namespace 'UnityEditor' (are you missing an assembly reference?)

The only way I can compile is to remove this whole script.

[adgray1]

Apologies you're seeing this issue! Apparently we missed this when we submitted the new release. We'll submit a fix to the asset as soon as we can.

In the meantime, if you add #if UNITY_EDITOR at the very top of that file and then #endif at the very bottom, like so:

#if UNITY_EDITOR
// current file contents
#endif

That should get your builds working again.

[j7j7]

Thanks -this worked - and removed the errors shown in the console prior to building.

[adgray1]

I may have misunderstood your issue, as there was another issue we discovered when creating a build. Would you mind clarifying when you're seeing this compiler error? Is it on importing Nova into your project or specifically when trying to build your project after updating your version of Nova?

[j7j7]

Hmm....I don't think it is fixed.
if I try and select this in the Item View > Visuals > UI Control Visuals

I get this error in the console - and it doesn't change the selection at all, so I have to revert back to the ToggleVisuals or ButtonVisuals selection.

MissingMethodException: Default constructor not found for type NovaSamples.UIControls.UIControlVisuals
System.RuntimeType.CreateInstanceMono (System.Boolean nonPublic) (at :0)
System.RuntimeType.CreateInstanceSlow (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) (at :0)
System.RuntimeType.CreateInstanceDefaultCtor (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) (at :0)
System.Activator.CreateInstance (System.Type type, System.Boolean nonPublic) (at :0)
System.Activator.CreateInstance (System.Type type) (at :0)
Nova.InternalNamespace_17.InternalNamespace_18.InternalType_579.InternalMethod_566 (System.Type InternalParameter_79) (at Assets/Nova/Scripts/Editor/InternalScript_63.cs:88)
Nova.InternalNamespace_17.InternalNamespace_18.InternalType_581.ItemSelected (UnityEditor.IMGUI.Controls.AdvancedDropdownItem item) (at Assets/Nova/Scripts/Editor/InternalScript_216.cs:86)
UnityEditor.IMGUI.Controls.AdvancedDropdown.b__9_0 (UnityEditor.IMGUI.Controls.AdvancedDropdownWindow w) (at :0)
UnityEditor.IMGUI.Controls.AdvancedDropdownWindow.CloseWindow () (at :0)
UnityEditor.IMGUI.Controls.AdvancedDropdownWindow.DrawList (UnityEditor.IMGUI.Controls.AdvancedDropdownItem item) (at :0)
UnityEditor.IMGUI.Controls.AdvancedDropdownWindow.DrawDropdown (System.Single anim, UnityEditor.IMGUI.Controls.AdvancedDropdownItem group) (at :0)
UnityEditor.IMGUI.Controls.AdvancedDropdownWindow.OnGUI () (at :0)
UnityEditor.HostView.OldOnGUI () (at :0)
UnityEngine.UIElements.IMGUIContainer.DoOnGUI (UnityEngine.Event evt, UnityEngine.Matrix4x4 parentTransform, UnityEngine.Rect clippingRect, System.Boolean isComputingLayout, UnityEngine.Rect layoutSize, System.Action onGUIHandler, System.Boolean canAffectFocus) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.HandleIMGUIEvent (UnityEngine.Event e, UnityEngine.Matrix4x4 worldTransform, UnityEngine.Rect clippingRect, System.Action onGUIHandler, System.Boolean canAffectFocus) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.HandleIMGUIEvent (UnityEngine.Event e, System.Action onGUIHandler, System.Boolean canAffectFocus) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.HandleIMGUIEvent (UnityEngine.Event e, System.Boolean canAffectFocus) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.SendEventToIMGUIRaw (UnityEngine.UIElements.EventBase evt, System.Boolean canAffectFocus, System.Boolean verifyBounds) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.SendEventToIMGUI (UnityEngine.UIElements.EventBase evt, System.Boolean canAffectFocus, System.Boolean verifyBounds) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.IMGUIContainer.HandleEvent (UnityEngine.UIElements.EventBase evt) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatchUtilities.PropagateEvent (UnityEngine.UIElements.EventBase evt) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.MouseEventDispatchingStrategy.SendEventToRegularTarget (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.BaseVisualElementPanel panel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.MouseEventDispatchingStrategy.SendEventToTarget (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.BaseVisualElementPanel panel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.MouseEventDispatchingStrategy.DispatchEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel iPanel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.ApplyDispatchingStrategies (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel, System.Boolean imguiEventIsInitiallyUsed) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.ProcessEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.ProcessEventQueue () (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.OpenGate () (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcherGate.Dispose () (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.ProcessEvent (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.EventDispatcher.Dispatch (UnityEngine.UIElements.EventBase evt, UnityEngine.UIElements.IPanel panel, UnityEngine.UIElements.DispatchMode dispatchMode) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.BaseVisualElementPanel.SendEvent (UnityEngine.UIElements.EventBase e, UnityEngine.UIElements.DispatchMode dispatchMode) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.UIElementsUtility.DoDispatch (UnityEngine.UIElements.BaseVisualElementPanel panel) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.UIElementsUtility.UnityEngine.UIElements.IUIElementsUtility.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr, System.Boolean& eventHandled) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.UIEventRegistration.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.UIElements.UIEventRegistration+<>c.<.cctor>b__1_2 (System.Int32 i, System.IntPtr ptr) (at <0e3a02984c324383b31846a6ed7b2744>:0)
UnityEngine.GUIUtility.ProcessEvent (System.Int32 instanceID, System.IntPtr nativeEventPtr, System.Boolean& result) (at <6ddf8eac3856492ab1b8cf42618915cc>:0)

[adgray1]

While also a bug, this is an unrelated issue. Long story short is UIControlVisuals shouldn't appear in that list. It's just a base class intended to expose shared functionality across the other example Visuals types, ButtonVisuals, ToggleVisuals, SliderVisuals, and DropdownVisuals.

Thank you for bringing this to our attention! Fortunately we were able to act quickly, and the fix for this will be included in our pending asset update - just waiting on the Asset Store Team to approve it :)

[adgray1]

The fix for both these issues is now available in v1.1.5!