UnblockReview: throw error when multiple identical requests open

less risky than responding to the wrong one

fixes #232
fixes #255

Author: NovemLinguae

UnblockReview/main.js

@@ -75,7 +75,7 @@ Many additional bugs fixed.
 			const appealReason = hrEl.nextElementSibling.nextElementSibling.childNodes[ 0 ].textContent;
 			// FIXME: should handle this case (|reason=\nText, https://github.com/NovemLinguae/UserScripts/issues/240) instead of throwing an error
 			if ( appealReason === '\n' ) {
-				mw.notify( 'UnblockReview error 1: unable to find decline reason by scanning HTML', { type: 'error' } );
+				mw.notify( 'UnblockReview error: unable to find decline reason by scanning HTML', { type: 'error' } );
 				return;
 			}
 
@@ -86,15 +86,22 @@ Many additional bugs fixed.
 			// eslint-disable-next-line no-undef
 			const unblockReview = new UnblockReview();
 			const acceptDeclineReason = reasonArea.value;
-			const wikitext2 = unblockReview.processAcceptOrDecline(
-				wikitext,
-				appealReason,
-				acceptDeclineReason,
-				DEFAULT_DECLINE_REASON,
-				acceptOrDecline
-			);
+			let wikitext2;
+			try {
+				wikitext2 = unblockReview.processAcceptOrDecline(
+					wikitext,
+					appealReason,
+					acceptDeclineReason,
+					DEFAULT_DECLINE_REASON,
+					acceptOrDecline
+				);
+			} catch ( e ) {
+				mw.notify( 'UnblockReview error: ' + e.message, { type: 'error' } );
+				return;
+			}
+
 			if ( wikitext === wikitext2 ) {
-				mw.notify( 'UnblockReview error 2: unable to determine write location.', { type: 'error' } );
+				mw.notify( 'UnblockReview error: unable to determine write location.', { type: 'error' } );
 				return;
 			}
 

UnblockReview/modules/UnblockReview.js

@@ -37,6 +37,11 @@ export class UnblockReview {
 		// eslint-disable-next-line no-useless-concat
 		const negativeLookbehinds = '(?<!<' + 'nowiki>)';
 		const regEx = new RegExp( negativeLookbehinds + this.escapeRegExp( initialText + paramsAndReason ), 'g' );
+		const count = ( wikitext.match( regEx ) || [] ).length;
+		if ( count > 1 ) {
+			throw new Error( 'Too many matching unblock templates found' );
+		}
+
 		const templateName = initialText.match( /^\{\{([A-Za-z-]+)/i )[ 1 ];
 		let wikitext2 = wikitext.replace(
 			regEx,
@@ -58,7 +63,7 @@ export class UnblockReview {
 		}
 
 		if ( wikitext === wikitext2 ) {
-			throw new Error( 'Replacing text with unblock message failed!' );
+			throw new Error( 'Replacing text with unblock message failed' );
 		}
 
 		// get rid of any [#*:] in front of {{unblock X}} templates. indentation messes up the background color and border of the unblock template.