UserHighlighterSimple: handle invalid URLs

Author: NovemLinguae

UserHighlighterSimple/modules/UserHighlighterSimple.js

@@ -133,7 +133,12 @@ export class UserHighlighterSimple {
 
 		url = this.addDomainIfMissing( url );
 
-		const urlHelper = new URL( url );
+		let urlHelper;
+		try {
+			urlHelper = new URL( url );
+		} catch {
+			return false;
+		}
 
 		// Skip links that aren't to user pages
 		const isUserPageLink = url.includes( '/w/index.php?title=User' ) || url.includes( '/wiki/User' );

UserHighlighterSimple/tests/UserHighlighterSimple.test.js

@@ -72,6 +72,11 @@ describe( 'linksToAUser( url )', () => {
 	test( 'DiscussionTools section link', () => {
 		expect( userHighlighterSimple.linksToAUser( 'https://en.wikipedia.org/wiki/User_talk:Novem_Linguae#c-Scope_creep-20250218175200-Novem_Linguae-20250218170600' ) ).toBe( false );
 	} );
+
+	test( 'invalid domain name (weird punctuation)', () => {
+		expect( userHighlighterSimple.linksToAUser( 'https://a:a' ) ).toBe( false );
+		expect( userHighlighterSimple.linksToAUser( 'http://Wikipedia:Requests%20for%20arbitration/Eastern%20Europe' ) ).toBe( false );
+	} );
 } );
 
 describe( 'getTitle( url )', () => {