fix linter errors

in preparation for installing a CI linter

Author: NovemLinguae

.eslintignore

@@ -0,0 +1,17 @@
+.vscode
+*.json
+*.yml
+/*.docx
+/=*.*
+/=*/
+cookie.txt
+coverage
+dist
+gitignore/
+Morebits/
+node_modules
+publish_old.php
+publish.config.php
+RequestedArticleSifter
+sandbox*.*
+test*.*

.eslintrc.json

@@ -16,6 +16,7 @@
 	},
 	"rules": {
 		// default rules we don't like
+		"compat/compat": "off",
 		"es-x/no-class-fields": "off",
 		"es-x/no-optional-catch-binding": "off",
 		"es-x/no-regexp-lookbehind-assertions": "off",
@@ -28,6 +29,8 @@
 		"jsdoc/require-returns": "off",
 		"max-len": "off", // annoying
 		"mediawiki/class-doc": "off",
+		"no-alert": "off",
+		"no-console": "off",
 		"no-jquery/no-class-state": "off",
 		"no-jquery/no-extend": "off", // autofix is buggy
 		"no-jquery/no-global-selector": "off",
@@ -43,8 +46,8 @@
 		"no-nested-ternary": "error",
 
 		// rules we should probably fix someday
-		"camelcase": "warn",
-		"eqeqeq": "warn",
-		"no-console": "warn"
+		"camelcase": "off",
+		"eqeqeq": "off",
+		"jsdoc/check-param-names": "off"
 	}
 }

CiteHighlighter/table to bulleted list tool/script.js

@@ -41,6 +41,7 @@ class Tool {
 
 	/** evaluate if a string is a positive integer */
 	isPositiveInteger( n ) {
+		// eslint-disable-next-line no-bitwise
 		return n >>> 0 === parseFloat( n );
 	}
 }

GANReviewTool/modules/GARCloserWikicodeGenerator.js

@@ -494,7 +494,7 @@ __TOC__`;
 		let pos = insertPosition <= 0 ? 0 : insertPosition - 1;
 		let i = 1;
 		while ( pos != 0 ) {
-			const char = talkPageWikicode.substr( pos, 1 );
+			const char = talkPageWikicode.slice( pos, pos + 1 );
 			if ( char == '\n' ) {
 				if ( i != 1 && i != 2 ) { // skip first two \n, those are OK to keep
 					// @ts-ignore
@@ -515,8 +515,8 @@ __TOC__`;
 		}
 
 		const lengthOfRightHalf = talkPageWikicode.length - insertPosition;
-		const leftHalf = talkPageWikicode.substr( 0, insertPosition );
-		const rightHalf = talkPageWikicode.substr( insertPosition, lengthOfRightHalf );
+		const leftHalf = talkPageWikicode.slice( 0, insertPosition );
+		const rightHalf = talkPageWikicode.slice( insertPosition, insertPosition + lengthOfRightHalf );
 
 		if ( insertPosition == 0 ) {
 			return wikicodeToAdd + '\n' + talkPageWikicode;
@@ -538,8 +538,8 @@ __TOC__`;
 	}
 
 	deleteMiddleOfString( string, deleteStartPosition, deleteEndPosition ) {
-		const part1 = string.substr( 0, deleteStartPosition );
-		const part2 = string.substr( deleteEndPosition );
+		const part1 = string.slice( 0, deleteStartPosition );
+		const part2 = string.slice( deleteEndPosition );
 		const final_str = part1 + part2;
 		return final_str;
 	}

QuickVandalBlock.js

@@ -75,7 +75,6 @@ $.when( mw.loader.using( [ 'mediawiki.api', 'mediawiki.util' ] ), $.ready ).then
 	}
 
 	function block( username, duration, logReason, templateName, templateParams ) {
-		// eslint-disable-next-line no-alert
 		if ( confirm( 'Block ' + username + '?' ) ) {
 			new mw.Api().postWithToken( 'csrf', {
 				action: 'block',

SpeciesHelper/main.js

@@ -15,8 +15,6 @@ Got a bug report or feature request? Please let me know on my talk page.
 This page was assembled from 5 files using my publish.php script. I also have an offline test suite with around 175 unit tests.
 */
 
-/* eslint-disable no-alert */
-
 const { SpeciesHelperFunctions } = require( './modules/SpeciesHelperFunctions.js' );
 const { SpeciesHelperData } = require( './modules/SpeciesHelperData.js' );
 const { ConvertToSpeciesBox } = require( './modules/ConvertToSpeciesBox.js' );

TemplateTaxonomyCreator.js

@@ -136,7 +136,6 @@ class TemplateTaxonomyCreator {
 	}
 
 	promptThenAddWikicode( websiteId ) {
-		/* eslint-disable no-alert */
 		const englishRank = prompt( "Enter this taxa's rank. For example, genus, tribe, or subfamily." );
 		const latinRank = this.englishToLatin( englishRank );
 		const needsItalics = this.needsItalics( latinRank );

Titlecaseconverter.js

@@ -1,7 +1,5 @@
 // Forked from https://en.wikipedia.org/wiki/User:ZKang123/Titlecaseconverter.js
 
-/* eslint-disable no-alert, no-console */
-
 $( () => {
 	/**
 	 * Convert titles to title case

UserHighlighterSimple/jest.setup.js

@@ -1,2 +1,3 @@
 import $ from 'jquery';
+/* eslint-disable-next-line no-jquery/variable-pattern, no-undef */
 global.$ = $;

UserHighlighterSimple/tests/UserHighlighterSimple.test.js

@@ -1,5 +1,3 @@
-/* eslint-disable quotes, block-spacing, brace-style, max-statements-per-line */
-
 import { UserHighlighterSimple } from '../modules/UserHighlighterSimple.js';
 
 // Babel is required to use ES6 module syntax