Coalesce duplicate FrameworkReferences when preparing package manifest. (#143)

* Created test to ensure duplicate framework references are coalesced into a single reference when packaging.

* Moved FrameworkAssemblyReferenceComparer from Tests to Tasks project. Added Distinct() to FrameworkReference selection in AddFrameworkAssemblies when building package manifest.

Author: williamb1024

src/Build/NuGet.Build.Packaging.Tasks/CreatePackage.cs

@@ -179,13 +179,13 @@ void AddFiles(Manifest manifest)
 
 		void AddFrameworkAssemblies(Manifest manifest)
 		{
-			var frameworkReferences = from item in Contents
-									  where item.GetMetadata(MetadataName.Kind) == PackageItemKind.FrameworkReference
-									  select new FrameworkAssemblyReference
-									  (
-										  item.ItemSpec,
-										  new [] { NuGetFramework.Parse(item.GetTargetFrameworkMoniker().FullName) }
-									  );
+			var frameworkReferences = (from item in Contents
+			 						   where item.GetMetadata(MetadataName.Kind) == PackageItemKind.FrameworkReference
+			 						   select new FrameworkAssemblyReference
+									   (
+										   item.ItemSpec,
+										   new[] { NuGetFramework.Parse(item.GetTargetFrameworkMoniker().FullName) }
+									   )).Distinct(FrameworkAssemblyReferenceComparer.Default);
 
 			manifest.Metadata.FrameworkReferences = frameworkReferences;
 		}

…es/FrameworkAssemblyReferenceComparer.cs …ks/FrameworkAssemblyReferenceComparer.cssrc/Build/NuGet.Build.Packaging.Tests/Utilities/FrameworkAssemblyReferenceComparer.cs renamed to src/Build/NuGet.Build.Packaging.Tasks/FrameworkAssemblyReferenceComparer.cs src/Build/NuGet.Build.Packaging.Tests/Utilities/FrameworkAssemblyReferenceComparer.cs renamed to src/Build/NuGet.Build.Packaging.Tasks/FrameworkAssemblyReferenceComparer.cs

@@ -3,7 +3,7 @@
 using System.Linq;
 using NuGet.Packaging;
 
-namespace NuGet.Build.Packaging
+namespace NuGet.Build.Packaging.Tasks
 {
 	public class FrameworkAssemblyReferenceComparer : IEqualityComparer<FrameworkAssemblyReference>
     {

src/Build/NuGet.Build.Packaging.Tests/CreatePackageTests.cs

@@ -544,5 +544,49 @@ public void when_creating_package_with_framework_reference_then_contains_referen
 
 			Assert.NotNull(manifest);
 		}
+
+		[Fact]
+		public void when_creating_package_with_duplicate_framework_references_then_contains_only_unique_references()
+		{
+			task.Contents = new[]
+			{
+				new TaskItem("System.Xml", new Metadata
+				{
+					{ MetadataName.PackageId, task.Manifest.GetMetadata("Id") },
+					{ MetadataName.Kind, PackageItemKind.FrameworkReference },
+					{ MetadataName.TargetFrameworkMoniker, TargetFrameworks.NET45 }
+				}),
+				new TaskItem("System.Xml", new Metadata
+				{
+					{ MetadataName.PackageId, task.Manifest.GetMetadata("Id") },
+					{ MetadataName.Kind, PackageItemKind.FrameworkReference },
+					{ MetadataName.TargetFrameworkMoniker, TargetFrameworks.NET45 }
+				}),
+				new TaskItem("System.Xml", new Metadata
+				{
+					{ MetadataName.PackageId, task.Manifest.GetMetadata("Id") },
+					{ MetadataName.Kind, PackageItemKind.FrameworkReference },
+					{ MetadataName.TargetFrameworkMoniker, TargetFrameworks.PCL78 }
+				}),
+				new TaskItem("System.Xml", new Metadata
+				{
+					{ MetadataName.PackageId, task.Manifest.GetMetadata("Id") },
+					{ MetadataName.Kind, PackageItemKind.FrameworkReference },
+					{ MetadataName.TargetFrameworkMoniker, TargetFrameworks.PCL78 }
+				}),
+			};
+
+			var manifest = ExecuteTask();
+
+			Assert.Equal(manifest.Metadata.FrameworkReferences,
+				new[]
+				{
+					new FrameworkAssemblyReference("System.Xml", new [] { NuGetFramework.Parse(TargetFrameworks.NET45) }),
+					new FrameworkAssemblyReference("System.Xml", new [] { NuGetFramework.Parse(TargetFrameworks.PCL78) }),
+				},
+				FrameworkAssemblyReferenceComparer.Default);
+
+			Assert.NotNull(manifest);
+		}
 	}
 }