Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 11f0811

Browse files
committed
Add the prerequisite Merq component explicitly
The existing implicit prerequisite insertion from Merq nuget package isn't working as expected because the component ID in VS doesn't match the generated JSON file name, so instead of relying on the Merq.VisualStudio nuget package to inject the prerequisite, we just add it ourselves manually. Also fixed versioning of the nuget package for local builds with the new numbering scheme. Fixes #5383
1 parent 258ab17 commit 11f0811

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/VisualStudio/NuGet.Packaging.VisualStudio.15/NuGet.Packaging.VisualStudio.15.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
<PackageReference Include="GitInfo" Version="1.1.61" />
5151
<PackageReference Include="Merq" Version="1.0.0-rc" />
5252
<PackageReference Include="Merq.Async" Version="1.1.17-rc" />
53-
<PackageReference Include="Merq.VisualStudio" Version="1.1.17-rc" />
5453
<PackageReference Include="Microsoft.Build" Version="15.1.548" />
5554
<PackageReference Include="Microsoft.VisualStudio.ProjectSystem.SDK" Version="15.0.751" />
5655
<PackageReference Include="Microsoft.VisualStudio.Shell.14.0" Version="14.3.25407" />

src/VisualStudio/NuGet.Packaging.VisualStudio.15/source.extension.vsixmanifest

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="NuGet.Packaging" Version="|NuGet.Packaging.VisualStudio.15;GetVersion|" Language="en-US" Publisher="Microsoft" />
4+
<Identity Id="NuGet.Packaging" Version="|NuGet.Packaging.VisualStudio.15;GetVsixVersion|" Language="en-US" Publisher="Microsoft" />
55
<DisplayName>NuGetizer-3000</DisplayName>
66
<Description xml:space="preserve">NuGet Package Authoring Tools</Description>
77
<License>LICENSE.txt</License>
@@ -11,6 +11,7 @@
1111
</Installation>
1212
<Prerequisites>
1313
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,16.0)" DisplayName="Visual Studio core editor" />
14+
<Prerequisite Id="Microsoft.VisualStudio.Component.Merq" DisplayName="Extensibility Message Bus" Version="[1.1.17,)" />
1415
</Prerequisites>
1516
<Assets>
1617
<Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" d:ProjectName="NuGet.Packaging.VisualStudio" Path="|NuGet.Packaging.VisualStudio|"/>

src/VisualStudio/NuGet.Packaging.VisualStudio.Shared.targets

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@
4343

4444
<Target Name="EnsureNuGetizerPackage"
4545
Condition="'$(CreateVsixContainer)' != 'false' And '$(DeployExtension)' != 'false'"
46-
DependsOnTargets="GetVersion"
46+
DependsOnTargets="GetPackageVersion;GetVsixVersion"
4747
BeforeTargets="DeployVsixExtensionFiles;CreateVsixContainer">
4848
<ItemGroup>
4949
<_NuGetizerPackage Include="$(Out)\*.nupkg" />
5050
<_CurrentNuGetizerPackage Include="@(_NuGetizerPackage)"
51-
Condition="$([System.String]::New('%(Filename)').Replace('NuGet.Build.Packaging.', '')) == '$(Version)'" />
51+
Condition="$([System.String]::New('%(Filename)').Replace('NuGet.Build.Packaging.', '')) == '$(PackageVersion)'" />
5252
</ItemGroup>
5353

5454
<PropertyGroup>
@@ -66,9 +66,9 @@
6666
Packages found were: %0a@(_NuGetizerPackage -> ' %(Filename)%(Extension)', '%0a')" />
6767
</Target>
6868

69-
<Target Name="GetVersion" DependsOnTargets="GitVersion" Returns="$(Version)">
69+
<Target Name="GetVsixVersion" DependsOnTargets="GitVersion" Returns="$(VsixVersion)">
7070
<PropertyGroup>
71-
<Version>$(GitSemVerMajor).$(GitSemVerMinor).$(GitSemVerPatch)</Version>
71+
<VsixVersion>$(GitSemVerMajor).$(GitSemVerMinor).$(GitSemVerPatch)</VsixVersion>
7272
</PropertyGroup>
7373
</Target>
7474

@@ -105,15 +105,15 @@
105105
Value="$(PackageVersion)"/>
106106
</Target>
107107

108-
<Target Name="CopyVsixToOut" AfterTargets="CreateVsixContainer" DependsOnTargets="GetVersion"
108+
<Target Name="CopyVsixToOut" AfterTargets="CreateVsixContainer" DependsOnTargets="GetVsixVersion"
109109
Condition="'$(Out)' != '' And '$(CreateVsixContainer)' == 'true' And Exists('$(TargetVsixContainer)')">
110110
<ItemGroup>
111111
<TargetVsixContainer Include="$(TargetVsixContainer)" />
112112
</ItemGroup>
113113
<!-- Copy the evergreen filename -->
114114
<Copy SourceFiles="@(TargetVsixContainer)" DestinationFolder="$(Out)" />
115115
<!-- And also a versioned filename -->
116-
<Copy SourceFiles="@(TargetVsixContainer)" DestinationFiles="$(Out)\%(TargetVsixContainer.Filename).$(Version)%(TargetVsixContainer.Extension)" />
116+
<Copy SourceFiles="@(TargetVsixContainer)" DestinationFiles="$(Out)\%(TargetVsixContainer.Filename).$(VsixVersion)%(TargetVsixContainer.Extension)" />
117117
</Target>
118118

119119
<!-- Because envdte comes from a nuget package, we can't set the EmbedInteropTypes to true in the project, so we do it here -->

0 commit comments

Comments
 (0)