Fix ProjectMigrateErrorMessage to correctly describe packages.config to PackageReference migration#6827
Closed
Fix ProjectMigrateErrorMessage to correctly describe packages.config to PackageReference migration#6827
Conversation
…to PackageReference migration Co-authored-by: donnie-msft <49205731+donnie-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrator (PC to PR) shouldn't suggest using project.json project
Fix ProjectMigrateErrorMessage to correctly describe packages.config to PackageReference migration
Oct 2, 2025
Contributor
|
@copilot please remove the URL portion and it's good to go |
Co-authored-by: donnie-msft <49205731+donnie-msft@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the misleading error message shown when a project is not eligible for migration from packages.config to PackageReference.
Problem
The error message
ProjectMigrateErrorMessageincorrectly stated:This message was confusing and incorrect because:
Solution
Updated the error message to accurately describe the migration requirements:
This message now:
Context
The message is displayed in Visual Studio when users attempt to migrate a project using the "Migrate packages.config to PackageReference..." command, but the project is not eligible. The underlying code (
NuGetProjectUpgradeUtility.IsNuGetProjectUpgradeableAsync) specifically checks for packages.config projects that support PackageReference, confirming this is a packages.config → PackageReference migration, not a project.json migration.Fixes #14099
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.