More tests for module loading.

Author: dualspiral

src/main/java/uk/co/drnaylor/quickstart/ModuleContainer.java

@@ -145,7 +145,13 @@ private void discoverModules() throws IOException, QuickStartModuleDiscoveryExce
 
         // Load what we have in config into our discovered modules.
         try {
-            config.getConfigAdapter().getNode().forEach((k, v) -> discoveredModules.get(k).setStatus(v));
+            config.getConfigAdapter().getNode().forEach((k, v) -> {
+                try {
+                    discoveredModules.get(k).setStatus(v);
+                } catch (IllegalStateException ex) {
+                    Logger.getLogger("QuickStart").warning("A mandatory module can't have its status changed by config. Falling back to FORCELOAD for " + k);
+                }
+            });
         } catch (ObjectMappingException e) {
             Logger.getLogger("QuickStart").warning("Could not load modules config, falling back to defaults.");
             e.printStackTrace();
@@ -382,7 +388,7 @@ public ModuleContainer build() throws QuickStartModuleDiscoveryException {
         }
     }
 
-    enum ModuleStatusTristate {
+    public enum ModuleStatusTristate {
         ENABLE(k -> k.getValue().getStatus() != LoadingStatus.DISABLED),
         DISABLE(k -> k.getValue().getStatus() == LoadingStatus.DISABLED),
         ALL(k -> true);

src/test/java/uk/co/drnaylor/quickstart/tests/modules/modulestates/DisabledModule.java

@@ -0,0 +1,17 @@
+/*
+ * This file is part of QuickStart Module Loader, licensed under the MIT License (MIT). See the LICENSE.txt file
+ * at the root of this project for more details.
+ */
+package uk.co.drnaylor.quickstart.tests.modules.modulestates;
+
+import uk.co.drnaylor.quickstart.Module;
+import uk.co.drnaylor.quickstart.annotations.ModuleData;
+import uk.co.drnaylor.quickstart.enums.LoadingStatus;
+
+@ModuleData(id = "dis", name = "disabled", status = LoadingStatus.DISABLED)
+public class DisabledModule implements Module {
+    @Override
+    public void onEnable() {
+
+    }
+}

src/test/java/uk/co/drnaylor/quickstart/tests/modules/modulestates/EnabledModule.java

@@ -0,0 +1,17 @@
+/*
+ * This file is part of QuickStart Module Loader, licensed under the MIT License (MIT). See the LICENSE.txt file
+ * at the root of this project for more details.
+ */
+package uk.co.drnaylor.quickstart.tests.modules.modulestates;
+
+import uk.co.drnaylor.quickstart.Module;
+import uk.co.drnaylor.quickstart.annotations.ModuleData;
+
+@ModuleData(id = "en", name = "enabled")
+public class EnabledModule implements Module {
+
+    @Override
+    public void onEnable() {
+
+    }
+}

src/test/java/uk/co/drnaylor/quickstart/tests/modules/modulestates/ForceLoadedModule.java

@@ -0,0 +1,17 @@
+/*
+ * This file is part of QuickStart Module Loader, licensed under the MIT License (MIT). See the LICENSE.txt file
+ * at the root of this project for more details.
+ */
+package uk.co.drnaylor.quickstart.tests.modules.modulestates;
+
+import uk.co.drnaylor.quickstart.Module;
+import uk.co.drnaylor.quickstart.annotations.ModuleData;
+import uk.co.drnaylor.quickstart.enums.LoadingStatus;
+
+@ModuleData(id = "fl", name = "forceload", status = LoadingStatus.FORCELOAD)
+public class ForceLoadedModule implements Module {
+    @Override
+    public void onEnable() {
+
+    }
+}

src/test/java/uk/co/drnaylor/quickstart/tests/modules/modulestates/MandatoryModule.java

@@ -0,0 +1,16 @@
+/*
+ * This file is part of QuickStart Module Loader, licensed under the MIT License (MIT). See the LICENSE.txt file
+ * at the root of this project for more details.
+ */
+package uk.co.drnaylor.quickstart.tests.modules.modulestates;
+
+import uk.co.drnaylor.quickstart.Module;
+import uk.co.drnaylor.quickstart.annotations.ModuleData;
+
+@ModuleData(id = "man", name = "mandat", isRequired = true)
+public class MandatoryModule implements Module {
+    @Override
+    public void onEnable() {
+
+    }
+}

src/test/java/uk/co/drnaylor/quickstart/tests/tests/ModuleContainerConstructionTests.java

@@ -4,6 +4,7 @@
  */
 package uk.co.drnaylor.quickstart.tests.tests;
 
+import org.junit.Assert;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -15,6 +16,8 @@
 import uk.co.drnaylor.quickstart.tests.config.adapters.SimpleWithDefault;
 import uk.co.drnaylor.quickstart.tests.scaffolding.FakeLoaderTests;
 
+import java.util.Set;
+
 import static org.junit.Assert.assertNotNull;
 
 public class ModuleContainerConstructionTests extends FakeLoaderTests {
@@ -65,4 +68,16 @@ public void testThatConfigAdaptersGetRegisteredOnConstruction() throws Exception
         assertNotNull(s);
         assertNotNull(s2);
     }
+
+    @Test
+    public void testThatModulesAreLoadedAsExpected() throws Exception {
+        // When we load these modules...
+        ModuleContainer mc = getContainer("uk.co.drnaylor.quickstart.tests.modules.modulestates");
+        mc.loadModules(true);
+
+        Set<String> ss = mc.getModules(ModuleContainer.ModuleStatusTristate.ENABLE);
+        Assert.assertTrue(ss.contains("man"));
+        Assert.assertTrue(ss.contains("fl"));
+        Assert.assertFalse(ss.contains("dis"));
+    }
 }

src/test/java/uk/co/drnaylor/quickstart/tests/tests/ModuleManagementTests.java

@@ -0,0 +1,101 @@
+/*
+ * This file is part of QuickStart Module Loader, licensed under the MIT License (MIT). See the LICENSE.txt file
+ * at the root of this project for more details.
+ */
+package uk.co.drnaylor.quickstart.tests.tests;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import uk.co.drnaylor.quickstart.ModuleContainer;
+import uk.co.drnaylor.quickstart.config.ModulesConfigAdapter;
+import uk.co.drnaylor.quickstart.exceptions.UndisableableModuleException;
+import uk.co.drnaylor.quickstart.tests.scaffolding.FakeLoaderTests;
+
+public class ModuleManagementTests extends FakeLoaderTests {
+
+    private ModuleContainer mc;
+
+    @Before
+    @Override
+    public void beforeTests() throws Exception {
+        super.beforeTests();
+
+        mc = getContainer("uk.co.drnaylor.quickstart.tests.modules.modulestates");
+    }
+
+    @Test
+    public void checkEnabledModuleCanBeDisabled() throws Exception {
+        mc.disableModule("en");
+        mc.loadModules(true);
+
+        checkEnabled("fl", "man");
+        checkDisabled("en", "dis");
+    }
+
+    @Test
+    public void checkDisabledModuleCanPointlesslyBeDisabled() throws Exception {
+        mc.disableModule("dis");
+        mc.loadModules(true);
+
+        checkEnabled("en", "fl", "man");
+        checkDisabled("dis");
+    }
+
+    @Test(expected = UndisableableModuleException.class)
+    public void checkForceLoadedModuleCannotBeDisabled() throws Exception {
+        mc.disableModule("fl");
+    }
+
+    @Test(expected = UndisableableModuleException.class)
+    public void checkMandatoryModulesCannotBeDisabled() throws Exception {
+        mc.disableModule("man");
+    }
+
+    @Test
+    public void checkForceLoadedByDefaultButActuallyJustEnabledCanActuallyBeDisabled() throws Exception {
+        // Force enabled.
+        n.getNode(ModulesConfigAdapter.modulesKey, "fl").setValue("enabled");
+
+        // Rebuild.
+        mc = getContainer("uk.co.drnaylor.quickstart.tests.modules.modulestates");
+
+        mc.disableModule("fl");
+    }
+
+    @Test
+    public void checkMandatoryModuleCannotBeDisabledEvenIfSomeoneTriesCreatingAConfigEntryForItThatSaysDisabled() throws Exception {
+        // Force enabled.
+        n.getNode(ModulesConfigAdapter.modulesKey, "man").setValue("disabled");
+
+        // Rebuild.
+        mc = getContainer("uk.co.drnaylor.quickstart.tests.modules.modulestates");
+
+        mc.loadModules(true);
+
+        checkEnabled("en", "fl", "man");
+        checkDisabled("dis");
+    }
+
+    @Test(expected = UndisableableModuleException.class)
+    public void checkMandatoryModuleCannotBeDisabledEvenIfSomeoneTriesCreatingAConfigEntryForItThatSaysEnabledAndThenTriesToDisableItAnyway() throws Exception {
+        // Force enabled.
+        n.getNode(ModulesConfigAdapter.modulesKey, "man").setValue("enabled");
+
+        // Rebuild.
+        mc = getContainer("uk.co.drnaylor.quickstart.tests.modules.modulestates");
+        mc.disableModule("man");
+    }
+
+    private void checkEnabled(String... ids) throws Exception {
+        for (String c : ids) {
+            Assert.assertTrue(mc.getModules(ModuleContainer.ModuleStatusTristate.ENABLE).contains(c));
+        }
+    }
+
+    private void checkDisabled(String... ids) throws Exception {
+        for (String c : ids) {
+            Assert.assertFalse(mc.getModules(ModuleContainer.ModuleStatusTristate.ENABLE).contains(c));
+        }
+    }
+}