Skip to content

Commit 282177c

Browse files
committed
Apply suggestions from code review
1 parent 01396db commit 282177c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

setuptools/config/_apply_pyprojecttoml.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,8 @@ def _acessor(obj):
463463
"readme": _attrgetter("metadata.long_description"),
464464
"requires-python": _some_attrgetter("python_requires", "metadata.python_requires"),
465465
"license": _some_attrgetter("metadata.license_expression", "metadata.license"),
466-
# XXX: Should we wait until someone requires `license_files`?
466+
# XXX: `license-file` is currently not considered in the context of `dynamic`.
467+
# See TestPresetField.test_license_files_exempt_from_dynamic
467468
"authors": _some_attrgetter("metadata.author", "metadata.author_email"),
468469
"maintainers": _some_attrgetter("metadata.maintainer", "metadata.maintainer_email"),
469470
"keywords": _attrgetter("metadata.keywords"),

setuptools/dist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ def _finalize_license_expression(self) -> None:
412412
>>> _static.is_static(dist.metadata.license_expression)
413413
True
414414
>>> dist._finalize_license_expression()
415-
>>> _static.is_static(dist.metadata.license_expression) # preserve static-ness"
415+
>>> _static.is_static(dist.metadata.license_expression) # preserve "static-ness"
416416
True
417417
>>> print(dist.metadata.license_expression)
418418
MIT AND GPL-3.0-or-later

0 commit comments

Comments
 (0)