Remove support for returning the directories created in mkpath, unused.

Closes pypa#306

Author: jaraco

distutils/dir_util.py

@@ -44,29 +44,23 @@ def wrapper(path, *args, **kwargs):
 
 @functools.singledispatch
 @wrapper
-def mkpath(name: pathlib.Path, mode=0o777, verbose=True, dry_run=False):
+def mkpath(name: pathlib.Path, mode=0o777, verbose=True, dry_run=False) -> None:
     """Create a directory and any missing ancestor directories.
 
     If the directory already exists (or if 'name' is the empty string, which
     means the current directory, which of course exists), then do nothing.
     Raise DistutilsFileError if unable to create some directory along the way
     (eg. some sub-path exists, but is a file rather than a directory).
     If 'verbose' is true, log the directory created.
-    Return the list of directories actually created.
     """
     if verbose and not name.is_dir():
         log.info("creating %s", name)
 
-    ancestry = itertools.chain((name,), name.parents)
-    missing = list(path for path in ancestry if not path.is_dir())
-
     try:
         dry_run or name.mkdir(mode=mode, parents=True, exist_ok=True)
     except OSError as exc:
         raise DistutilsFileError(f"could not create '{name}': {exc.args[-1]}")
 
-    return list(map(str, missing))
-
 
 @mkpath.register
 def _(name: str, *args, **kwargs):

distutils/tests/test_dir_util.py

@@ -52,17 +52,6 @@ def test_mkpath_with_custom_mode(self):
         mkpath(self.target2, 0o555)
         assert stat.S_IMODE(os.stat(self.target2).st_mode) == 0o555 & ~umask
 
-    def test_mkpath_returns_as_described(self, tmp_path):
-        """
-        Per the docstring, mkpath should return the list of directories created.
-
-        pypa/distutils#305 revealed that the return value is always the empty
-        string and no one complained. Consider removing this expectation.
-        """
-        target = tmp_path / 'foodir'
-        res = mkpath(target)
-        assert res == [str(target)]
-
     def test_create_tree_verbosity(self, caplog):
         create_tree(self.root_target, ['one', 'two', 'three'], verbose=False)
         assert caplog.messages == []