fixes issue #170, fixes issue #171, fixes issue #196, fixes issue #189

Author: Ekultek

autosploit/main.py

@@ -53,41 +53,47 @@ def main():
         misc_info("checking for disabled services")
         # according to ps aux, postgre and apache2 are the names of the services on Linux systems
         service_names = ("postgres", "apache2")
-        if "darwin" in platform_running.lower():
-            service_names = ("postgres", "apachectl")
-
-        for service in list(service_names):
-            while not check_services(service):
-                choice = prompt(
-                    "it appears that service {} is not enabled, would you like us to enable it for you[y/N]".format(
-                        service.title()
-                    )
-                )
-                if choice.lower().startswith("y"):
-                    try:
-                        if "darwin" in platform_running.lower():
-                            cmdline("{} darwin".format(START_SERVICES_PATH))
-                        elif "linux" in platform_running.lower():
-                            cmdline("{} linux".format(START_SERVICES_PATH))
-                        else:
-                            close("your platform is not supported by AutoSploit at this time", status=2)
-
-                        # moving this back because it was funky to see it each run
-                        info("services started successfully")
-                    # this tends to show up when trying to start the services
-                    # I'm not entirely sure why, but this fixes it
-                    except psutil.NoSuchProcess:
-                        pass
-                else:
-                    process_start_command = "`sudo service {} start`"
+        try:
+            for service in list(service_names):
+                while not check_services(service):
                     if "darwin" in platform_running.lower():
-                        process_start_command = "`brew services start {}`"
-                    close(
-                        "service {} is required to be started for autosploit to run successfully (you can do it manually "
-                        "by using the command {}), exiting".format(
-                            service.title(), process_start_command.format(service)
+                        info(
+                            "seems you're on macOS, skipping service checks "
+                            "(make sure that Apache2 and PostgreSQL are running)"
+                        )
+                        break
+                    choice = prompt(
+                        "it appears that service {} is not enabled, would you like us to enable it for you[y/N]".format(
+                            service.title()
                         )
                     )
+                    if choice.lower().startswith("y"):
+                        try:
+                            if "darwin" in platform_running.lower():
+                                cmdline("{} darwin".format(START_SERVICES_PATH))
+                            elif "linux" in platform_running.lower():
+                                cmdline("{} linux".format(START_SERVICES_PATH))
+                            else:
+                                close("your platform is not supported by AutoSploit at this time", status=2)
+
+                            # moving this back because it was funky to see it each run
+                            info("services started successfully")
+                        # this tends to show up when trying to start the services
+                        # I'm not entirely sure why, but this fixes it
+                        except psutil.NoSuchProcess:
+                            pass
+                    else:
+                        process_start_command = "`sudo service {} start`"
+                        if "darwin" in platform_running.lower():
+                            process_start_command = "`brew services start {}`"
+                        close(
+                            "service {} is required to be started for autosploit to run successfully (you can do it manually "
+                            "by using the command {}), exiting".format(
+                                service.title(), process_start_command.format(service)
+                            )
+                        )
+        except Exception:
+            pass
 
         if len(sys.argv) > 1:
             info("attempting to load API keys")
@@ -107,7 +113,7 @@ def main():
         else:
             warning(
                 "no arguments have been parsed, defaulting to terminal session. "
-                "press 99 to quit and help to get help"
+                "press 99 to quit and type `help` to view the help menus"
             )
             misc_info("checking if there are multiple exploit files")
             loaded_exploits = load_exploits(EXPLOIT_FILES_PATH)
@@ -121,11 +127,12 @@ def main():
         print(
             "\033[31m[!] AutoSploit has hit an unhandled exception: '{}', "
             "in order for the developers to troubleshoot and repair the "
-            "issue AutoSploit will need to gather your OS information, metasploit version, "
+            "issue AutoSploit will need to gather your OS information, "
             "current arguments, the error message, and a traceback. "
             "None of this information can be used to identify you in any way\033[0m".format(str(e))
         )
         error_traceback = ''.join(traceback.format_tb(sys.exc_info()[2]))
-        error_file = save_error_to_file(str(error_traceback))
+        error_class = str(e.__class__).split(" ")[1].split(".")[1].strip(">").strip("'")
+        error_file = save_error_to_file(str(error_traceback), str(e), error_class)
         request_issue_creation(error_file, hide_sensitive(), str(e))
 

lib/creation/issue_creator.py

@@ -164,4 +164,6 @@ def request_issue_creation(path, arguments, error_message):
         else:
             lib.output.error(
                 "someone has already created this issue here: {}".format(find_url(identifier))
-            )
+            )
+    else:
+        lib.output.info("the issue has been logged to a file in path: '{}'".format(path))

lib/exploitation/exploiter.py

@@ -116,8 +116,6 @@ def start_exploit(self, sep="*" * 10):
                 use_ruby = "ruby" if self.ruby_exec else ""
                 msf_path = self.msf_path if self.msf_path is not None else "msfconsole"
 
-
-
                 # What's the point of having a workspace if you overwrite it every fucking time..
                 rc_script_template = (
                     "workspace -a {workspace}\n"

lib/settings.py

@@ -21,6 +21,10 @@
 
 # path to the file containing all the discovered hosts
 HOST_FILE = "{}/hosts.txt".format(CUR_DIR)
+try:
+    open(HOST_FILE).close()
+except:
+    open(HOST_FILE, "a+").close()
 
 # path to the folder containing all the JSON exploit modules
 EXPLOIT_FILES_PATH = "{}/etc/json".format(CUR_DIR)
@@ -304,7 +308,7 @@ def configure_requests(proxy=None, agent=None, rand_agent=False):
     return proxy_dict, header_dict
 
 
-def save_error_to_file(error_info):
+def save_error_to_file(error_info, error_message, error_class):
     """
     save an error traceback to log file for further use
     """
@@ -320,5 +324,7 @@ def save_error_to_file(error_info):
     filename = ''.join(filename) + "_AS_error.txt"
     file_path = "{}/{}".format(ERROR_FILES_LOCATION, filename)
     with open(file_path, "a+") as log:
-        log.write(error_info)
+        log.write(
+            "Traceback (most recent call):\n " + error_info.strip() + "\n{}: {}".format(error_class, error_message)
+        )
     return file_path

lib/term/terminal.py

@@ -3,6 +3,7 @@
 
 import lib.settings
 import lib.output
+import lib.errors
 import lib.exploitation.exploiter
 import api_calls.shodan
 import api_calls.zoomeye
@@ -26,6 +27,23 @@ def __init__(self, tokens):
             lib.output.warning("no hosts file present, you need to gather some hosts")
             self.host_path = lib.settings.HOST_FILE
 
+    @staticmethod
+    def help_menu_full():
+        seperator = "-" * 30
+        help_choices = [
+            (0, "usage"),
+            (1, "view"),
+            (2, "single"),
+            (3, "exit"),
+            (4, "gather"),
+            (5, "exploit"),
+            (6, "custom"),
+        ]
+        print("\n{}\nPossible help choices:".format(seperator))
+        for i, _ in enumerate(help_choices):
+            print("{}- `help {}`".format(" " * 3, help_choices[i][1]))
+        print("{}\n".format(seperator))
+
     def usage_and_legal(self):
         """
         shows a display of the output and legal information that resides
@@ -166,6 +184,10 @@ def gather_hosts(self, query, given_choice=None, proxy=None, agent=None):
                 else:
                     lib.output.warning("must be integer between 1-{} not string".format(len(lib.settings.API_URLS.keys())))
                     self.gather_hosts(query, proxy=proxy, agent=agent)
+            except Exception as e:
+                lib.settings.stop_animation = True
+                lib.output.error("unable to search API got error: {}".format(str(e)))
+                break
 
     def exploit_gathered_hosts(self, loaded_mods, hosts=None):
         """
@@ -184,6 +206,7 @@ def exploit_gathered_hosts(self, loaded_mods, hosts=None):
                 try:
                     host_file = open(self.host_path).readlines()
                 except Exception:
+                    sys.stdout.flush()
                     lib.output.error("no host file is present, did you gather hosts?")
                     return
         else:
@@ -339,7 +362,7 @@ def __config_headers():
                         else:
                             lib.output.warning("option must be integer not string")
                     elif choice == "help":
-                        lib.output.error("must provide an argument for help IE 'help exploit'")
+                        AutoSploitTerminal.help_menu_full()
 
         except KeyboardInterrupt:
             print("\n")