feat(ENT-923): update priority threshold in config file parser (#170)

Author: juicetin

pkg/merger/merger_test.go

@@ -96,7 +96,7 @@ func TestMergeConfigFiles(t *testing.T) {
 				EnablePullRequestReviews: models.Bool(true),
 				EnableIssueDashboards:    models.Bool(true),
 				SeverityThreshold:        models.SeverityHigh,
-				PriorityThreshold:        models.PriorityMedium,
+				PriorityThreshold:        models.PriorityImportant,
 				IgnoreDirs:               []string{"dir1", "dir2"},
 				IgnorePaths:              []string{"path1", "path2"},
 				Code: models.Code{
@@ -235,7 +235,7 @@ func TestMergeConfigFiles(t *testing.T) {
 				EnablePullRequestReviews: models.Bool(true),
 				EnableIssueDashboards:    models.Bool(true),
 				SeverityThreshold:        models.SeverityHigh,
-				PriorityThreshold:        models.PriorityMedium,
+				PriorityThreshold:        models.PriorityImportant,
 				IgnoreDirs:               []string{"dir1", "dir2"},
 				IgnorePaths:              []string{"path1", "path2"},
 				Code: models.Code{

pkg/models/priority.go

@@ -1,9 +1,7 @@
 package models
 
 const (
-	PriorityUrgent     string = "URGENT"
-	PriorityImportant  string = "IMPORTANT"
-	PriorityMedium     string = "MEDIUM"
-	PriorityLow        string = "LOW"
-	PriorityNegligible string = "NEGLIGIBLE"
+	PriorityUrgent        string = "URGENT"
+	PriorityImportant     string = "IMPORTANT"
+	PriorityInformational string = "INFORMATIONAL"
 )

pkg/parser/defaults.go

@@ -3,7 +3,7 @@ package parser
 import "github.com/nullify-platform/config-file-parser/pkg/models"
 
 const DefaultSeverityThreshold = models.SeverityMedium
-const DefaultPriorityThreshold = models.PriorityMedium
+const DefaultPriorityThreshold = models.PriorityImportant
 
 func NewDefaultConfig() *models.Configuration {
 	return &models.Configuration{

pkg/parser/parse.go

@@ -25,6 +25,11 @@ func sanitizeConfig(config *models.Configuration) {
 		config.SeverityThreshold = strings.ToUpper(config.SeverityThreshold)
 	}
 
+	config.PriorityThreshold = strings.Trim(config.PriorityThreshold, " ")
+	if config.PriorityThreshold != "" {
+		config.PriorityThreshold = strings.ToUpper(config.PriorityThreshold)
+	}
+
 	for name, n := range config.Notifications {
 		if n.Events.All != nil {
 			n.Events.All.MinimumSeverity = strings.ToUpper(n.Events.All.MinimumSeverity)

pkg/validator/severity.go

@@ -28,9 +28,7 @@ var validPriorities = []string{
 	"",
 	models.PriorityUrgent,
 	models.PriorityImportant,
-	models.PriorityMedium,
-	models.PriorityLow,
-	models.PriorityNegligible,
+	models.PriorityInformational,
 }
 
 // ValidatePriorityThreshold returns true if the priority_threshold

tests/integration_test.go

@@ -15,6 +15,7 @@ func TestIntegration(t *testing.T) {
 		EnablePullRequestReviews: models.Bool(true),
 		EnableIssueDashboards:    models.Bool(true),
 		SeverityThreshold:        models.SeverityMedium,
+		PriorityThreshold:        models.PriorityUrgent,
 		IgnoreDirs:               []string{"dir1"},
 		IgnorePaths:              []string{"data/**/*"},
 		Secrets: models.Secrets{

tests/nullify.yaml

@@ -2,6 +2,7 @@ enable_fail_builds: true
 enable_pull_request_reviews: true
 enable_issue_dashboards: true
 severity_threshold: medium
+priority_threshold: urgent
 ignore_dirs:
   - dir1
 ignore_paths: