Skip to content

Add options to attack surface #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Add options to attack surface #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b3bac6
add options to attack surface
chrisyoonullify Feb 10, 2025
e3d4935
more flexible include_only and ignore rules
chrisyoonullify Feb 10, 2025
7b03329
revert subnets for ip address
chrisyoonullify Feb 10, 2025
364cd9b
revert accidental copypaste
chrisyoonullify Feb 10, 2025
e59e5f0
add newline
chrisyoonullify Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions examples/nullify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,21 @@ integrations:
name: John Smith
attack_surface:
enable: true
enable_dns_enumeration: false
domain_names: [172.36.255.7,example.com]
ignore_domain_names: []
enable_dns_enumeration: true
ip_addresses: [10.11.12.13, 10.0.0.1-254]
domain_names: [example.com, prod.hosting.com]
include_only:
- domain_names: [live.prod.hosting.com]
http:
paths: [/main, /api/**/create]
ignore:
- http:
methods: [DELETE]
- domain_names: [jira.example.com, "*.testing.example.com"]
- ip_addresses: [100.110.120.130]
transport_protocols: [tcp]
ports: [22, 8080, 9990-9999]
- domain_names: ["dev.*", "staging.*"]
http:
paths: [/auth]
methods: [POST]
72 changes: 66 additions & 6 deletions pkg/merger/merger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,40 @@ func TestMergeConfigFiles(t *testing.T) {
name: "only global config for attack surface monitoring",
globalConfig: &models.Configuration{
AttackSurface: &models.AttackSurface{
Enable: true,
Enable: true,
EnableDNSEnumeration: true,
DomainNames: []string{"example.com"},
IgnoreDomainNames: []string{"example2.com"},
IPAddresses: []string{"10.11.12.13", "10.0.0.1-254"},
DomainNames: []string{"example.com", "prod.hosting.com"},
IncludeOnly: []models.AttackSurfaceIncludeOnly{
{
DomainNames: []string{"live.prod.hosting.com"},
HTTP: &models.HTTPAttackSurfaceIncludeOnly{
Paths: []string{"/main", "/api/**/create"},
},
},
},
Ignore: []models.AttackSurfaceIgnore{
{
HTTP: &models.HTTPAttackSurfaceIgnore{
Methods: []string{"DELETE"},
},
},
{
DomainNames: []string{"jira.example.com", "*.testing.example.com"},
},
{
IPAddresses: []string{"100.110.120.130"},
TransportProtocols: []string{"tcp"},
Ports: []string{"22", "8080", "9990-9999"},
},
{
DomainNames: []string{"dev.*", "staging.*"},
HTTP: &models.HTTPAttackSurfaceIgnore{
Paths: []string{"/auth"},
Methods: []string{"POST"},
},
},
},
},
},
repoConfig: nil,
Expand All @@ -351,10 +381,40 @@ func TestMergeConfigFiles(t *testing.T) {
SeverityThreshold: parser.DefaultSeverityThreshold,
PriorityThreshold: parser.DefaultPriorityThreshold,
AttackSurface: &models.AttackSurface{
Enable: true,
Enable: true,
EnableDNSEnumeration: true,
DomainNames: []string{"example.com"},
IgnoreDomainNames: []string{"example2.com"},
IPAddresses: []string{"10.11.12.13", "10.0.0.1-254"},
DomainNames: []string{"example.com", "prod.hosting.com"},
IncludeOnly: []models.AttackSurfaceIncludeOnly{
{
DomainNames: []string{"live.prod.hosting.com"},
HTTP: &models.HTTPAttackSurfaceIncludeOnly{
Paths: []string{"/main", "/api/**/create"},
},
},
},
Ignore: []models.AttackSurfaceIgnore{
{
HTTP: &models.HTTPAttackSurfaceIgnore{
Methods: []string{"DELETE"},
},
},
{
DomainNames: []string{"jira.example.com", "*.testing.example.com"},
},
{
IPAddresses: []string{"100.110.120.130"},
TransportProtocols: []string{"tcp"},
Ports: []string{"22", "8080", "9990-9999"},
},
{
DomainNames: []string{"dev.*", "staging.*"},
HTTP: &models.HTTPAttackSurfaceIgnore{
Paths: []string{"/auth"},
Methods: []string{"POST"},
},
},
},
},
},
},
Expand Down
33 changes: 29 additions & 4 deletions pkg/models/attack_surface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,33 @@ package models

type AttackSurface struct {
// global only
Enable bool `yaml:"enable"`
EnableDNSEnumeration bool `yaml:"enable_dns_enumeration"`
DomainNames []string `yaml:"domain_names,omitempty"`
IgnoreDomainNames []string `yaml:"ignore_domain_names,omitempty"`
Enable bool `yaml:"enable"`
EnableDNSEnumeration bool `yaml:"enable_dns_enumeration"`
IPAddresses []string `yaml:"ip_addresses,omitempty"`
DomainNames []string `yaml:"domain_names,omitempty"`
IncludeOnly []AttackSurfaceIncludeOnly `yaml:"include_only,omitempty"`
Ignore []AttackSurfaceIgnore `yaml:"ignore,omitempty"`
}

type AttackSurfaceIncludeOnly struct {
DomainNames []string `yaml:"domain_names,omitempty"`
HTTP *HTTPAttackSurfaceIncludeOnly `yaml:"http,omitempty"`
}

type HTTPAttackSurfaceIncludeOnly struct {
Paths []string `yaml:"paths,omitempty"`
}

type AttackSurfaceIgnore struct {
// empty fields are equivalent to *
IPAddresses []string `yaml:"ip_addresses,omitempty"`
DomainNames []string `yaml:"domain_names,omitempty"`
TransportProtocols []string `yaml:"transport_protocols,omitempty"`
Ports []string `yaml:"ports,omitempty"`
HTTP *HTTPAttackSurfaceIgnore `yaml:"http,omitempty"`
}

type HTTPAttackSurfaceIgnore struct {
Methods []string `yaml:"methods,omitempty"`
Paths []string `yaml:"paths,omitempty"`
}
34 changes: 32 additions & 2 deletions tests/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,38 @@ func TestIntegration(t *testing.T) {
AttackSurface: &models.AttackSurface{
Enable: true,
EnableDNSEnumeration: true,
DomainNames: []string{"172.36.255.7", "example.com"},
IgnoreDomainNames: []string{"jira.example.com"},
IPAddresses: []string{"10.11.12.13", "10.0.0.1-254"},
DomainNames: []string{"example.com", "prod.hosting.com"},
IncludeOnly: []models.AttackSurfaceIncludeOnly{
{
DomainNames: []string{"live.prod.hosting.com"},
HTTP: &models.HTTPAttackSurfaceIncludeOnly{
Paths: []string{"/main", "/api/**/create"},
},
},
},
Ignore: []models.AttackSurfaceIgnore{
{
HTTP: &models.HTTPAttackSurfaceIgnore{
Methods: []string{"DELETE"},
},
},
{
DomainNames: []string{"jira.example.com", "*.testing.example.com"},
},
{
IPAddresses: []string{"100.110.120.130"},
TransportProtocols: []string{"tcp"},
Ports: []string{"22", "8080", "9990-9999"},
},
{
DomainNames: []string{"dev.*", "staging.*"},
HTTP: &models.HTTPAttackSurfaceIgnore{
Paths: []string{"/auth"},
Methods: []string{"POST"},
},
},
},
},
}

Expand Down
19 changes: 17 additions & 2 deletions tests/nullify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,20 @@ integrations:
attack_surface:
enable: true
enable_dns_enumeration: true
domain_names: [172.36.255.7,example.com]
ignore_domain_names: [jira.example.com]
ip_addresses: [10.11.12.13, 10.0.0.1-254]
domain_names: [example.com, prod.hosting.com]
include_only:
- domain_names: [live.prod.hosting.com]
http:
paths: [/main, /api/**/create]
ignore:
- http:
methods: [DELETE]
- domain_names: [jira.example.com, "*.testing.example.com"]
- ip_addresses: [100.110.120.130]
transport_protocols: [tcp]
ports: [22, 8080, 9990-9999]
- domain_names: ["dev.*", "staging.*"]
http:
paths: [/auth]
methods: [POST]
Loading