Skip to content

Commit 776b25f

Browse files
authored
Refactor compression_core::util (#373)
- mark assert_* as const - relax generic bound on PartialBuffer struct definition - use mem::take instead of mem::replate Signed-off-by: Jiahao XU <[email protected]>
1 parent 86371ba commit 776b25f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

crates/compression-core/src/util.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
pub fn _assert_send<T: Send>() {}
2-
pub fn _assert_sync<T: Sync>() {}
1+
pub const fn _assert_send<T: Send>() {}
2+
pub const fn _assert_sync<T: Sync>() {}
33

44
#[derive(Debug, Default)]
5-
pub struct PartialBuffer<B: AsRef<[u8]>> {
5+
pub struct PartialBuffer<B> {
66
buffer: B,
77
index: usize,
88
}
@@ -43,7 +43,7 @@ impl<B: AsRef<[u8]> + AsMut<[u8]>> PartialBuffer<B> {
4343
}
4444

4545
pub fn copy_unwritten_from<C: AsRef<[u8]>>(&mut self, other: &mut PartialBuffer<C>) -> usize {
46-
let len = std::cmp::min(self.unwritten().len(), other.unwritten().len());
46+
let len = self.unwritten().len().min(other.unwritten().len());
4747

4848
self.unwritten_mut()[..len].copy_from_slice(&other.unwritten()[..len]);
4949

@@ -55,7 +55,7 @@ impl<B: AsRef<[u8]> + AsMut<[u8]>> PartialBuffer<B> {
5555

5656
impl<B: AsRef<[u8]> + Default> PartialBuffer<B> {
5757
pub fn take(&mut self) -> Self {
58-
std::mem::replace(self, Self::new(B::default()))
58+
std::mem::take(self)
5959
}
6060
}
6161

0 commit comments

Comments
 (0)