Merge pull request #32 from NumPower/fix/bug_fix_patch

henrique-borba · web-flow · commit 7c2184ae6081 · 2023-08-09T21:20:55.000-03:00
Fix NDArray_Fill method memory error
Fixed isGPU method to return value correctly
diff --git a/numpower.c b/numpower.c
@@ -317,9 +317,7 @@ PHP_METHOD(NDArray, fill) {
     if (array == NULL) {
         return;
     }
-    rtn = NDArray_Fill(array, (float)value);
-    NDArray_ADDREF(array);
-    RETURN_NDARRAY_NOBUFFER(rtn, return_value);
+    NDArray_Fill(array, (float)value);
 }
 
 ZEND_BEGIN_ARG_INFO(arginfo_toArray, 0)
@@ -423,9 +421,9 @@ PHP_METHOD(NDArray, isGPU) {
     NDArray* array = ZVAL_TO_NDARRAY(obj_zval);
 
     if (NDArray_DEVICE(array) == NDARRAY_DEVICE_CPU) {
-        RETURN_LONG(1);
-    } else {
         RETURN_LONG(0);
+    } else {
+        RETURN_LONG(1);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -317,9 +317,7 @@ PHP_METHOD(NDArray, fill) {`
`317`	`317`	`if (array == NULL) {`
`318`	`318`	`return;`
`319`	`319`	`}`
`320`		`- rtn = NDArray_Fill(array, (float)value);`
`321`		`- NDArray_ADDREF(array);`
`322`		`- RETURN_NDARRAY_NOBUFFER(rtn, return_value);`
	`320`	`+ NDArray_Fill(array, (float)value);`
`323`	`321`	`}`
`324`	`322`
`325`	`323`	`ZEND_BEGIN_ARG_INFO(arginfo_toArray, 0)`
`@@ -423,9 +421,9 @@ PHP_METHOD(NDArray, isGPU) {`
`423`	`421`	`NDArray* array = ZVAL_TO_NDARRAY(obj_zval);`
`424`	`422`
`425`	`423`	`if (NDArray_DEVICE(array) == NDARRAY_DEVICE_CPU) {`
`426`		`- RETURN_LONG(1);`
`427`		`- } else {`
`428`	`424`	`RETURN_LONG(0);`
	`425`	`+ } else {`
	`426`	`+ RETURN_LONG(1);`
`429`	`427`	`}`
`430`	`428`	`}`
`431`	`429`