Skip to content

Commit 3b464fa

Browse files
committed
hotfix not removing mixed audio tracks after recording
1 parent f5c2829 commit 3b464fa

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

public/app.html

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,13 @@
622622
}
623623
async function handleStop(event) {
624624
log('Recorder stopped: ', event);
625-
625+
await self.app.audio.ctx.close();
626+
627+
for(var x = 0; x < self.app.audio.recordTracks.length;x++) {
628+
console.log("removing tracks");
629+
stream.removeTrack(self.app.audio.recordTracks[x]);
630+
}
631+
626632
if(self.app.video.mode == "none") {
627633
const superBuffer = new Blob(recordedBlobs, {type: 'audio/webm'});
628634
var url = (window.URL || window.webkitURL).createObjectURL(superBuffer);
@@ -638,6 +644,7 @@
638644
} else {
639645
const superBuffer = new Blob(recordedBlobs, {type: 'video/webm'});
640646
playscreen.el.src = window.URL.createObjectURL(superBuffer);
647+
self.app.events.off("hitTrack",self.app.events.hitTrack);
641648
}
642649

643650
}
@@ -657,8 +664,11 @@
657664
recordHolder.el.style.display = "";
658665
recordedBlobs = [];
659666

660-
667+
661668
var audioCtx = new AudioContext();
669+
self.app.audio.ctx = audioCtx;
670+
self.app.audio.recordTracks = [];
671+
662672
var audioMixer = audioCtx.createMediaStreamDestination();
663673

664674
if( self.app.audio.mode == "mic" ) {
@@ -697,9 +707,14 @@
697707

698708
// mixing audio and video
699709
if( ( self.app.audio.mode == "mic" || self.app.hasAudioTracks() ) && self.app.video.mode != "none") {
710+
console.log("MIXED IN AUDIO AND VIDEO");
700711
audioMixer.stream
701712
.getAudioTracks()
702-
.forEach((audioTrack) => stream.addTrack(audioTrack));
713+
.forEach((audioTrack) => {
714+
self.app.audio.recordTracks.push(audioTrack);
715+
console.log(audioTrack);
716+
stream.addTrack(audioTrack);
717+
});
703718
}
704719

705720
if(self.app.video.mode != "none") {

0 commit comments

Comments
 (0)