More quality assurance: ExplicitImports (#74)

giordano · web-flow · commit dd6e3bcd7767 · 2025-11-06T02:45:00.000Z
diff --git a/src/AtmosphereModels/anelastic_formulation.jl b/src/AtmosphereModels/anelastic_formulation.jl
@@ -8,10 +8,9 @@ using ..Thermodynamics:
     dry_air_gas_constant
 
 using Oceananigans.Architectures: architecture
-using Oceananigans.Grids: inactive_cell
+using Oceananigans.Grids: inactive_cell, prettysummary
 using Oceananigans.Operators: Δzᵃᵃᶜ, Δzᵃᵃᶠ, divᶜᶜᶜ
 using Oceananigans.Solvers: solve!
-using Oceananigans.Utils: prettysummary
 
 using KernelAbstractions: @kernel, @index
 
@@ -279,4 +278,4 @@ function make_pressure_correction!(model::AnelasticModel, Δt)
             model.formulation.reference_density)
 
     return nothing
-end
+end
diff --git a/src/AtmosphereModels/atmosphere_model.jl b/src/AtmosphereModels/atmosphere_model.jl
@@ -7,13 +7,12 @@ using ..Thermodynamics:
     mixture_heat_capacity,
     dry_air_gas_constant
 
-using Oceananigans
-using Oceananigans.Advection: Centered, adapt_advection_order
-using Oceananigans.Architectures: AbstractArchitecture
+using Oceananigans: Oceananigans, AbstractModel, Center, CenterField, Clock, Face, Field, Flat,
+    WENO, XFaceField, YFaceField, ZFaceField
+using Oceananigans.Advection: adapt_advection_order
 using Oceananigans.BoundaryConditions: FieldBoundaryConditions, regularize_field_boundary_conditions
 using Oceananigans.Grids: ZDirection
-using Oceananigans.Models: AbstractModel
-using Oceananigans.Solvers: FourierTridiagonalPoissonSolver, HomogeneousNeumannFormulation
+using Oceananigans.Solvers: FourierTridiagonalPoissonSolver
 using Oceananigans.TimeSteppers: TimeStepper
 using Oceananigans.Utils: launch!
 
@@ -193,8 +192,7 @@ function AtmosphereModel(grid;
     return model
 end
 
-using Oceananigans.Utils: prettytime, ordered_dict_show, prettykeys
-using Oceananigans.TurbulenceClosures: closure_summary
+using Oceananigans.Utils: prettytime, prettykeys
 
 function Base.summary(model::AtmosphereModel)
     A = nameof(typeof(model.grid.architecture))
diff --git a/src/AtmosphereModels/set_atmosphere_model.jl b/src/AtmosphereModels/set_atmosphere_model.jl
@@ -1,6 +1,5 @@
 using Oceananigans.BoundaryConditions: fill_halo_regions!
-using Oceananigans.Models.NonhydrostaticModels: compute_pressure_correction!, make_pressure_correction!
-using Oceananigans.TimeSteppers: update_state!
+using Oceananigans.TimeSteppers: compute_pressure_correction!, make_pressure_correction!, update_state!
 
 import Oceananigans.Fields: set!
 
diff --git a/src/AtmosphereModels/update_hydrostatic_pressure.jl b/src/AtmosphereModels/update_hydrostatic_pressure.jl
@@ -2,8 +2,7 @@
 ##### update pressure
 #####
 
-using Oceananigans.Grids: topology, XFlatGrid, YFlatGrid
-using Oceananigans.ImmersedBoundaries: PartialCellBottom, ImmersedBoundaryGrid
+using Oceananigans.Grids: topology
 using Oceananigans.Operators: Δzᶜᶜᶜ, Δzᶜᶜᶠ, ℑzᵃᵃᶠ
 using Oceananigans.Utils: KernelParameters
 
diff --git a/src/Breeze.jl b/src/Breeze.jl
@@ -17,7 +17,27 @@ export
     mixture_gas_constant,
     mixture_heat_capacity
 
-using Oceananigans
+using Oceananigans: Oceananigans, @at, AnisotropicMinimumDissipation, Average,
+                    AveragedTimeInterval, BackgroundField, BetaPlane, Bounded,
+                    CPU, Callback, Center, CenterField, Centered, Checkpointer,
+                    ConstantCartesianCoriolis, Distributed, FPlane, Face,
+                    Field, FieldBoundaryConditions, FieldDataset,
+                    FieldTimeSeries, Flat, FluxBoundaryCondition, Forcing, GPU,
+                    GradientBoundaryCondition, GridFittedBottom,
+                    ImmersedBoundaryCondition, ImmersedBoundaryGrid, InMemory,
+                    Integral, IterationInterval, JLD2Writer,
+                    KernelFunctionOperation, LagrangianParticles, NetCDFWriter,
+                    NonTraditionalBetaPlane, OnDisk, OpenBoundaryCondition,
+                    PartialCellBottom, Partition, Periodic,
+                    PerturbationAdvection, RectilinearGrid, Simulation,
+                    SmagorinskyLilly, SpecifiedTimes, TimeInterval,
+                    UpwindBiased, ValueBoundaryCondition, WENO,
+                    WallTimeInterval, XFaceField, YFaceField, ZFaceField,
+                    add_callback!, compute!, conjure_time_step_wizard!,
+                    interior, iteration, minimum_xspacing, minimum_yspacing,
+                    minimum_zspacing, nodes, prettytime, regrid!, run!, set!,
+                    time_step!, xnodes, xspacings, ynodes, yspacings, znodes,
+                    zspacings, ∂x, ∂y, ∂z
 using Oceananigans.Grids: znode
 
 export
diff --git a/src/MoistAirBuoyancies.jl b/src/MoistAirBuoyancies.jl
@@ -6,12 +6,11 @@ export TemperatureField
 export CondensateField
 export SaturationField
 
-using Oceananigans
-using Oceananigans: AbstractModel
+using Oceananigans: Oceananigans, Center, Field, KernelFunctionOperation
 using Oceananigans.Grids: AbstractGrid
 using Oceananigans.Operators: ∂zᶜᶜᶠ
 
-using Adapt
+using Adapt: Adapt, adapt
 
 import Oceananigans.BuoyancyFormulations: AbstractBuoyancyFormulation,
                                           buoyancy_perturbationᶜᶜᶜ,
diff --git a/src/Thermodynamics/atmosphere_thermodynamics.jl b/src/Thermodynamics/atmosphere_thermodynamics.jl
@@ -1,5 +1,5 @@
-using Adapt
-using Oceananigans.Utils: prettysummary
+using Adapt: Adapt, adapt
+using Oceananigans.Grids: prettysummary
 
 """
     IdealGas{FT}
diff --git a/src/Thermodynamics/reference_states.jl b/src/Thermodynamics/reference_states.jl
@@ -1,4 +1,4 @@
-using Oceananigans
+using Oceananigans: Oceananigans
 
 #####
 ##### Reference state computations for Boussinesq and Anelastic models
diff --git a/test/Project.toml b/test/Project.toml
@@ -1,11 +1,13 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 Oceananigans = "9e8cae18-63c1-5223-a75c-80ca9d6e9a09"
 ParallelTestRunner = "d3525ed8-44d0-4b2c-a655-542cee43accc"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
 Aqua = "0.8"
+ExplicitImports = "1.13"
 Oceananigans = "0.100"
 ParallelTestRunner = "2.0.1"
 Test = "<0.0.1, 1"
diff --git a/test/aqua.jl b/test/aqua.jl
diff --git a/test/quality_assurance.jl b/test/quality_assurance.jl
@@ -0,0 +1,30 @@
+using Breeze: Breeze
+using Aqua: Aqua
+using ExplicitImports: ExplicitImports
+using Test: @testset, @test
+
+@testset "Aqua" begin
+    Aqua.test_all(Breeze)
+end
+
+@testset "ExplicitImports" begin
+    @testset "Explicit Imports" begin
+        @test ExplicitImports.check_no_implicit_imports(Breeze) === nothing
+    end
+
+    @testset "Import via Owner" begin
+        @test ExplicitImports.check_all_explicit_imports_via_owners(Breeze) === nothing
+    end
+
+    @testset "Stale Explicit Imports" begin
+        @test ExplicitImports.check_no_stale_explicit_imports(Breeze) === nothing
+    end
+
+    @testset "Qualified Accesses" begin
+        @test ExplicitImports.check_all_qualified_accesses_via_owners(Breeze) === nothing
+    end
+
+    @testset "Self Qualified Accesses" begin
+        @test ExplicitImports.check_no_self_qualified_accesses(Breeze) === nothing
+    end
+end

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using Oceananigans`
	`1`	`+using Oceananigans: Oceananigans`
`2`	`2`
`3`	`3`	`#####`
`4`	`4`	`##### Reference state computations for Boussinesq and Anelastic models`