Fully skip Aqua in downstream testing (#148)

* Fully skip Aqua in downstream testing

Aqua.jl just doesn't generally do well with downstream tests. So instead of disabling one test, it should just disable them all. This will fix https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/13932593014/job/38997101429#step:5:1605

* Update test/runtests.jl

Co-authored-by: Joshua Lampert <[email protected]>

* update comment

* format

---------

Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>

Author: 3 people

test/runtests.jl

@@ -213,31 +213,28 @@ end
 
 @testset "PositiveIntegrators.jl tests" begin
     @testset "Aqua.jl" begin
-        # We do not test ambiguities since we get a lot of
-        # false positives from dependencies.
-        ambiguities = false
-        # The persistent_tasks test fails in the Downgrade CI
-        # action but not in regular CI - we just skip it there.
-        if !isempty(get(ENV, "POSITIVEINTEGRATORS_DOWNGRADE_CI", ""))
-            persistent_tasks = false
-        else
-            persistent_tasks = true
-        end
-        # The stale_deps test fails in the Downstream CI action
+        # The Aqua.jl tests fails in the Downstream CI action
         # of OrdinaryDiffEq.jl but not in our regular CI - we just
         # skip it there.
         if !isempty(get(ENV, "GROUP", ""))
-            @info "Skipping stale_deps tests from Aqua.jl"
-            stale_deps = false
+            @info "Skipping tests from Aqua.jl"
         else
-            @info "Running stale_deps tests from Aqua.jl"
-            stale_deps = true
+            @info "Running tests from Aqua.jl"
+            # We do not test ambiguities since we get a lot of
+            # false positives from dependencies.
+            ambiguities = false
+            # The persistent_tasks test fails in the Downgrade CI
+            # action but not in regular CI - we just skip it there.
+            if !isempty(get(ENV, "POSITIVEINTEGRATORS_DOWNGRADE_CI", ""))
+                persistent_tasks = false
+            else
+                persistent_tasks = true
+            end
+            Aqua.test_all(PositiveIntegrators;
+                          ambiguities = ambiguities,
+                          piracies = (; treat_as_own = [RecipesBase.apply_recipe],),
+                          persistent_tasks = persistent_tasks)
         end
-        Aqua.test_all(PositiveIntegrators;
-                      ambiguities = ambiguities,
-                      piracies = (; treat_as_own = [RecipesBase.apply_recipe],),
-                      persistent_tasks = persistent_tasks,
-                      stale_deps = stale_deps,)
     end
 
     @testset "ExplicitImports.jl" begin