the gossip frame now properly shows a scrollbar when the text becomes too long. Since it might be risky, there's an option to disable this

Author: Numynum

main.lua

@@ -175,9 +175,9 @@ function DialogKey:OnPlayerChoiceHide()
     self.playerChoiceButtons = {}
 end
 
---- @param gossipFrame GossipFrame
-function DialogKey:OnGossipFrameUpdate(gossipFrame)
-    local scrollbox = gossipFrame.GreetingPanel.ScrollBox
+--- @param GossipFrame GossipFrame
+function DialogKey:OnGossipFrameUpdate(GossipFrame)
+    local scrollbox = GossipFrame.GreetingPanel.ScrollBox
 
     self.frames = {};
     local n = 1
@@ -193,25 +193,32 @@ function DialogKey:OnGossipFrameUpdate(gossipFrame)
         end
         if tag then
             if self.db.numKeysForGossip then
-                frame:SetText((n % 10) .. ". " .. data.info[tag])
+                local newText = (n % 10) .. ". " .. data.info[tag]
+                if self.db.riskyNumKeysForGossip then
+                    data.info[tag] = newText -- this may not be safe, but it looks like the only somewhat reliable way to ensure the scrollbar is enabled when needed
+                end
+                frame:SetText(newText)
                 frame:SetHeight(frame:GetFontString():GetHeight() + 2)
             end
             self.frames[n] = frame
             n = n + 1
         end
         if n > 10 then break end
     end
-    local oldScale = scrollbox:GetScale()
-    scrollbox:SetScale(oldScale + 0.002) -- trigger OnSizeChanged
-    RunNextFrame(function() scrollbox:SetScale(oldScale) end) -- OnSizeChanged only fires if the size actually changed at the end of the frame
+    --- @type ScrollBoxListLinearViewMixin
+    local view = scrollbox:GetView()
+    view:Layout()
+    if self.db.riskyNumKeysForGossip then
+        scrollbox:ScrollIncrease() -- force the scrollbar to show if needed
+    end
 end
 
 --- @return StaticPopupTemplate|nil
 function DialogKey:GetFirstVisiblePopup()
     for i = 1, 4 do
         local popup = _G["StaticPopup"..i]
         if popup and popup:IsVisible() then
-            return popup
+            table.insert(popupFrames, popup)
         end
     end
 end

options.lua

@@ -16,6 +16,7 @@ ns.defaultOptions = {
     --- @type table<string, number> # [frameName] = priority
     customFrames = {},
     numKeysForGossip = true,
+    riskyNumKeysForGossip = true,
     numKeysForQuestRewards = true,
     dontClickSummons = true,
     dontClickDuels = true,
@@ -241,6 +242,13 @@ function ns:GetOptionsTable()
                         desc = "Use the number keys (1 -> 0) to select Gossip options or Quests from an NPC dialog window",
                         descStyle = "inline", width = "full", type = "toggle",
                     },
+                    riskyNumKeysForGossip = {
+                        order = increment(),
+                        name = wrapName("Number keys for Gossip - Risky"),
+                        disabled = function() return not db.numKeysForGossip end,
+                        desc = "Ensure scrollbar is enabled if the text becomes too long. This may taint objective frame buttons, such as dropping candles in delves. If you encounter issues, just disable this option.",
+                        descStyle = "inline", width = "full", type = "toggle",
+                    },
                     numKeysForQuestRewards = {
                         order = increment(),
                         name = wrapName("Number keys for Quest Rewards"),