Minor visual improvements to the config UI

Author: Numynum

config.lua

@@ -218,9 +218,10 @@ do
 
     --- @param text string
     --- @param tooltip string?
+    --- @param indent number? # default 0
     --- @return SettingsListElementInitializer initializer
-    function ConfigBuilderMixin:MakeHeader(text, tooltip)
-        local initializer = Config:MakeHeader(text, tooltip);
+    function ConfigBuilderMixin:MakeHeader(text, tooltip, indent)
+        local initializer = Config:MakeHeader(text, tooltip, indent);
         initializer:AddShownPredicate(self.isExpanded);
 
         return initializer;
@@ -358,28 +359,53 @@ end
 do
     --- @param text string
     --- @param tooltip string?
+    --- @param indent number? # default 0
     --- @return SettingsListElementInitializer
-    function Config:MakeHeader(text, tooltip)
-        local headerInitializer = CreateSettingsListSectionHeaderInitializer(text, tooltip);
-        self.layout:AddInitializer(headerInitializer);
+    function Config:MakeHeader(text, tooltip, indent)
+        local data = { name = text, tooltip = tooltip, indent = indent or 0 };
+        --- @type SettingsListElementInitializer
+        local headerInitializer = Settings.CreateElementInitializer("MythicPlusTweaks_SettingsHeaderTemplate", data);
 
         return headerInitializer;
     end
 
-    local heightCalculator = UIParent:CreateFontString(nil, "ARTWORK", "GameFontNormal");
+    local calculateHeight;
+    do
+        local heightCalculator = UIParent:CreateFontString(nil, "ARTWORK", "GameFontNormal");
+        local deferrer = CreateFrame("Frame");
+        deferrer:Hide();
+        deferrer.callbacks = {};
+        deferrer:SetScript("OnUpdate", function()
+            for _, callback in pairs(deferrer.callbacks) do
+                securecallfunction(callback);
+            end
+            deferrer.callbacks = {};
+        end);
+        function deferrer:Defer(callback)
+            table.insert(self.callbacks, callback);
+            self:Show();
+        end
+        calculateHeight = function(data, deferred)
+            local text, indent = data.name, data.indent;
+            heightCalculator:SetWidth(635 - (indent * 15));
+            heightCalculator:SetText(text);
+
+            data.extent = heightCalculator:GetStringHeight();
+            if not deferred then
+                deferrer:Defer(function() calculateHeight(data, true); end);
+            end
+        end
+    end
 
     --- @param text string
     --- @param indent number? # default 0
     --- @return SettingsListElementInitializer
     function Config:MakeText(text, indent)
-        heightCalculator:SetWidth(635 - (indent or 0));
-        heightCalculator:SetText(text);
-
         local data = {
             name = text,
-            extent = heightCalculator:GetStringHeight(),
             indent = indent or 0,
         };
+        calculateHeight(data);
         --- @type SettingsListElementInitializer
         local textInitializer = Settings.CreateElementInitializer("MythicPlusTweaks_SettingsTextTemplate", data);
 
@@ -785,4 +811,21 @@ do
             self.Text:SetPoint('TOPLEFT', (7 + (indent * 15)), 0);
         end
     end
+
+    MythicPlusTweaks_SettingsHeaderMixin = CreateFromMixins(DefaultTooltipMixin);
+    do
+        --- @class MPT_Config_HeaderMixin
+        local mixin = MythicPlusTweaks_SettingsHeaderMixin;
+
+        function mixin:Init(initializer)
+            local data = initializer:GetData();
+            self.Title:SetTextToFit(data.name);
+            local indent = data.indent or 0;
+            self.Title:SetPoint('TOPLEFT', (7 + (indent * 15)), -16);
+
+            self:SetCustomTooltipAnchoring(self.Title, "ANCHOR_RIGHT");
+
+            self:SetTooltipFunc(function() Settings.InitTooltip(initializer:GetName(), initializer:GetTooltip()) end);
+        end
+    end
 end

modules/dungeonTeleports.lua

@@ -126,6 +126,8 @@ function Module:BuildConfig(configBuilder, db)
             }
         );
         initializer:AddModifyPredicate(function() return self.db.showAlternates; end);
+
+        return initializer;
     end
     addAlternateOption(
         TYPE_DUNGEON_PORTAL,
@@ -142,7 +144,7 @@ function Module:BuildConfig(configBuilder, db)
         'Class teleports',
         'Show class teleports as an alternative teleport. (Mage portals, Druid Dreamwalk, etc.)'
     );
-    addAlternateOption(
+    local hearthstone = addAlternateOption(
         TYPE_HEARTHSTONE,
         'Hearthstone',
         'Show hearthstone as an alternative teleport. Only some specific locations are supported. Includes Shaman Astral Recall.'
@@ -151,7 +153,7 @@ function Module:BuildConfig(configBuilder, db)
         'Show a random hearthstone',
         'shuffleSharedCooldown',
         'Shows a random hearthstone, if a hearthstone would show up, and you have multiple toys'
-    );
+    ):SetParentInitializer(hearthstone);
 end
 
 function Module:InitializeButtonPools()

modules/keystoneSharingAddons/_keystoneSharing-core.lua

@@ -61,7 +61,7 @@ function Module:BuildConfig(configBuilder, db)
     ):AddShownPredicate(function() return not self:IsEnabled(); end);
     configBuilder:MakeText(WHITE_FONT_COLOR:WrapTextInColorCode(
         'LibOpenRaid has been embedded into this addon, which allows various addons to use the same data sharing that Details! includes by default. This makes it a popular choice for fetching keystone information from your party/raid and guild members. Addons making use of this, include REKeys, PortaParty, and others.'
-    ), 1);
+    ), 2);
     configBuilder:MakeCheckbox(
         'Share alt keystones',
         'shareAlts',

settingsTemplates.xml

@@ -58,4 +58,19 @@ https://raw.githubusercontent.com/Meorawr/wow-ui-schema/main/UI.xsd">
             </Layer>
         </Layers>
     </Frame>
+    <Frame name="MythicPlusTweaks_SettingsHeaderTemplate" mixin="MythicPlusTweaks_SettingsHeaderMixin" virtual="true">
+        <Size y="45"/>
+        <Layers>
+            <Layer level="OVERLAY">
+                <FontString parentKey="Title" inherits="GameFontHighlightLarge" justifyH="LEFT" justifyV="TOP">
+                    <Anchors>
+                        <Anchor point="TOPLEFT" x="7" y="-16"/>
+                    </Anchors>
+                </FontString>
+            </Layer>
+        </Layers>
+        <Scripts>
+            <OnLoad method="OnLoad"/>
+        </Scripts>
+    </Frame>
 </Ui>

types.lua

@@ -32,6 +32,9 @@
 --- @class MPT_Config_TextMixin: Frame, DefaultTooltipMixin
 --- @field Text FontString
 
+--- @class MPT_Config_HeaderMixin: Frame, DefaultTooltipMixin
+--- @field Title FontString
+
 --- @class MPT_Config_SettingData
 --- @field setting AddOnSettingMixin
 --- @field name string