Fix the "Open Mythic+ UI" button in the settings not working in certain situations

Author: Numynum

SharedUtil.lua

@@ -16,6 +16,20 @@ local scoreRarityColors = {
     dungeonOverallScore = { 0, 125, 188, 225, 275 },
 };
 
+function Util:ToggleMythicPlusFrame()
+    local shouldShow = not (ChallengesFrame and ChallengesFrame:IsVisible());
+    PVEFrame_ToggleFrame('ChallengesFrame');
+    if shouldShow == ChallengesFrame:IsVisible() then return; end
+
+    PVEFrame:SetShown(shouldShow);
+    if PVEFrame:GetNumPoints() == 0 then
+        PVEFrame:SetPoint('TOPLEFT', 16, -116); -- roughly where it would normally open
+    end
+    if not tIndexOf(UISpecialFrames, 'PVEFrame') then
+        table.insert(UISpecialFrames, 'PVEFrame');
+    end
+end
+
 --- @return ColorMixin
 function Util:GetRarityColorOverallScore(score)
     return C_ChallengeMode.GetDungeonScoreRarityColor(score) or self:GetRarityColor(score, 'overallScore');

modules/alwaysShowAffixes.lua

@@ -27,9 +27,7 @@ function Module:GetOptions(defaultOptionsTable)
         type = 'execute',
         name = 'Open Mythic+ UI',
         desc = 'Open the Mythic+ UI and the affixes are on the top of the UI.',
-        func = function()
-            PVEFrame_ToggleFrame('ChallengesFrame');
-        end,
+        func = function() Util:ToggleMythicPlusFrame(); end,
     };
 
     return defaultOptionsTable;

modules/dungeonIconText.lua

@@ -162,9 +162,7 @@ function Module:GetOptions(defaultOptionsTable, db)
         type = 'execute',
         name = 'Open Mythic+ UI',
         desc = 'Open the Mythic+ UI and the icons are on the bottom of the UI.',
-        func = function()
-            PVEFrame_ToggleFrame('ChallengesFrame');
-        end,
+        func = function() Util:ToggleMythicPlusFrame(); end,
         order = increment(),
     };
     defaultOptionsTable.args.dash = {

modules/dungeonIconTooltip.lua

@@ -71,9 +71,7 @@ function Module:GetOptions(defaultOptionsTable, db, increment)
         order = increment(),
         name = 'Open Mythic+ UI',
         desc = 'Open the Mythic+ UI and hover over a dungeon icon to see an example.',
-        func = function()
-            PVEFrame_ToggleFrame('ChallengesFrame');
-        end,
+        func = function() Util:ToggleMythicPlusFrame(); end,
     };
 
     return defaultOptionsTable;

modules/partyRating.lua

@@ -79,9 +79,7 @@ function Module:GetOptions(defaultOptionsTable, db, increment)
         order = increment(),
         name = 'Open Mythic+ UI',
         desc = 'Open the Mythic+ UI and hover over a dungeon icon to see an example.',
-        func = function()
-            PVEFrame_ToggleFrame('ChallengesFrame');
-        end,
+        func = function() Util:ToggleMythicPlusFrame(); end,
     };
 
     return defaultOptionsTable;

modules/sortDungeonIcons.lua

@@ -67,9 +67,7 @@ function Module:GetOptions(defaultOptionsTable, db)
         type = 'execute',
         name = 'Open Mythic+ UI',
         desc = 'Open the Mythic+ UI and the icons are on the bottom of the UI.',
-        func = function()
-            PVEFrame_ToggleFrame('ChallengesFrame');
-        end,
+        func = function() Util:ToggleMythicPlusFrame(); end,
         order = increment(),
     };
     defaultOptionsTable.args.sortStyle = {