The Save button is now disabled if there are no changes

Author: Numynum

core/ManagerApi.lua

@@ -228,6 +228,15 @@ function GlobalAPI:UpdateCustomLoadoutWithImportString(loadoutID, importText)
     return result and self:GetLoadoutInfoByID(loadoutID) or false, (not result and errorOrLevelingOrder or nil);
 end
 
+--- Returns a serialized string of talent selections from an import string
+--- Can be useful to compare import strings to see if they contain the same build
+--- IMPORTANT: the returned string format is not guaranteed to be stable, and may change at any time in the future
+--- @param importText string - the import string (icy-veins calculator URLs are also supported)
+--- @return string|false - false on failure, serializedSelectedNodes on success
+function GlobalAPI:SerializeLoadoutString(importText)
+    return TLM:BuildSerializedSelectedNodesFromImportString(importText);
+end
+
 -------------------------------------------------------------------------
 ---
 --- character specific functions

modules/DefaultUISidebar.lua

@@ -57,6 +57,10 @@ function Module:GetDefaultActionText(elementData)
         or "Load";
 end
 
+function Module:GetExportString()
+    return C_Traits.GenerateImportString(C_ClassTalents.GetActiveConfigID());
+end
+
 function Module:UpdateCustomLoadoutWithCurrentTalents(loadoutID)
     -- todo: add warning if the loadout has leveling information, as that'll get lost
     CharacterAPI:UpdateCustomLoadoutWithCurrentTalents(loadoutID);

modules/SideBarMixin.lua

@@ -211,7 +211,9 @@ function SideBarMixin:SetupHook()
     if not self.importDialog then
         self.importDialog = self:CreateImportDialog();
     end
-    self:SecureHookScript(self:GetTalentsTab(), "OnShow", "OnTalentsTabShow");
+    local talentsTab = self:GetTalentsTab();
+    self:SecureHookScript(talentsTab, "OnShow", "OnTalentsTabShow");
+    self:SecureHook(talentsTab, "OnUpdate", "OnTalentsChanged");
 
     API:RegisterCallback(API.Event.LoadoutListUpdated, self.RefreshSideBarData, self);
 end
@@ -232,6 +234,7 @@ do
         error('override in implementation');
     end
 
+    --- @return TalentLoadoutManagerAPI_LoadoutInfo|nil - selected loadout's info, if any
     function SideBarMixin:GetActiveLoadout(forceRefresh)
         error('override in implementation');
     end
@@ -249,6 +252,10 @@ do
         error('override in implementation');
     end
 
+    function SideBarMixin:GetExportString()
+        error('override in implementation');
+    end
+
     function SideBarMixin:UpdateCustomLoadoutWithCurrentTalents(loadoutID)
         error('override in implementation');
     end
@@ -263,6 +270,41 @@ do
     end
 end
 
+function SideBarMixin:OnTalentsChanged()
+    if self.talentChangePending then return; end
+    self.talentChangePending = true
+    RunNextFrame(function()
+        self.talentChangePending = false
+
+        self:SaveButtonUpdateEnableState();
+    end);
+end
+
+function SideBarMixin:SaveButtonUpdateEnableState()
+    local activeLoadout = self:GetActiveLoadout();
+    local identicalTalents = false;
+    if activeLoadout then
+        local savedExportString = GlobalAPI:GetExportString(activeLoadout.id);
+        local currentExportString = self:GetExportString();
+
+        if savedExportString == currentExportString then
+            identicalTalents = true;
+        elseif savedExportString and currentExportString and savedExportString ~= "" and currentExportString ~= "" then
+            local serializedSavedExportString = GlobalAPI:SerializeLoadoutString(savedExportString);
+            local serializedCurrentExportString = GlobalAPI:SerializeLoadoutString(currentExportString);
+
+            identicalTalents = serializedSavedExportString == serializedCurrentExportString;
+        end
+    end
+
+    self.SideBar.SaveButton:SetEnabled(
+        activeLoadout
+        and not activeLoadout.isBlizzardLoadout
+        and not activeLoadout.isLocked
+        and not identicalTalents
+    );
+end
+
 function SideBarMixin:OnTalentsTabShow(frame)
     self:UpdateScaleForFit(frame:GetParent());
     self:UpdatePosition(frame:GetParent());
@@ -565,6 +607,7 @@ function SideBarMixin:CreateSideBar()
         if not activeLoadout or not activeLoadout.id then return; end
 
         self:UpdateCustomLoadoutWithCurrentTalents(activeLoadout.id);
+        self:SaveButtonUpdateEnableState();
     end);
     sideBar.SaveButton.tooltipText = "Save the current talents into the currently selected loadout";
 
@@ -839,7 +882,7 @@ function SideBarMixin:SetElementAsActive(frame, loadoutInfo)
         previouslyActiveLoadoutFrame:ApplyColors();
     end
     frame:ApplyColors();
-    self.SideBar.SaveButton:SetEnabled(self.activeLoadout and not self.activeLoadout.isBlizzardLoadout and not self.activeLoadout.isLocked);
+    self:SaveButtonUpdateEnableState();
 end
 
 --- @param frame TLM_ElementFrame
@@ -1036,7 +1079,7 @@ function SideBarMixin:RefreshSideBarData()
     self.DataProvider = CreateDataProvider(dataProviderEntries);
     self.SideBar.ScrollBoxContainer.ScrollBox:SetDataProvider(self.DataProvider);
 
-    self.SideBar.SaveButton:SetEnabled(self.activeLoadout and not self.activeLoadout.isBlizzardLoadout and not self.activeLoadout.isLocked);
+    self:SaveButtonUpdateEnableState();
 end
 
 function SideBarMixin:ShowConfigDialog()

modules/TalentTreeViewerSidebar.lua

@@ -10,6 +10,7 @@ local GlobalAPI = TalentLoadoutManagerAPI.GlobalAPI;
 local Module = TLM:NewModule("TTVSideBar", "AceHook-3.0");
 TLM.TTVSideBarModule = Module;
 
+--- @type TLM_SideBarMixin
 local parentMixin = ns.SideBarMixin;
 Mixin(Module, parentMixin);
 
@@ -46,6 +47,10 @@ function Module:GetDefaultActionText(elementData)
     return "Load";
 end
 
+function Module:GetExportString()
+    return self:GetTalentTreeViewer():ExportLoadout();
+end
+
 function Module:UpdateCustomLoadoutWithCurrentTalents(loadoutID)
     local importString = self:GetTalentTreeViewer():ExportLoadout();
     -- todo: check if importString contains lvling info, if it doesn't, and current loadout does, show warning