Fixed an issue with a rogue talent, and potentially some others

Author: Numynum

TalentTreeViewer/TalentViewer.lua

@@ -4,7 +4,6 @@ local ns = select(2, ...)
 
 if LE_EXPANSION_LEVEL_CURRENT <= LE_EXPANSION_SHADOWLANDS then print(name, 'requires Dragonflight to work') return end
 
-ns.starterBuildID = Constants.TraitConsts.STARTER_BUILD_TRAIT_CONFIG_ID
 ns.MAX_LEVEL_CLASS_CURRENCY_CAP = 31
 ns.MAX_LEVEL_SPEC_CURRENCY_CAP = 30
 ns.TOTAL_CURRENCY_CAP = ns.MAX_LEVEL_CLASS_CURRENCY_CAP + ns.MAX_LEVEL_SPEC_CURRENCY_CAP
@@ -34,9 +33,9 @@ local cache = {
 	specIconId = {},
 }
 TalentViewer.cache = cache
----@type LibTalentTree
+---@type LibTalentTree-1.0
 local LibTalentTree = LibStub('LibTalentTree-1.0')
---- @type LibUIDropDownMenuNumy
+--- @type LibUIDropDownMenuNumy-4.0
 local LibDD = LibStub("LibUIDropDownMenuNumy-4.0")
 
 local L = LibStub('AceLocale-3.0'):GetLocale(name)
@@ -277,16 +276,6 @@ function TalentViewer:SelectSpec(classId, specId)
 	))
 
 	self:ResetTree();
-	-- starter builds are not really correct yet :/
-	--self:ApplyLevelingBuild(ns.starterBuildID);
-	--self:SetStarterBuildActive(false);
-	--local totalCurrencySpent = 0
-	--for _, currencySpent in pairs(self.currencySpending) do
-	--	totalCurrencySpent = totalCurrencySpent + currencySpent;
-	--end
-	--if totalCurrencySpent < ns.TOTAL_CURRENCY_CAP then
-	--	self:ResetTree();
-	--end
 end
 
 function TalentViewer:SetPortraitIcon(specId)
@@ -408,10 +397,6 @@ function TalentViewer:GetLevelingBuild(buildID)
 	return; -- TODO
 end
 
-function TalentViewer:SetStarterBuildActive(active)
-	self:GetTalentFrame():SetLevelingBuildID(active and ns.starterBuildID or nil)
-end
-
 function TalentViewer:ApplyLevelingBuild(buildID, level)
 	self:GetTalentFrame():SetLevelingBuildID(buildID)
 	self:GetTalentFrame():ApplyLevelingBuild(level)

TalentTreeViewer/TalentViewerUIMixin.lua

@@ -7,7 +7,7 @@ if not TalentViewer then return end
 --- @type TalentViewer_Cache
 local tvCache = TalentViewer.cache
 
----@type LibTalentTree
+---@type LibTalentTree-1.0
 local LibTalentTree = LibStub('LibTalentTree-1.0')
 
 local L = LibStub('AceLocale-3.0'):GetLocale(name)
@@ -96,6 +96,7 @@ local parentMixin = ClassTalentTalentsTabMixin
 --- @class TalentViewerUIMixin
 TalentViewer_ClassTalentTalentsTabMixin = deepCopy(parentMixin)
 
+--- @class TalentViewerUIMixin
 local TalentViewerUIMixin = TalentViewer_ClassTalentTalentsTabMixin
 local function removeFromMixin(method) TalentViewerUIMixin[method] = function() end end
 removeFromMixin('UpdateConfigButtonsState')
@@ -203,10 +204,13 @@ function TalentViewerUIMixin:MeetsEdgeRequirements(nodeID)
     return GetOrCreateTableEntryByCallback(self.edgeRequirementsCache, nodeID, EdgeRequirementCallback)
 end
 
+--- @return TVNodeInfo
 function TalentViewerUIMixin:GetAndCacheNodeInfo(nodeID)
     local function GetNodeInfoCallback(nodeID)
+        --- @class TVNodeInfo: libNodeInfo
         local nodeInfo = LibTalentTree:GetLibNodeInfo(TalentViewer.treeId, nodeID)
         if not nodeInfo then
+            --- @class TVNodeInfo: libNodeInfo
             nodeInfo = LibTalentTree:GetNodeInfo(TalentViewer.treeId, nodeID)
             if DevTool and DevTool.AddData then
                 DevTool:AddData(
@@ -254,7 +258,7 @@ function TalentViewerUIMixin:GetAndCacheNodeInfo(nodeID)
             edge.isActive = nodeInfo.activeRank == nodeInfo.maxRanks
         end
 
-        if #nodeInfo.entryIDs > 1 then
+        if nodeInfo.type == Enum.TraitNodeType.Selection then
             local entryIndex
             for i, entryId in ipairs(nodeInfo.entryIDs) do
                 if entryId == selectedEntryId then
@@ -303,7 +307,7 @@ end
 
 function TalentViewerUIMixin:GetAndCacheEntryInfo(entryID)
     local function GetEntryInfoCallback(entryID)
-        local entryInfo = LibTalentTree:GetEntryInfo(self:GetTalentTreeID(), entryID);
+        local entryInfo = LibTalentTree:GetEntryInfo(entryID);
         if entryInfo then
             entryInfo.entryCost = {};
         else
@@ -682,9 +686,6 @@ function TalentViewerUIMixin:UpdateLevelingBuildHighlights()
 end
 
 function TalentViewerUIMixin:GetLevelingBuildInfo(buildID)
-    if buildID == ns.starterBuildID then
-        return nil; -- Starter build info is not available
-    end
     return TalentViewer:GetLevelingBuild(buildID);
 end
 
@@ -700,10 +701,6 @@ function TalentViewerUIMixin:GetNextLevelingBuildPurchase(buildID)
     end
 end
 
-function TalentViewerUIMixin:GetHasStarterBuild()
-    return false;
-end
-
 function TalentViewerUIMixin:IsLevelingBuildActive()
     return self.activeLevelingBuildID ~= nil;
 end