Add improved error handling for icyveins builds, and fix issues with certain classes

Author: Numynum

TalentTreeViewer/IcyVeinsImport.lua

@@ -11,6 +11,8 @@ local skillMappings = tInvert{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
 --- @type LibTalentTree-1.0
 local libTT = LibStub('LibTalentTree-1.0');
 
+local L = LibStub('AceLocale-3.0'):GetLocale(name)
+
 --- @param text string
 --- @return boolean
 function IcyVeinsImport:IsTalentUrl(text)
@@ -104,16 +106,31 @@ function IcyVeinsImport:ParseDataSegment(startingLevel, dataSegment, levelingOrd
             local mappingIndex = skillMappings[char];
 
             local nodeID = nodes[mappingIndex];
-            local entryIndex = nextChar == '1' and 2 or 1;
-            local nodeInfo = libTT:GetNodeInfo(nodeID);
-            local entry = nodeInfo.type == Enum.TraitNodeType.Selection and nodeInfo.entryIDs and nodeInfo.entryIDs[entryIndex] or nil;
-            rankByNodeID[nodeID] = (rankByNodeID[nodeID] or 0) + 1;
-
-            levelingOrder[level] = {
-                nodeID = nodeID,
-                entryID = entry,
-                targetRank = rankByNodeID[nodeID],
-            };
+            if not nodeID then
+                print(L['Error while importing IcyVeins URL: Could not find node for mapping index'], mappingIndex);
+                if DevTool and DevTool.AddData then
+                    DevTool:AddData({
+                        mappingIndex = mappingIndex,
+                        char = char,
+                        nextChar = nextChar,
+                        index = index,
+                        dataSegment = dataSegment,
+                        splitDataSegment = splitDataSegment,
+                        nodes = nodes,
+                    }, 'Error while importing IcyVeins URL: Could not find node for mapping index')
+                end
+            else
+                local entryIndex = nextChar == '1' and 2 or 1;
+                local nodeInfo = libTT:GetNodeInfo(nodeID);
+                local entry = nodeInfo.type == Enum.TraitNodeType.Selection and nodeInfo.entryIDs and nodeInfo.entryIDs[entryIndex] or nil;
+                rankByNodeID[nodeID] = (rankByNodeID[nodeID] or 0) + 1;
+
+                levelingOrder[level] = {
+                    nodeID = nodeID,
+                    entryID = entry,
+                    targetRank = rankByNodeID[nodeID],
+                };
+            end
         end
     end
 end
@@ -131,10 +148,12 @@ function IcyVeinsImport:GetClassAndSpecNodeIDs(specID, treeID)
 
     for _, nodeID in ipairs(nodes or {}) do
         local nodeInfo = libTT:GetNodeInfo(nodeID);
-        if nodeInfo.isClassNode then
-            table.insert(classNodes, nodeID);
-        elseif libTT:IsNodeVisibleForSpec(specID, nodeID) and nodeInfo.maxRanks > 0 then
-            table.insert(specNodes, nodeID);
+        if libTT:IsNodeVisibleForSpec(specID, nodeID) and nodeInfo.maxRanks > 0 then
+            if nodeInfo.isClassNode then
+                table.insert(classNodes, nodeID);
+            else
+                table.insert(specNodes, nodeID);
+            end
         end
     end
 

TalentTreeViewer/TalentViewer.lua

@@ -609,7 +609,19 @@ function TalentViewer:RecordLevelingEntry(nodeID, targetRank, entryID)
     local baseLevel = self.recordingInfo.startingOffset[indexKey];
     local level = baseLevel + (#entries * 2);
 
-    self:GetTalentFrame():GetTalentButtonByNodeID(nodeID).LevelingOrder:AppendToOrder(level);
+    local button = self:GetTalentFrame():GetTalentButtonByNodeID(nodeID);
+    if not button then
+        if DevTool and DevTool.AddData then
+            DevTool:AddData({
+                entry = entries[#entries],
+                nodeID = nodeID,
+                level = level,
+                nodeInfo = self:GetTalentFrame():GetAndCacheNodeInfo(nodeID),
+            }, 'could not find button for NodeID when recording');
+        end
+        return
+    end
+    button.LevelingOrder:AppendToOrder(level);
 end
 
 function TalentViewer:RemoveLastRecordedLevelingEntry(nodeID)
@@ -623,7 +635,18 @@ function TalentViewer:RemoveLastRecordedLevelingEntry(nodeID)
             removed = i;
             table.remove(entries, i);
             self.recordingInfo.currentIndex[indexKey] = #entries;
-            self:GetTalentFrame():GetTalentButtonByNodeID(nodeID).LevelingOrder:RemoveLastOrder();
+            local button = self:GetTalentFrame():GetTalentButtonByNodeID(nodeID);
+            if not button then
+                if DevTool and DevTool.AddData then
+                    DevTool:AddData({
+                        entry = entry,
+                        nodeID = nodeID,
+                        nodeInfo = self:GetTalentFrame():GetAndCacheNodeInfo(nodeID),
+                    }, 'could not find button for NodeID when removing');
+                end
+            else
+                button.LevelingOrder:RemoveLastOrder();
+            end
             break;
         end
     end
@@ -632,7 +655,18 @@ function TalentViewer:RemoveLastRecordedLevelingEntry(nodeID)
             local entry = entries[i];
             local baseLevel = self.recordingInfo.startingOffset[indexKey];
             local level = baseLevel + (i * 2);
-            self:GetTalentFrame():GetTalentButtonByNodeID(entry.nodeID).LevelingOrder:UpdateOrder(level + 2, level);
+            local button = self:GetTalentFrame():GetTalentButtonByNodeID(entry.nodeID);
+            if not button then
+                if DevTool and DevTool.AddData then
+                    DevTool:AddData({
+                        entry = entry,
+                        nodeID = nodeID,
+                        nodeInfo = self:GetTalentFrame():GetAndCacheNodeInfo(nodeID),
+                    }, 'could not find button for NodeID when updating after removing');
+                end
+            else
+                button.LevelingOrder:UpdateOrder(level + 2, level);
+            end
         end
     end
 end

TalentTreeViewer/TalentViewerUIMixin.lua

@@ -844,7 +844,18 @@ function TalentViewerUIMixin:ApplyLevelingBuild(level, lockLevelingBuild)
         if entryInfo then
             local nodeID = entryInfo.nodeID;
             local button = self:GetTalentButtonByNodeID(nodeID);
-            button.LevelingOrder:AppendToOrder(entryLevel);
+            if not button then
+                if DevTool and DevTool.AddData then
+                    DevTool:AddData({
+                        entry = entryInfo,
+                        nodeID = nodeID,
+                        level = entryLevel,
+                        nodeInfo = self:GetAndCacheNodeInfo(nodeID),
+                    }, 'could not find button for NodeID when applying');
+                end
+            else
+                button.LevelingOrder:AppendToOrder(entryLevel);
+            end
         end
     end
 

types.lua

@@ -1,7 +1,7 @@
 --- inherits ClassTalentTalentsTabMixin
 --- @class TalentViewerUIMixin: FRAME
 --- @field EnumerateAllTalentButtons fun(): fun(): TalentViewer_TalentButtonMixin
---- @field GetTalentButtonByNodeID fun(self: TalentViewerUIMixin, nodeID: number): TalentViewer_TalentButtonMixin
+--- @field GetTalentButtonByNodeID fun(self: TalentViewerUIMixin, nodeID: number): nil|TalentViewer_TalentButtonMixin
 --- @field StartRecordingButton BUTTON
 --- @field StopRecordingButton BUTTON
 --- @field LevelingBuildLevelSlider SLIDER