search: fix results not loading on direct URL entry (#353)

Co-authored-by: Marcel <me@m4rc3l.de>

Author: dnlzro

e2e/search.spec.ts

@@ -13,6 +13,16 @@ test('typing a query returns search option results', async ({ page }) => {
   await expect(page.getByRole('cell', { name: 'Whether to enable the Firefox web browser.', exact: true })).toBeVisible()
 });
 
+test('deeplnk with query returns search option results', async ({ page }) => {
+  await page.goto('/?query=fire*ox*able');
+
+  const searchResultEntry = page.getByRole('link', { name: 'programs.firefox.enable', exact: true });
+  await expect(searchResultEntry).toBeVisible()
+  await searchResultEntry.click()
+
+  await expect(page.getByRole('cell', { name: 'Whether to enable the Firefox web browser.', exact: true })).toBeVisible()
+});
+
 test('typing a query returns search package results', async ({ page }) => {
   await page.goto('/');
 
@@ -30,3 +40,14 @@ test('typing a query returns search package results', async ({ page }) => {
   await expect(page.getByRole('cell', { name: 'Web browser built from Firefox source tree', exact: true })).toBeVisible()
 });
 
+test('deeplnk with query returns search package results', async ({ page }) => {
+  await page.goto('/packages?query=fire*ox');
+
+  const searchResultEntry = page.getByRole('link', { name: 'firefox', exact: true });
+  await expect(searchResultEntry).toBeVisible()
+  await searchResultEntry.click()
+
+  await expect(page.getByRole('cell', { name: 'Web browser built from Firefox source tree', exact: true })).toBeVisible()
+});
+
+

src/app/core/components/search/search.component.ts

@@ -117,9 +117,6 @@ export class SearchComponent<T> {
     const { query, scope } = getQuery(this.activatedRoute);
     const id = this.scopes.find(s => s.name === scope)?.id ?? -1;
     this.search.setValue({ query: query ?? '', scope: id.toString() })
-
-    this.doSearch(scope === null ? null : Number(scope), query)
-      .subscribe(value => this.results.next(value));
   }
 
   protected ngOnDestroy0(): void {