fix(grabber): program error out when player data is not much sound

Author: SilentDepth

package-lock.json

@@ -45,11 +45,14 @@
     "@types/fs-extra": "^2.1.0",
     "@types/inquirer": "^6.0.0",
     "@types/js-yaml": "^3.12.5",
-    "@types/node": "^14.0.19",
+    "@types/node": "^12.19.0",
     "@typescript-eslint/eslint-plugin": "^3.6.0",
     "@typescript-eslint/parser": "^3.6.0",
     "eslint": "^7.4.0",
     "jest": "^26.1.0",
-    "typescript": "^4.0.0-beta"
+    "typescript": "^4.0.5"
+  },
+  "volta": {
+    "node": "12.18.0"
   }
 }

package.json

@@ -60,7 +60,7 @@ void async function main () {
       try {
         data = await utils.createPlayerData(uuid, banned)
       } catch (error) {
-        logger.Default.error(`Failed to create player data for ${uuid}`)
+        logger.Default.error(`Failed to create player data for ${uuid}`, JSON.stringify(error))
         continue
       }
       players.push({

src/index.ts

@@ -69,16 +69,16 @@ export default class Utils {
       let data: string | McPlayerStatsJson
       try {
         data = fs.readFileSync(statsfile, 'utf-8') as string
+        logger.PlayerData.info('READ', statsfile)
+        data = JSON.parse(data) as McPlayerStatsJson
+        return resolve({
+          merged: mergeStats(data),
+          source: data,
+        })
       } catch (error) {
-        logger.PlayerData.warn('READ', statsfile, error)
-        return reject()
+        logger.PlayerData.warn('READ', statsfile, JSON.stringify(error))
+        return resolve({merged: {}, source: {}})
       }
-      logger.PlayerData.info('READ', statsfile)
-      data = JSON.parse(data) as McPlayerStatsJson
-      return resolve({
-        merged: mergeStats(data),
-        source: data,
-      })
     })
   }
 
@@ -91,12 +91,12 @@ export default class Utils {
       let data: string
       try {
         data = fs.readFileSync(advancementsfile, 'utf-8') as string
+        logger.PlayerData.info('READ', advancementsfile)
+        return resolve(JSON.parse(data))
       } catch (error) {
-        logger.PlayerData.warn('READ', advancementsfile, error)
-        return reject()
+        logger.PlayerData.warn('READ', advancementsfile, JSON.stringify(error))
+        return resolve({})
       }
-      logger.PlayerData.info('READ', advancementsfile)
-      return resolve(JSON.parse(data))
     })
   }
 

src/utils.ts

@@ -0,0 +1 @@
+type Json = null | number | string | boolean | {[k: string]: Json} | Json[]

types/common.d.ts

@@ -23,9 +23,9 @@ interface McBannedPlayerRecord {
 
 type McBannedPlayersJson = McBannedPlayerRecord[]
 
-type McPlayerStatsJson = any // FIXME: implement it
+type McPlayerStatsJson = Json // FIXME: implement it
 
-type McPlayerAdvancementsJson = any // FIXME: implement it
+type McPlayerAdvancementsJson = Json // FIXME: implement it
 
 interface McNameHistoryRecord {
   name: string