refactor(grabber): extract config function as a module

Author: SilentDepth

src/config.ts

@@ -0,0 +1,55 @@
+/// <reference types="../types/nyaa-stats" />
+
+import path from 'path'
+import yaml from 'js-yaml'
+import fs from 'fs-extra'
+
+import * as logger from './logger'
+
+interface Config extends NSConfig {
+  __filename: string
+  __dirname: string
+
+  resolve (filepath: string): string
+
+  get<T> (keyPath: string | string[]): T
+}
+
+let config: Config
+
+export default function loadConfig (configPath = './config.yml'): Config {
+  const filename = path.resolve(configPath)
+
+  if (config?.__filename === filename) {
+    return config
+  }
+
+  let _config: NSConfig
+  try {
+    // TODO: `.yaml` support
+    _config = yaml.safeLoad(fs.readFileSync(configPath, 'utf-8')) as NSConfig
+  } catch (err) /* istanbul ignore next */ {
+    logger.Config.error('Error occurred while reading config')
+    logger.Config.error(err)
+    process.exit(1)
+  }
+
+  const dirname = path.parse(filename).dir
+  config = Object.assign(_config, {
+    __filename: filename,
+    __dirname: dirname,
+    resolve (filepath: string): string {
+      return path.resolve(dirname, filepath)
+    },
+    get<T = unknown> (keyPath: string | string[]): T {
+      if (typeof keyPath === 'string') {
+        keyPath = keyPath.split('.')
+      }
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
+      // FIXME: Better typing
+      return keyPath.reduce((value, key) => value[key], config)
+    },
+  })
+  return config
+}

src/index.ts

@@ -1,7 +1,8 @@
 import fs from 'fs-extra'
 import path from 'path'
 
-import Utils, {loadConfig} from './utils'
+import loadConfig from './config'
+import Utils from './utils'
 import {confirm, writeJSON} from './helper'
 import * as logger from './logger'
 import ProgressBar from './progressbar'

src/utils.ts

@@ -3,60 +3,14 @@
 
 import fs from 'fs-extra'
 import path from 'path'
-import yaml from 'js-yaml'
 import axios from 'axios'
 import NBT from 'mcnbt'
 
+import loadConfig from './config'
 import {defaultSkin, delay, download, mergeStats, writeJSON} from './helper'
 import * as logger from './logger'
 
-interface Config extends NSConfig {
-  __filename: string
-  __dirname: string
-
-  resolve (filepath: string): string
-
-  get<T> (keyPath: string | string[]): T
-}
-
-let config: Config
-
-export function loadConfig (configPath = './config.yml'): Config {
-  const filename = path.resolve(configPath)
-
-  if (config?.__filename === filename) {
-    return config
-  }
-
-  let _config: NSConfig
-  try {
-    // TODO: `.yaml` support
-    _config = yaml.safeLoad(fs.readFileSync(configPath, 'utf-8')) as NSConfig
-  } catch (err) /* istanbul ignore next */ {
-    logger.Config.error('Error occurred while reading config')
-    logger.Config.error(err)
-    process.exit(1)
-  }
-
-  const dirname = path.parse(filename).dir
-  config = Object.assign(_config, {
-    __filename: filename,
-    __dirname: dirname,
-    resolve (filepath: string): string {
-      return path.resolve(dirname, filepath)
-    },
-    get<T = unknown> (keyPath: string | string[]): T {
-      if (typeof keyPath === 'string') {
-        keyPath = keyPath.split('.')
-      }
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
-      // FIXME: Better typing
-      return keyPath.reduce((value, key) => value[key], config)
-    },
-  })
-  return config
-}
+const config = loadConfig()
 
 export default class Utils {
   apiLimited: boolean

tests/config.test.js

@@ -1,6 +1,6 @@
 import path from 'path'
 
-import {loadConfig} from '../src/utils'
+import loadConfig from '../src/config'
 
 describe('config', () => {
   const configPath = path.resolve(__dirname, './mocks/config.yml')
@@ -21,4 +21,8 @@ describe('config', () => {
     expect(config.resolve('../file')).toBe(path.resolve(configPath, '../../file'))
     expect(config.resolve('/file')).toBe('/file')
   })
+
+  test('should return the same config object when calling loadConfig() again with same configPath', () => {
+    expect(loadConfig(configPath)).toBe(config)
+  })
 })