BREAKING CHANGE: remove name history length limit

Author: SilentDepth

config.example.yml

@@ -25,7 +25,6 @@ render:
 
 api:
   ratelimit: 2 # set to 1 request per sec as per mojang api rate limit
-  max-name-history: 3 # Maximum history will be recorded
 
 # Set advancements progresses
 # Details: http://minecraft.gamepedia.com/Advancements

utils.js

@@ -183,21 +183,16 @@ export default class Utils {
 
   async getNameHistory(uuid) {
     const apiNameHistory = `https://api.mojang.com/user/profiles/${uuid}/names`;
-    const history = [];
-    let res;
+    let history;
     try {
-      res = await this.getMojangAPI(apiNameHistory);
+      history = await this.getMojangAPI(apiNameHistory);
     } catch (err) {
       return null;
     }
-    if (!res) return null;
-    let limit = this.config.api['max-name-history'];
-    if (res.length < this.config.api['max-name-history']) {
-      limit = res.length;
-    }
-    for (let i = 1; i <= limit; i += 1) {
-      history.push(res[res.length - i]);
-    }
+    if (!history) return null;
+    // The order of the response data from Mojang API is uncertain,
+    // so manually sort it (to descending order) for making sure.
+    history.sort((a, b) => (b.changedToAt || 0) - (a.changedToAt || 0))
     return history;
   }
 

web/src/assets/lang.json

@@ -386,7 +386,6 @@
     "nyaa.general.search_placeholder": "Search player by name / UUID",
     "nyaa.general.go_random_player": "Feel lucky",
     "nyaa.general.go_random_player_again": "One more luck",
-    "nyaa.general.loading_hint": "Loading...",
     "nyaa.app_menu.section_title.others": "Others",
     "nyaa.home.explore_link_label": "Explore",
     "nyaa.home.starring_number.uptime": "Uptime",
@@ -782,7 +781,6 @@
     "nyaa.general.search_placeholder": "按名称 / UUID 搜索玩家",
     "nyaa.general.go_random_player": "随机查看",
     "nyaa.general.go_random_player_again": "再随机一次",
-    "nyaa.general.loading_hint": "加载中…",
     "nyaa.app_menu.section_title.others": "其他",
     "nyaa.home.explore_link_label": "去看看",
     "nyaa.home.starring_number.uptime": "世界历时",

web/src/components/PlayerNameHistory.vue

@@ -9,14 +9,11 @@
         <strong class="font-normal mr-3">{{ name }}</strong>
         <span class="ml-auto text-gray-500 font-tnum">{{ formatDate(changedToAt) || t('nyaa.player_name_history.first_name') }}</span>
       </li>
-      <li v-if="isLoadingNameHistory" class="p-3 border-t first:border-t-0 border-gray-300 bg-gray-100 text-gray-500 flex items-center">{{ t('nyaa.general.loading_hint') }}</li>
     </ul>
   </PlayerAsidePanel>
 </template>
 
 <script>
-  import axios from 'axios'
-
   import PlayerAsidePanel from '@/components/PlayerAsidePanel.vue'
   import {normalizeDate} from '@/common/utils'
 
@@ -37,7 +34,6 @@
     data () {
       return {
         names: this.player.data.names,
-        isLoadingNameHistory: true,
       }
     },
 
@@ -53,24 +49,7 @@
       },
     },
 
-    created () {
-      this.loadNameHistory()
-    },
-
     methods: {
-      async loadNameHistory () {
-        if (this.names.slice(-1)[0].changedToAt) {
-          const {data} = await axios(
-            process.env.NODE_ENV === 'development'
-              ? `/mojang-api/user/profiles/${this.player.data.uuid_short}/names`
-              : `https://mojang-api.silent.land/${location.host}/user/profiles/${this.player.data.uuid_short}/names`
-          )
-          this.names = data.reverse()
-        }
-
-        this.isLoadingNameHistory = false
-      },
-
       formatDate (val) {
         return val && normalizeDate(val, 'short')
       },