main: CONTRIBUTING note on buid-src for Windows users
#4494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note callouts apparently can't be below bullet list items. Moving it to the end of the section.
lornajane
reviewed
Mar 24, 2025
Contributor
lornajane
left a comment
lornajane
left a comment
There was a problem hiding this comment.
I realise I'm nitpicking, but can we put the note at the start of the section, before the user needs the information? Also it looks odd in context where we now have a note, then a heading, then another note right after that.
Contributor
Author
@lornajane I was wondering that myself, thanks for confirming my doubts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note callouts apparently can't be within bullet lists.
Moving it to the end of the section.
Note
Note for VS Code users: the local preview nicely renders Note callouts in bullet lists and allows changing the callout title to something other than "Note". This doesn't work in Github.
Tick one of the following options: