Skip to content

Conversation

paulRbr
Copy link

@paulRbr paulRbr commented Sep 23, 2025

  • no schema changes are needed for this pull request

It seems one of the link is fixed in #4980 but targets 3.3-dev, I don't know how the dev process works and how the fixes are backported (the links are probably broken in previous version of OpenAPI and also in the future 3.3 version)

@paulRbr paulRbr requested review from a team as code owners September 23, 2025 09:27
@ralfhandl ralfhandl requested a review from a team September 23, 2025 09:33
@ralfhandl
Copy link
Contributor

@paulRbr Thanks for finding these!

And feel free to create a twin PR targeting v3.3-dev, we don't have an automated forward-port mechanism.

@handrews
Copy link
Member

@ralfhandl how did this get past the build scripts? I know I've gotten errors on missing # before, for example. Also, does this need to be patched on main like the other broken link?

@lornajane
Copy link
Contributor

Markdown lint saw these as valid syntax. I have a link checker on my todo list though!

@ralfhandl
Copy link
Contributor

Markdown lint saw these as valid syntax

The broken supposedly internal links didn't start with a # and were treated as external links and thus not checked.

A link checker that (also) checks external links would be very helpful.

@ralfhandl
Copy link
Contributor

Any objections to merging this and its v3.3 twin?

@ralfhandl ralfhandl added this to the v3.2.1 milestone Sep 23, 2025
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Sep 23, 2025
@ralfhandl ralfhandl changed the title Fix dead anchor links to appendix 3.2.1: Fix dead anchor links to appendix Sep 25, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl merged commit 0847e98 into OAI:v3.2-dev Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Wording and stylistic issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants