Skip to content

Commit f49e51f

Browse files
authored
Merge pull request #178 from ralfhandl/main-run-checks-on-pull-requests
main: Run checks on pull requests
2 parents 9ab3709 + 23803ea commit f49e51f

File tree

2 files changed

+31
-32
lines changed

2 files changed

+31
-32
lines changed

.github/workflows/schema-tests.yaml

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,28 @@ name: schema-tests
88
# testcases for the metaschemas
99
#
1010

11-
# run this on push to any branch and creation of pull-requests
12-
on:
13-
push: {}
11+
# run this on pull-requests (creation and updates) and on manual trigger
12+
on:
1413
pull_request: {}
1514
workflow_dispatch: {}
1615

1716
jobs:
1817
test:
19-
2018
runs-on: ubuntu-latest
2119

2220
steps:
23-
- uses: actions/checkout@v5 # checkout repo content
24-
with:
25-
fetch-depth: 0
21+
- uses: actions/checkout@v5 # checkout repo content
22+
with:
23+
fetch-depth: 0
2624

27-
- uses: actions/setup-node@v6 # setup Node.js
28-
with:
29-
node-version: '20.x'
25+
- uses: actions/setup-node@v6 # setup Node.js
26+
with:
27+
node-version: "20.x"
3028

31-
- name: Install dependencies from main
32-
run: |
33-
# git checkout remotes/origin/main -- package.json package-lock.json #TODO: uncomment with subsequent PR
34-
npm ci
29+
- name: Install dependencies from main
30+
run: |
31+
# git checkout remotes/origin/main -- package.json package-lock.json #TODO: uncomment with subsequent PR
32+
npm ci
3533
36-
- name: Run tests
37-
run: npm test
34+
- name: Run tests
35+
run: npm test

.github/workflows/validate-markdown.yaml

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,26 @@ name: validate-markdown
77
# This workflow validates markdown files in the versions directory matching *.md
88
#
99

10-
# run this on push to any branch and creation of pull-requests
11-
on: [push, pull_request]
10+
# run this on pull-requests (creation and updates) and on manual trigger
11+
on:
12+
pull_request: {}
13+
workflow_dispatch: {}
1214

1315
jobs:
1416
mdv:
15-
1617
runs-on: ubuntu-latest
1718

1819
steps:
19-
- uses: actions/checkout@v5 # checkout repo content
20-
with:
21-
fetch-depth: 0
22-
# - name: use the javascript environment from main
23-
# run: |
24-
# git checkout remotes/origin/main -- package.json package-lock.json .markdownlint.yaml
25-
- uses: actions/setup-node@v6 # setup Node.js
26-
with:
27-
node-version: '20.x'
28-
- name: Validate markdown
29-
run: npx --yes mdv versions/*.md
30-
- name: Lint markdown
31-
run: npx --yes markdownlint-cli --config .markdownlint.yaml versions/*.md
20+
- uses: actions/checkout@v5 # checkout repo content
21+
with:
22+
fetch-depth: 0
23+
# - name: use the javascript environment from main
24+
# run: |
25+
# git checkout remotes/origin/main -- package.json package-lock.json .markdownlint.yaml
26+
- uses: actions/setup-node@v6 # setup Node.js
27+
with:
28+
node-version: "20.x"
29+
- name: Validate markdown
30+
run: npx --yes mdv versions/*.md
31+
- name: Lint markdown
32+
run: npx --yes markdownlint-cli --config .markdownlint.yaml versions/*.md

0 commit comments

Comments
 (0)