[OU-IMP] delivery: Refine migration scripts + work

Author: pedrobaeza

addons/delivery/migrations/13.0.1.0/openupgrade_analysis_work.txt

@@ -4,15 +4,23 @@ new model choose.delivery.carrier [transient]
 
 ---Fields in module 'delivery'---
 delivery     / delivery.carrier         / get_return_label_from_portal (boolean): NEW
+delivery     / delivery.carrier         / return_label_on_delivery (boolean): NEW
+# NOTHING TO DO: New feature for allowing to print the return label. Default False value is OK for preserving previous behavior (no return label).
+
 delivery     / delivery.carrier         / invoice_policy (selection)    : NEW required, selection_keys: ['estimated', 'real'], req_default: function, hasdefault
+# DONE: post-migration: Fill all delivery.carrier records to have `real` value in invoice_policy, as this is the most similar one to the v12 behavior
+
 delivery     / delivery.carrier         / margin (integer)              : type is now 'float' ('integer')
-delivery     / delivery.carrier         / return_label_on_delivery (boolean): NEW
+# NOTHING TO DO: ORM/PG does the switch automatically
+
 delivery     / sale.order               / delivery_price (float)        : DEL
+# NOTHING TO DO: There's no carrier selection now in sale.order, only via wizard, so no computed price is shown in header
+
 delivery     / sale.order               / invoice_shipping_on_delivery (boolean): DEL
-# NOTHING TO DO
+# NOTHING TO DO: The control for adding delivery line on picking is done with delivery.carrier.invoice_policy
 
 delivery     / sale.order               / recompute_delivery_price (boolean): NEW
-# DONE: post-migration: marked as True if it has carrier
+# DONE: post-migration: marked as True if it has carrier and still quotation, for having the button "Update shipping cost" as highlighted
 
 ---XML records in module 'delivery'---
 NEW ir.ui.view: delivery.choose_delivery_carrier_view_form
@@ -21,7 +29,7 @@ NEW ir.ui.view: delivery.sale_order_portal_content_inherit_sale_stock_inherit_we
 NEW ir.ui.view: delivery.vpicktree_view_tree
 DEL ir.ui.view: delivery.assets_backend
 DEL ir.ui.view: delivery_hs_code.product_template_hs_code
-# NOTHING TO DO
+# NOTHING TO DO: noupdate="0" records
 
 DEL mail.template: delivery.mail_template_data_delivery_confirmation [renamed to stock module] (noupdate)
 # NOTHING TO DO: handled in stock

addons/delivery/migrations/13.0.1.0/post-migration.py

@@ -3,17 +3,28 @@
 from openupgradelib import openupgrade
 
 
+def fill_delivery_carrier_invoice_policy(env):
+    """Fill all delivery.carrier records to have `real` value in invoice_policy,
+    as this is the most similar one to the v12 behavior.
+    """
+    openupgrade.logged_query(
+        env.cr, "UPDATE delivery_carrier SET invoice_policy = 'real'"
+    )
+
+
 def fill_sale_order_recompute_delivery_price(env):
     openupgrade.logged_query(
         env.cr, """
         UPDATE sale_order
         SET recompute_delivery_price = TRUE
-        WHERE carrier_id IS NOT NULL"""
+        WHERE carrier_id IS NOT NULL
+        AND state IN ('draft', 'sent')"""
     )
 
 
 @openupgrade.migrate()
 def migrate(env, version):
+    fill_delivery_carrier_invoice_policy(env)
     fill_sale_order_recompute_delivery_price(env)
     openupgrade.load_data(
         env.cr, "delivery", "migrations/13.0.1.0/noupdate_changes.xml")