[16.0/17.0/18.0] account_analytic_distribution_manual: JS crash in account_reconcile_oca

[alexis-via]

Here are the steps to reproduce the bug:

1. On Odoo CE 16.0, create a new DB
2. Install the module account_reconcile_oca from OCA/account-reconcile
3. Enable analytic accounting
4. In the bank reconcile interface, select an unreconciled statement line. Select the counterpart line, click on the "Manual operation" tab, set an account and set an analytic distribution (for example : on the 'Projects' plan, set 100% for 'Deco Addict')
5. click on the button "Validate" : it works
6. install the module account_analytic_distribution_manual from OCA/account-analytic
7. Re-run steps 4 and 5 on a new unreconciled statement line. When you click on the button "Validate", you get a JS crash:

UncaughtPromiseError > TypeError

Uncaught Promise > can't access property "type", this.fields[fieldName] is undefined

The bug happens on 16.0, but not on 17.0 nor 18.0.
I really love the module account_analytic_distribution_manual... but we can't keep it if it triggers crashes in the OCA bank reconcile interface.

[alexis-via]

One precision in the bug scenario : when account_analytic_distribution_manual is installed, you don't need to click on the button "Validate" in the bank statement reconcile interface to get the JS crash, you just need to click anywhere outside the analytic distribution pop-up to get the crash.

[alexis-via]

The bug is also present in 17.0 and 18.0 with a slightly different scenario:

After installing account_analytic_distribution_manual, go to the menu "Invoicing > Configuration > Analytic Accounting > Manual analytic distribution" and create a manual analytic distrib.
In the OCA bank reconcile interface, select an unreconciled statement line, select the counterpart line, click on the "Manual operation" tab, open the analytic distribution pop-up and select the manual analytic distribution you just created. Then click anywhere in the interface outside the analytic distrib pop-up and you get a JS crash:

Odoo Client Error
UncaughtPromiseError > TypeError

Uncaught Promise > can't access property "type", field is undefined

Occured on localhost:8069 on 2025-10-22 16:25:09 GMT

TypeError: can't access property "type", field is undefined
    _preprocessPropertiesChanges@http://localhost:8069/web/assets/debug/web.assets_web.js:58014:17 (/web/static/src/model/relational_model/record.js:925)
    _update@http://localhost:8069/web/assets/debug/web.assets_web.js:58333:18 (/web/static/src/model/relational_model/record.js:1244)
    update/<@http://localhost:8069/web/assets/debug/web.assets_web.js:57348:24 (/web/static/src/model/relational_model/record.js:259)
    always@http://localhost:8069/web/assets/debug/web.assets_web.js:41576:36 (/web/static/src/core/utils/concurrency.js:107)

[alexis-via]

Here are some info about my debug party on 16.0:
in account_analytic_distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js
it crashes in the save() method. The crash is after super, in the code where it updates this.props.record to set manual_distribution_id:

https://github.com/OCA/account-analytic/blob/16.0/account_analytic_distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js#L46

I compared that code to 17.0 and noticed a change: the update of this.props.record is inside "if (this.state_manual_distribution.id)", cf:

https://github.com/OCA/account-analytic/blob/17.0/account_analytic_distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js#L43

When I take this 17.0 piece of code (line 43 to 50) to 16.0, then it solves the crash when you manually configure the analytic accounts in the analytic distrib pop-up... but you still get the JS crash when you select a manual analytic distribution. So, with this backport from 17.0 to 16.0 in the save() method, the bug becomes the same on 16.0 as on 17.0 and 18.0. It's not perfect, but it's better ! I'll create a PR for this partial fix for 16.0.

[alexis-via]

@carlos-lopez-tecnativa As the author of the module account_analytic_distribution_manual, are you aware of this problem when used in the OCA bank statement reconcile interface ? Your idea/suggestions would be very welcomed.