[16.0][IMP] contract: Added domain,constraint for pricelist_id

  Using domain for field "pricelist_id" which lists
pricelist whose currency is matched with journal_id
currency. This domain helps to avoid using different
currency within same contract.
  Similary, api constraint check added to check
currency consistency between journal and pricelist.
  Updating pricelist_id when pricelist or journal
currency is changed.

Author: anusriNPS

contract/models/abstract_contract.py

@@ -6,7 +6,8 @@
 # Copyright 2018 ACSONE SA/NV
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class ContractAbstractContract(models.AbstractModel):
@@ -23,7 +24,15 @@ class ContractAbstractContract(models.AbstractModel):
     partner_id = fields.Many2one(
         comodel_name="res.partner", string="Partner", index=True
     )
-    pricelist_id = fields.Many2one(comodel_name="product.pricelist", string="Pricelist")
+    pricelist_id_domain = fields.Binary(
+        compute="_compute_pricelist_id_domain", readonly=True, store=False
+    )
+    pricelist_id = fields.Many2one(
+        comodel_name="product.pricelist",
+        string="Pricelist",
+        compute="_compute_pricelist_id",
+        store=True,
+    )
     contract_type = fields.Selection(
         selection=[("sale", "Customer"), ("purchase", "Supplier")],
         default="sale",
@@ -56,6 +65,17 @@ class ContractAbstractContract(models.AbstractModel):
         help="Choose the document that will be automatically generated by cron.",
     )
 
+    @api.constrains("pricelist_id")
+    def check_currency(self):
+        for rec in self:
+            if rec.pricelist_id and (
+                rec.journal_id.currency_id
+                and rec.journal_id.currency_id != rec.pricelist_id.currency_id
+            ):
+                raise UserError(
+                    _("Curreny should be same for Journal and Pricelist in a Contract")
+                )
+
     @api.model
     def _default_generation_type(self):
         return "invoice"
@@ -80,3 +100,27 @@ def _compute_journal_id(self):
                 contract.journal_id = journal.id
             else:
                 contract.journal_id = None
+
+    @api.depends("journal_id")
+    def _compute_pricelist_id_domain(self):
+        for rec in self:
+            rec.pricelist_id_domain = (
+                [("currency_id", "=", rec.journal_id.currency_id.id)]
+                if rec.journal_id.currency_id
+                else []
+            )
+
+    @api.depends("journal_id.currency_id", "pricelist_id.currency_id")
+    def _compute_pricelist_id(self):
+        for rec in self:
+            if rec.pricelist_id and (rec.journal_id.currency_id != rec.pricelist_id.currency_id):
+                rec.pricelist_id = None
+
+    @api.onchange("journal_id")
+    def _onchange_journal_id(self):
+        self.ensure_one()
+        if (
+            self.journal_id.currency_id
+            and self.journal_id.currency_id != self.pricelist_id.currency_id
+        ):
+            self.pricelist_id = None

contract/tests/test_contract.py

@@ -2366,6 +2366,35 @@ def test_recurrency_propagation(self):
         for field in vals:
             self.assertEqual(vals[field], contract2.contract_line_ids[field])
 
+    def test_pricelist_journal_currency_match(self):
+        currency_eur = self.env.ref("base.EUR")
+        currency_cad = self.env.ref("base.CAD")
+        journal = self.env["account.journal"].create(
+            {
+                "name": "Test journal CAD",
+                "code": "TCAD",
+                "type": "sale",
+                "currency_id": currency_cad.id,
+            }
+        )
+        pricelist = self.env["product.pricelist"].create(
+            {"name": "Test pricelist", "currency_id": currency_cad.id}
+        )
+        self.contract2.journal_id = journal.id
+        self.contract2.pricelist_id = pricelist.id
+        self.assertEqual(self.contract2.journal_id.currency_id, self.contract2.pricelist_id.currency_id)
+        # Check pricelist currency_id change
+        pricelist.currency_id = currency_eur.id
+        self.assertEqual(self.contract2.pricelist_id.ids, [])
+        self.assertEqual(self.contract2.currency_id, self.contract2.journal_id.currency_id)
+        # Check journal currency_id change
+        pricelist.currency_id = currency_cad.id
+        self.contract2.partner_id.property_product_pricelist = pricelist.id
+        self.contract2.contract_line_ids.automatic_price = True
+        journal.currency_id = currency_eur.id
+        self.assertEqual(self.contract2.pricelist_id.ids, [])
+        self.assertEqual(self.contract2.currency_id, currency_cad)
+
     def test_currency(self):
         currency_eur = self.env.ref("base.EUR")
         currency_cad = self.env.ref("base.CAD")
@@ -2385,13 +2414,16 @@ def test_currency(self):
         )
         self.contract2.journal_id = journal.id
         self.assertEqual(self.contract2.currency_id, currency_cad)
-        # Get currency from contract pricelist
+        # Currency should match for Journal and Pricelist
         pricelist = self.env["product.pricelist"].create(
             {"name": "Test pricelist", "currency_id": currency_eur.id}
         )
-        self.contract2.pricelist_id = pricelist.id
+        error_msg = "Curreny should be same for Journal and Pricelist in a Contract"
+        with self.assertRaisesRegex(UserError, error_msg):
+             self.contract2.pricelist_id = pricelist.id
+        pricelist.currency_id = currency_cad
         self.contract2.contract_line_ids.automatic_price = True
-        self.assertEqual(self.contract2.currency_id, currency_eur)
+        self.assertEqual(self.contract2.currency_id, currency_cad)
         # Get currency from partner pricelist
         self.contract2.pricelist_id = False
         self.contract2.partner_id.property_product_pricelist = pricelist.id

contract/views/contract.xml

@@ -105,6 +105,7 @@
                     <group name="main">
                         <group>
                             <field name="commercial_partner_id" invisible="1" />
+                            <field name="pricelist_id_domain" invisible="1" />
                             <field
                                 name="partner_id"
                                 required="1"
@@ -113,6 +114,7 @@
                             <field
                                 name="pricelist_id"
                                 attrs="{'readonly': [('is_terminated','=',True)]}"
+                                domain="pricelist_id_domain"
                             />
                             <field
                                 name="payment_term_id"